summaryrefslogtreecommitdiff
path: root/AUTHORS
Commit message (Collapse)AuthorAgeFilesLines
* AUTHORS: Add Eric Garver.Ben Pfaff2016-10-041-0/+1
| | | | Signed-off-by: Ben Pfaff <blp@ovn.org>
* ovn: update docs for l2gateway port vlan tagGabe Beged-Dov2016-09-301-0/+1
| | | | | | | | | | update description of l2gateway logical switch ports to include optional vlan tag. Also restore comment in ovn/controller/physical.c from original commit by Russell Bryant (184bc3c ovn: Add software l2 gateway) on 7/1/2016. Signed-off-by: Gabe Beged-Dov <gabe@begeddov.com> Co-authored-by: Russell Bryant <russell@ovn.org> Signed-off-by: Russell Bryant <russell@ovn.org>
* tests: Use standard -q option to grep in place of GNU --quiet extension.Ben Pfaff2016-09-301-0/+1
| | | | | | | Reported-by: Stuart Cardall <developer@it-offshore.co.uk> Reported-at: http://openvswitch.org/pipermail/discuss/2016-September/022803.html Signed-off-by: Ben Pfaff <blp@ovn.org> Acked-by: Flavio Fernandes <flavio@flaviof.com>
* netdev-linux: Use ethtool when miimon fails.David Hill2016-09-271-0/+1
| | | | | | | | | | Some network drivers might return true to SIOCGMIIPHY and an error on SIOCGMIIREG when using MII to query phy state. Fall back to ethtool if this happens to allow failover to work when using such nics. Reported-at: http://openvswitch.org/pipermail/dev/2016-August/078800.html Signed-off-by: David Hill <dhill@redhat.com> Signed-off-by: Joe Stringer <joe@ovn.org>
* datapath-windows: Add define for last module numberShashank Ram2016-09-201-0/+1
| | | | | | | | | Adds a define for the last defined module number. Signed-off-by: Shashank Ram <rams@vmware.com> Acked-by: Sairam Venugopal <vsairam@vmware.com> Acked-by: Nithin Raju <nithin@vmware.com> Signed-off-by: Gurucharan Shetty <guru@ovn.org>
* ofproto-dpif-sflow: Tolerate unknown datapath input port for tunnel.Neil McKee2016-09-021-0/+1
| | | | | | | | | | | This patch avoids a segfault. Submitted-at: https://github.com/openvswitch/ovs/pull/152 Reported-at: http://openvswitch.org/pipermail/discuss/2016-August/022513.html Reported-by: 张东亚 <fortitude.zhang@gmail.com> Fixes: 7321bda384c3 ("Extend sFlow agent to report tunnel and MPLS structures") Signed-off-by: Neil McKee <neil.mckee@inmon.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* AUTHORS: Add Anand to AUTHORS file.Gurucharan Shetty2016-09-011-0/+1
| | | | Signed-off-by: Gurucharan Shetty <guru@ovn.org>
* ovsdb: Fix mutation of newly inserted rows from Python IDL.Amitabha Biswas2016-08-301-0/+2
| | | | | | | | | | | | | | | This patch fixes the scenario, where the mutate operation on a row is sent in the same transaction as row insert operation. It was obvserved that this mutate operation was not getting committed to the OVSDB. To get around the above problem the "where" condition in an mutate operation is modified to use the named-uuid to identify a row created in the current transaction. Signed-off-by: Amitabha Biswas <abiswas@us.ibm.com> Suggested-by: Richard Theis <rtheis@us.ibm.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* AUTHORS: Add Conner Herriges.Ben Pfaff2016-08-261-0/+1
| | | | Signed-off-by: Ben Pfaff <blp@ovn.org>
* ovs-ofctl: Added clarifications and examples to manpage.Ori Shoshan2016-08-141-0/+1
| | | | | | | | Added a few examples and clarifications to the man page to explain points I had difficulty figuring out without reading code/tests. Signed-off-by: Ori Shoshan <ori.shoshan@guardicore.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* netdev-dpdk: When no QoS set, set type to empty stringMaxime Coquelin2016-08-041-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | This patch sets *typep to an empty string instead of letting it uninitialized when no QoS configuration is set. It fixes the following vswitchd crash when no QoS has been set on vhost-user interface: $> ovs-appctl -t ovs-vswitchd qos/show vhost-user1 #0 0x00007efcbadf18d7 in raise () from /lib64/libc.so.6 #1 0x00007efcbadf353a in abort () from /lib64/libc.so.6 #2 0x000000000068d5be in ovs_abort_valist at lib/util.c:335 #3 0x0000000000693d90 in vlog_abort_valist at lib/vlog.c:1204 #4 0x0000000000693e17 in vlog_abort at lib/vlog.c:1218 #5 0x000000000068d3ae in ovs_assert_failure at lib/util.c:72 #6 0x000000000060425c in ds_put_format_valist at lib/dynamic-string.c:168 #7 0x00000000006042e7 in ds_put_format at lib/dynamic-string.c:142 #8 0x00000000005a9e75 in qos_unixctl_show at vswitchd/bridge.c:3185 #9 0x000000000068cda1 in process_command at lib/unixctl.c:347 #11 unixctl_server_run at lib/unixctl.c:400 #12 0x000000000040a3ff in main at vswitchd/ovs-vswitchd.c:113 Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com> Acked-by: Ian Stokes <ian.stokes@intel.com> Signed-off-by: Daniele Di Proietto <diproiettod@vmware.com>
* netdev-dpdk: Add Flow Control support.Sugesh Chandran2016-07-291-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add support for flow-control(mac control frame) to DPDK enabled physical port types. By default, the flow-control is OFF on both rx and tx side. The flow control can be enabled/disabled either when adding a port to OVS or at run time. For eg: To enable flow control support at tx side while adding a port, add the 'tx-flow-ctrl' option to the 'ovs-vsctl add-port' command-line as below. 'ovs-vsctl add-port br0 dpdk0 -- \ set Interface dpdk0 type=dpdk options:tx-flow-ctrl=true' Similarly to enable rx flow control, 'ovs-vsctl add-port br0 dpdk0 -- \ set Interface dpdk0 type=dpdk options:rx-flow-ctrl=true' And to enable the flow control auto-negotiation, 'ovs-vsctl add-port br0 dpdk0 -- \ set Interface dpdk0 type=dpdk options:flow-ctrl-autoneg=true' To turn ON the tx flow control at run time(After the port is being added to OVS), the command-line input will be, 'ovs-vsctl set Interface dpdk0 options:tx-flow-ctrl=true' The flow control parameters can be turned off by setting 'false' to the respective parameter. To dsiable the flow control at tx side, 'ovs-vsctl set Interface dpdk0 options:tx-flow-ctrl=false' Signed-off-by: Sugesh Chandran <sugesh.chandran@intel.com> Acked-by: Bhanuprakash Bodireddy <Bhanuprakash.bodireddy@intel.com> Signed-off-by: Daniele Di Proietto <diproiettod@vmware.com>
* ovn-northd, tests: Adding IPAM to ovn-northd.Nimay Desai2016-07-281-0/+1
| | | | | | | | | | | | | | | | | Added an IPv4 and MAC addresses management system to ovn-northd. When a logical switch's other_config:subnet field is set, logical ports attached to that switch that have the keyword "dynamic" in their addresses column will automatically be allocated a globally unique MAC address/unused IPv4 address within the provided subnet. The allocated address will populate the dynamic_addresses column. This can be useful for a user who wants to deploy many VM's or containers with networking capabilities, but does not care about the specific MAC/IPv4 addresses that are assigned. Added tests in ovn.at for ipam. Signed-off-by: Nimay Desai <nimaydesai1@gmail.com> Acked-by: Ben Pfaff <blp@ovn.org> Signed-off-by: Gurucharan Shetty <guru@ovn.org>
* ovn: add easy SNAT test case.Dongjun2016-07-281-0/+1
| | | | | Signed-off-by: Dongjun <dongj@dtdream.com> Signed-off-by: Gurucharan Shetty <guru@ovn.org>
* netdev-dpdk: remove duplicated code in netdev_dpdk_get_statusxubinbin2016-07-251-0/+1
| | | | | | | | Put "driver_name" into "args" twice, that's meaninglessness. So need to remove duplicated code. Signed-off-by: Binbin Xu <xu.binbin1@zte.com.cn> Signed-off-by: Daniele Di Proietto <diproiettod@vmware.com>
* AUTHORS: Add Eziz Durdyyev.Ben Pfaff2016-07-141-0/+1
| | | | Signed-off-by: Ben Pfaff <blp@ovn.org>
* INSTALL.Docker.md: Clarify OVS python library path.Gurucharan Shetty2016-07-071-0/+1
| | | | | | Reported-by: Taekho Nam <thnam@smartx.kr> Signed-off-by: Gurucharan Shetty <guru@ovn.org> Acked-by: Russell Bryant <russell@ovn.org>
* docs: OVSDB replication design documentMario Cabrera2016-06-241-0/+1
| | | | | | | | | | | | | The database replication functionality is designed to provide "fail over" characteristics. There are two participating databases, one of which is the "active" database and the other is the "stand by" database. Replication happens exclusively from the active to the stand by database. This document explains how the replication functionality is implemented. Signed-off-by: Mario Cabrera <mario.cabrera@hpe.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* ovsdb-idl: Fix issues detected in Partial Map Update featureLutz, Arnoldo2016-06-241-0/+1
| | | | | | | | | | | | | | We found some issues affecting Partial Map Update feature included in master branch. This patch fixes a memory leak due to lack of freeing datum allocated in the process of requesting a change to a map. It also fix an error produced when NDEBUG flag is not set that causes an assertion when preparing the map to be changed. Fix of a memory leak not freeing datums. Change use of ovsdb_idl_read function when preparing changes to maps. Signed-off-by: arnoldo.lutz.guevara@hpe.com <arnoldo.lutz.guevara@hpe.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* ovn: Allow IP packets destined to router ip for SNATChandra S Vejendla2016-06-221-0/+1
| | | | | | | | | By default all the ip traffic destined to router ip is dropped in lr_in_ip_input stage. When the router ip is used as snat ip, allow reverse snat traffic destined to the router ip. Signed-off-by: Chandra Sekhar Vejendla <csvejend@us.ibm.com> Signed-off-by: Gurucharan Shetty <guru@ovn.org>
* ofp-util: Fix parsing of parenthesized values within key-value pairs.Ben Pfaff2016-06-141-0/+1
| | | | | | Reported-by: james hopper <jameshopper@email.com> Reported-at: http://openvswitch.org/pipermail/discuss/2016-June/021662.html Signed-off-by: Ben Pfaff <blp@ovn.org>
* tests: Fixed access denied on ovs-vswitchd.logPaul Boca2016-06-061-0/+1
| | | | | | | | | On Windows trying to overwrite the opened ovs-vswitchd.log fails with access denied. Closing it before trying to overwrite it solves the problem Signed-off-by: Paul-Daniel Boca <pboca@cloudbasesolutions.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* ipfix: Bug fix for configuring IPFIX for flowsBenli Ye2016-06-051-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There are two kinds of IPFIX: bridge level IPFIX and flow level IPFIX. Now if we only configure flow level IPFIX, even if there is no bridge IPFIX configuration, the datapath flow will contain a sample action for bridge IPFIX. Fix it. Steps to configure flow level IPFIX: 1) Create a new record in Flow_Sample_Collector_Set table: 'ovs-vsctl -- create Flow_Sample_Collector_Set id=1 bridge="Bridge UUID"' 2) Add IPFIX configuration which is referred by corresponding row in Flow_Sample_Collector_Set table: 'ovs-vsctl -- set Flow_Sample_Collector_Set "Flow_Sample_Collector_Set UUID" ipfix=@i -- --id=@i create IPFIX targets=\"IP:4739\" obs_domain_id=123 obs_point_id=456 cache_active_timeout=60 cache_max_flows=13' 3) Add sample action to the flows: 'ovs-ofctl add-flow mybridge in_port=1, actions=sample'('probability=65535,collector_set_id=1, obs_domain_id=123,obs_point_id=456')',output:LOCAL' Before this fix, if you only configure flow IPFIX, the datapath flow is: id(0),in_port(2),eth_type(0x0806), packets:0, bytes:0, used:never, actions:sample(sample=0.0%,actions(userspace(pid=4294960835, ipfix(output_port=4294967295)))),sample(sample=100.0%, actions(userspace(pid=4294960835,flow_sample(probability=65535, collector_set_id=1,obs_domain_id=123,obs_point_id=456)))), sample(sample=0.0%,actions(userspace(pid=4294960835, ipfix(output_port=1)))),1 The datapath flow should only contain the sample action like below: id(0),in_port(2),eth_type(0x0800),ipv4(frag=no), packets:9, bytes:871, used:0.656s, actions:sample(sample=100.0%,actions(userspace(pid=4294962911, flow_sample(probability=65535,collector_set_id=1,obs_domain_id=123, obs_point_id=456)))),1 Signed-off-by: Benli Ye <daniely@vmware.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* AUTHORS: Add Dustin Lundquist.Ben Pfaff2016-06-021-0/+1
| | | | Signed-off-by: Ben Pfaff <blp@ovn.org>
* netdev-dpdk: vhost-user port link state fixZoltán Balogh2016-06-021-0/+1
| | | | | | | | | | | | | | | | | | | OVS reports that link state of a vhost-user port (type=dpdkvhostuser) is DOWN, even when traffic is running through the port between a Virtual Machine and the vSwitch. Changing admin state with the "ovs-ofctl mod-port <BR> <PORT> up/down" command over OpenFlow does affect neither the reported link state nor the traffic. The patch below does the flowing: - Triggers link state change by altering netdev's change_seq member. - Controls sending/receiving of packets through vhost-user port according to the port's current admin state. - Sets admin state of newly created vhost-user port to UP. Signed-off-by: Zoltán Balogh <zoltan.balogh@ericsson.com> Co-authored-by: Jan Scheurich <jan.scheurich@ericsson.com> Signed-off-by: Jan Scheurich <jan.scheurich@ericsson.com> Signed-off-by: Daniele Di Proietto <diproiettod@vmware.com>
* util: Drop 'date' and 'time' arguments from ovs_set_program_nameMarkos Chandras2016-05-261-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The 'date' and 'time' arguments are normally being set by 'ovs_set_program_name' using __DATE__ and __TIME__. However, this breaks reproducible builds since even without any changes in the toolchain, build system etc, the end binary will still differ in that regard. This is also visible when building with -Wdate-time: utilities/ovs-dpctl.c:61:29: warning: macro "__DATE__" might prevent reproducible builds [-Wdate-time] set_program_name(argv[0]); ^ and it's also something that triggers the following warning in the openSUSE OBS builds: [...] openvswitch.x86_64: W: file-contains-date-and-time /usr/bin/ovs-ofctl openvswitch.x86_64: W: file-contains-date-and-time /usr/bin/ovs-appctl Your file uses __DATE and __TIME__ this causes the package to rebuild when not needed [...] This patch drops these two arguments from ovs_set_program_name__ and renames the function to ovs_set_program_name dropping the previous preprocessor macro in the process. This finally removes the remaining references to __DATE__ and __TIME__ from the sources which is something that has already been done in commit 26bfaeaa9687 ("Stop using __DATE__ and __TIME__ in startup string.") for the kernel datapath. Cc: Jan Engelhardt <jengelh@inai.de> Signed-off-by: Markos Chandras <mchandras@suse.de> Signed-off-by: Ben Pfaff <blp@ovn.org>
* ofproto: update mtu when port is getting removed as wellak47izatool@gmail.com2016-05-251-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When we're adding the port into ovs bridge, its mtu is updated to the minimal mtu of the included port. But when the port is getting removed, no such update is performed, which leads to bug. For example, when the port with minimal mtu is removed, bridge's mtu must adapt to new value, but it won't happen. How to reproduce the problem: $ ovs-vsctl add-br testing $ ip link add name gretap11 type gretap local 10.0.0.1 remote 10.0.0.100 $ ip link add name gretap12 type gretap local 10.0.0.1 remote 10.0.0.200 $ ip link set dev gretap12 mtu 1600 $ ovs-vsctl add-port testing gretap11 $ ovs-vsctl add-port testing gretap12 $ ip a sh testing 16: testing: <BROADCAST,MULTICAST> mtu 1462 qdisc noop state DOWN group default qlen 1 link/ether 7a:42:95:00:96:40 brd ff:ff:ff:ff:ff:ff $ ovs-vsctl del-port gretap11 $ ip a sh testing 16: testing: <BROADCAST,MULTICAST> mtu 1462 qdisc noop state DOWN group default qlen 1 link/ether 7a:42:95:00:96:40 brd ff:ff:ff:ff:ff:ff $## as we can see here, 'testing' bridge mtu is stuck, while it must adapt to new '1600' value, $## cause there is only one port 'gretap12' left, and it's mtu is '1600': $ ip a sh gretap12 19: gretap12@NONE: <BROADCAST,MULTICAST> mtu 1600 qdisc noop master ovs-system state DOWN group default qlen 1000 link/ether b2:c6:1d:9f:be:0d brd ff:ff:ff:ff:ff:ff My commit fixes this problem - mtu update is performed on port removal as well. Signed-off-by: wisd0me <ak47izatool@gmail.com> Signed-off-by: Daniele Di Proietto <diproiettod@vmware.com>
* stp: Initialize mutex whenever we register unixctl command.Ben Pfaff2016-05-201-0/+1
| | | | | | | | | | | | The stp/tcn command, which locks the mutex, was being registered without initializing the mutex, so calling stp/tcn before STP was enabled on the switch caused a crash. This commit fixes the bug by initializing the mutex at the same time we register the stp/tcn command. Reported-by: Ding Zhi <zhi.ding@6wind.com> Reported-at: http://openvswitch.org/pipermail/dev/2016-May/071381.html Signed-off-by: Ben Pfaff <blp@ovn.org> Tested-by: Quentin Monnet <quentin.monnet@6wind.com>
* ovs-vtep: Support running multiple ovs-vtep processesnickcooper-zhangtonghao2016-05-181-0/+1
| | | | | | | | | | Include ovs-vtep physical switch name as part of logical switch name to support running multiple ovs-vtep processes sharing the same ovsdb and vswitchd. Signed-off-by: nickcooper-zhangtonghao <nickcooper-zhangtonghao@opencloud.tech> Tested-by: Darrell Ball <dlu998@gmail.com> Acked-by: Justin Pettit <jpettit@ovn.org> Signed-off-by: Ben Pfaff <blp@ovn.org>
* mcast-snooping: Trigger revalidation when adding a new multicast group.Ben Pfaff2016-05-161-0/+1
| | | | | | | | | | | Otherwise it takes a long time for flows to be updated when a new group entry is added. Reported-by: "O'Reilly, Darragh" <darragh.oreilly@hpe.com> Reported-at: http://openvswitch.org/pipermail/discuss/2016-May/021224.html Signed-off-by: Ben Pfaff <blp@ovn.org> Tested-by: "O'Reilly, Darragh" <darragh.oreilly@hpe.com> Tested-at: http://openvswitch.org/pipermail/discuss/2016-May/021244.html
* ovn-sbctl: Display correct ovnsb sock location in help message.Hui Kang2016-05-061-0/+1
| | | | | Signed-off-by: Hui Kang <kangh@us.ibm.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* ovn-northd: Add support for static_routes.Steve Ruan2016-05-041-0/+1
| | | | | | | | | | | | | | | | | | Logical patch ports are used to connect logical routers together. Static routes are used to select between different logical router ports when exiting a logical router. Reported-by: Na Zhu <nazhu@cn.ibm.com> Reported-by: Dustin Lundquist <dlundquist@linux.vnet.ibm.com> Reported-at: https://bugs.launchpad.net/networking-ovn/+bug/1545140 https://bugs.launchpad.net/networking-ovn/+bug/1539347 Signed-off-by: Steve Ruan <ruansx@cn.ibm.com> [guru@ovn.org provided the unit test.] Co-authored-by: Gurucharan Shetty <guru@ovn.org> Signed-off-by: Gurucharan Shetty <guru@ovn.org>
* ovn-controller-vtep: Support BUM traffic for the VTEP Schema.Darrell Ball2016-04-111-0/+1
| | | | | | | | | | | | | | | | This patch implements BUM support in the VTEP schema. This relates to BUM traffic flowing from a gateway towards HVs. This code would be relevant to HW gateways and the ovs-vtep simulator. In order to do this, the mcast macs remote table in the VTEP schema is populated based on the OVN SB port binding. For each logical switch, the SB port bindings are queried to find all the physical locators to send BUM traffic to and the VTEP DB is updated. Some test packets were enabled in the HW gateway test case to exercise the new code. Signed-off-by: Darrell Ball <dlu998@gmail.com> Signed-off-by: Justin Pettit <jpettit@ovn.org>
* AUTHORS: Add Antonio Fischetti.Ben Pfaff2016-04-221-0/+1
| | | | Signed-off-by: Ben Pfaff <blp@ovn.org>
* AUTHORS: Add JunoZhu <zhunatuzi@gmail.com>.Ben Pfaff2016-04-221-0/+1
| | | | Signed-off-by: Ben Pfaff <blp@ovn.org>
* ovn: Fix link in tutorialJamie Lennox2016-04-211-0/+1
| | | | | | | | Correct the link to the ovn-northd man page in the OVN tutorial. Signed-off-by: Jamie Lennox <jamielennox@gmail.com> [russell@ovn.org updated AUTHORS file] Signed-off-by: Russell Bryant <russell@ovn.org>
* acinclude: Autodetect DPDK location when configuring OVSBhanuprakash Bodireddy2016-04-151-0/+1
| | | | | | | | | | | | | | | When using DPDK datapath, the OVS configure script requires the DPDK build directory passed on --with-dpdk. This can be avoided if DPDK library, headers are in standard compiler search paths. This patch fixes the problem by searching for DPDK libraries in standard locations and configure OVS sources for dpdk datapath. If the install location is manually specified in "--with-dpdk" autodiscovery shall be skipped. Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodireddy@intel.com> Signed-off-by: Daniele Di Proietto <diproiettod@vmware.com>
* AUTHORS: Add Flavio Fernandes.Russell Bryant2016-04-151-0/+1
| | | | | | Flavio authored commit b3ecab7e5b18756524852eeaea547e040242b7f6. Signed-off-by: Russell Bryant <russell@ovn.org>
* ovsdb: Force columns that contain weak references to be immutable.Ben Pfaff2016-04-111-0/+1
| | | | | | | | | | An immutable weak reference is a hole in the constraint system: if referenced rows are deleted, then the weak reference needs to change. Therefore, force columsn that contain weak references to be mutable. Reported-by: "Elluru, Krishna Mohan" <elluru.kri.mohan@hpe.com> Signed-off-by: Ben Pfaff <blp@ovn.org> Acked-by: Ryan Moats <rmoats@us.ibm.com>
* AUTHORS: Add Ben Warren.Ben Pfaff2016-03-301-0/+1
| | | | Signed-off-by: Ben Pfaff <blp@ovn.org>
* AUTHORS: Add Bhargava Shastry and Kashyap Thimmaraju.Ben Pfaff2016-03-291-0/+2
| | | | | | | | | | Bhargava and Kashyap reported vulnerability CVE-2016-2074, which was present only on the branches for 2.3 and 2.4 and thus did not require any commits on master. They still deserve credit as bug reporters, so this commit provides that. Signed-off-by: Ben Pfaff <blp@ovn.org> Acked-by: Ryan Moats <rmoats@us.ibm.com>
* Separating OVN NB and SB database processesRYAN D. MOATS2016-03-231-0/+1
| | | | | | | | | | | | OVN NB & SB DB's should be run in separate ovsdb-server processes and should run with ovn-ctl start_northd / stop_northd. This patch includes changes to unit tests, tutorial and debian scripts to remain self-consistent. Signed-off-by: RYAN D. MOATS <rmoats@us.ibm.com> Signed-off-by: Michael Arnaldi <arnaldimichael@gmail.com> Co-authored-by: Michael Arnaldi <arnaldimichael@gmail.com> Signed-off-by: Russell Bryant <russell@ovn.org>
* FAQ: Document that new fields need to be added to nx_put_raw() also.Ben Pfaff2016-03-221-0/+1
| | | | | | Reported-by: Enas Ahmad <enas.ahmad@kaust.edu.sa> Signed-off-by: Ben Pfaff <blp@ovn.org> Acked-by: Justin Pettit <jpettit@ovn.org>
* bridge: Fix qos_unixctl_show bug.Ian Stokes2016-03-221-1/+1
| | | | | | | | | | | | | | | netdev_get_qos returns a value to indicate if an error has occurred while attempting to query the QoS configuration of an interface. If an error does occur the pointer argument passed to it will be set to null before returning. Currently the vswitch will segfault if this occurs as qos_unixctl_show will attempt to access the pointer directly after it calls netdev_get_qos. Avoid this by adding a check for the return value and flagging an appropriate error message to appctl. Signed-off-by: Ian Stokes <ian.stokes@intel.com> [blp@ovn.org changed details of error report] Signed-off-by: Ben Pfaff <blp@ovn.org>
* ovs-ofctl: Add option for color output to dump-flows command.Quentin Monnet2016-03-181-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add an option to ovs-ofctl utility so as to obtain colorized output in tty, for easier reading. Currently, only the dump-flows command supports colors. A new `--color` option has been added to ovs-ofctl so as to indicate whether color markers should be used or not. It can be set to `always` (force colors), `never` (no colors) or `auto` (use colors only if output is a tty). If provided without any value, it is the same as `auto`. If the option is not provided at all, colors are disabled by default. Examples: This first call will output colorized flows: ovs-ofctl dump-flows br0 --color=always These two calls will produce colorized output on a tty, but they will not use color markers if the output is redirected to a file or piped into another command: ovs-ofctl dump-flows br0 --color=auto ovs-ofctl dump-flows br0 --color These two calls will not use color markers: ovs-ofctl dump-flows br0 --color=never ovs-ofctl dump-flows br0 The result of this option is stored into a variable which is to be forwarded (in next commits) as a function argument until it reaches the functions that print the elements of the flows. Signed-off-by: Quentin Monnet <quentin.monnet@6wind.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* vtep: Introduce other_config column in some vtep schema tables.Saurabh Shrivastava2016-03-181-1/+1
| | | | | | | | Having an other_config column is a simple way to pass more information than the schema allows. Signed-off-by: Saurabh Shrivastava <saurabh.shrivastava@nuagenetworks.net> Signed-off-by: Ben Pfaff <blp@ovn.org>
* ovs-vtep: Delete flows with untagged vlan carefully.Gurucharan Shetty2016-03-171-0/+1
| | | | | | | | | | | | A (physical port + vlan) or (physical port + no tag) can be bound to a logical switch. When one unbinds (physical port + no tag) from a logical switch, the emulator inadvertantly deletes flows for (physical port + vlan) too. This commit fixes it. VMware-BZ: #1609938 Reported-by: Mike Qing <mqing@vmware.com> Signed-off-by: Gurucharan Shetty <guru@ovn.org> Acked-by: Ryan Moats <rmoats@us.ibm.com>
* INSTALL.md: Suggest jemalloc memory allocator.Rodriguez Betancourt, Esteban2016-03-161-0/+1
| | | | | | | | | | | Change installing documentation to suggest to use jemalloc memory allocator. This memory allocator showed great performance gains when used at ovsdb-server and other components. Signed-off-by: Esteban Rodriguez Betancourt <estebarb@hpe.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* netdev-dpdk: fix mbuf leaksYuanhan Liu2016-03-091-0/+1
| | | | | | | | | | | | mbufs could be chained (by the "next" field of rte_mbuf struct), when an mbuf is not big enough to hold a big packet, say when TSO is enabled. rte_pktmbuf_free_seg() frees the head mbuf only, leading mbuf leaks. This patch fix it by invoking the right API rte_pktmbuf_free(), to free all mbufs in the chain. Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com> Signed-off-by: Daniele Di Proietto <diproiettod@vmware.com>
* ovsdb-server: Fix a reference count leak bugandy zhou2016-03-081-0/+1
| | | | | | | | | | | | | | | | | | | | | When destroying an ovsdb_jsonrpc_monitor, the jsonrpc monitor still holds a reference count to the monitors 'changes' indexed with 'unflushed' transaction id. The bug is that the reference count was not decremented as it should in the code path. The bug caused 'changes' that have been flushed to all jsonrpc clients to linger around unnecessarily, occupying increasingly large amount of memory. See "Reported-at" URL for more details. This bug is tricky to find since the memory is not leaked; they will eventually be freed when monitors are destroyed. Reported-by: Lei Huang <huang.f.lei@gmail.com> Reported-at: http://openvswitch.org/pipermail/dev/2016-March/067274.html Signed-off-by: Andy Zhou <azhou@ovn.org> Tested-by: Han Zhou <zhouhan@gmail.com> Acked-by: Han Zhou <zhouhan@gmail.com> Acked-by: Liran Schour <lirans@il.ibm.com>
View Lorry Controller Status