summaryrefslogtreecommitdiff
path: root/Documentation
Commit message (Collapse)AuthorAgeFilesLines
* netdev-dpdk: Post-copy Live Migration support for vhost-user-client.Liliia Butorina2019-05-241-1/+52
| | | | | | | | | | | | | | | | | | | | | | | Post-copy Live Migration for vHost supported since DPDK 18.11 and QEMU 2.12. New global config option 'vhost-postcopy-support' added to control this feature. Ex.: ovs-vsctl set Open_vSwitch . other_config:vhost-postcopy-support=true Changing this value requires restarting the daemon. It's safe to enable this knob even if QEMU doesn't support post-copy LM. Feature marked as experimental and disabled by default because it may cause PMD thread hang on destination host on page fault for the time of page downloading from the source. Feature is not compatible with 'mlockall' and 'dequeue zero-copy'. Support added only for vhost-user-client. Signed-off-by: Liliia Butorina <l.butorina@partner.samsung.com> Co-authored-by: Ilya Maximets <i.maximets@samsung.com> Signed-off-by: Ilya Maximets <i.maximets@samsung.com> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
* sflow, ovn: Typofix: trafic -> trafficKlemens Nanni2019-05-231-3/+3
| | | | | | | | Spotted http://docs.openvswitch.org/en/latest/howto/sflow/, grepping the tree found another instance in ovn. Signed-off-by: Klemens Nanni <klemens@posteo.de> Signed-off-by: Ben Pfaff <blp@ovn.org>
* doc: Fix cropped what-is-ovs page.Ilya Maximets2019-05-171-4/+4
| | | | | | | | | | | | | | | | Despite of comments in both files no-one ever adjusted start/end-line in 'what-is-ovs' document. As a result, current document contains truncated "tools" section. Let's replace start/end-line with start-after/end-before which requires less attention. Additionally, 'make docs-check' will fail if specified lines will not be found, i.e it'll be harder to mess up the docs again. "Fixes" tag points to commit that broke the lines first. Fixes: 602e24ee189b ("doc: Remove experimental warning for DPDK.") Signed-off-by: Ilya Maximets <i.maximets@samsung.com> Acked-by: Stephen Finucane <stephen@that.guru>
* dpdk: Use DPDK 18.11.1 release.Ian Stokes2019-05-093-9/+9
| | | | | | | | | | Modify travis linux build script to use the latest DPDK stable release 18.11.1. Update docs for latest DPDK stable releases. Signed-off-by: Ian Stokes <ian.stokes@intel.com> Acked-by: Kevin Traynor <ktraynor@redhat.com> Acked-by: Aaron Conole <aconole@redhat.com>
* ovsdb-server.7: Describe message ordering between "update" and "transact".Ben Pfaff2019-04-251-1/+10
| | | | | | | This comes up sometime and it's best to document it. Acked-by: Han Zhou <hzhou8@ebay.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* Documentation: Update documentation for OpenFlow support.Ben Pfaff2019-04-241-25/+1
| | | | | | | | The commits that implemented these features forgot to update the documentation. Acked-by: Yi-Hung Wei <yihung.wei@gmail.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* faq: Add information about git-pw.Kevin Traynor2019-04-161-0/+19
| | | | | | | | git-pw is similar to pwclient but it can apply series directly. Reviewed-by: David Marchand <david.marchand@redhat.com> Signed-off-by: Kevin Traynor <ktraynor@redhat.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* faq: Explain why select groups don't sort out packets evenly.Ben Pfaff2019-04-151-0/+16
| | | | | | | This keeps coming up. Acked-by: Alin Gabriel Serdean <aserdean@ovn.org> Signed-off-by: Ben Pfaff <blp@ovn.org>
* Docs: fix conntrack flow ct_state inputLIU Yulong2019-04-121-6/+6
| | | | | | | | | | | | | | | | | In the following envrionment: ovs-vsctl (Open vSwitch) 2.11.0 DB Schema 7.16.1 we meet the following error during the tutorials conntrack test: "ovs-ofctl: field +est missing value" "ovs-ofctl: field +trk missing value" ovs-vsctl 2.9.0 has the same issue. This patch gives the tutorials with right conntrack input. Signed-off-by: LIU Yulong <i@liuyulong.me>
* faq: Add Q&A for applying patches from email.Ben Pfaff2019-03-261-0/+49
| | | | | Acked-by: Aaron Conole <aconole@redhat.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* faq: Update features supported on Hyper-VAnand Kumar2019-03-131-3/+3
| | | | | | | | | These features were added a while back, so updating the documentation. Signed-off-by: Anand Kumar <kumaranand@vmware.com> Acked-by: Sairam Venugopal <vsairam@vmware.com> Signed-off-by: Alin Gabriel Serdean <aserdean@ovn.org>
* ovsdb-monitor: Support monitor_cond_since.Han Zhou2019-02-281-3/+75
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Support the new monitor method monitor_cond_since so that a client can request monitoring start from a specific point instead of always from beginning. This will reduce the cost at scenarios when server is restarted/failed-over but client still has all existing data. In these scenarios only new changes (and in most cases no change) needed to be transfered to client. When ovsdb-server restarted, history transactions are read from disk file; when ovsdb-server failed over, history transactions exists already in the memory of the new server. There are situations that the requested transaction may not be found. For example, a transaction that is too old and has been discarded from the maintained history list in memory, or the transactions on disk has been compacted during ovsdb compaction. In those situations the server fall backs to transfer all data start from begining. For more details of the protocol change, see Documentation/ref/ovsdb-server.7.rst. This change includes both server side and ovsdb-client side changes with the new protocol. IDLs using this capability will be added in future patches. Now the feature takes effect only for cluster mode of ovsdb-server, because cluster mode is the only mode that supports unique transcation uuid today. For other modes, the monitor_cond_since always fall back to transfer all data with found = false. Support for those modes can be added in the future. Signed-off-by: Han Zhou <hzhou8@ebay.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* faq: Return GRE-IPv6 tunneling support.Ilya Maximets2019-02-221-1/+1
| | | | | | | | | Accidentially changed while updating conntrack support. CC: Darrell Ball <dlu998@gmail.com> Fixes: 4ea96698f667 ("Userspace datapath: Add fragmentation handling.") Signed-off-by: Ilya Maximets <i.maximets@samsung.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* doc: Add "Representors" topic documentOphir Munk2019-02-181-0/+139
| | | | | | | This details how to configure representors ports. Signed-off-by: Ophir Munk <ophirmu@mellanox.com> Signed-off-by: Ian Stokes <ian.stokes@intel.com>
* Userspace datapath: Add fragmentation handling.Darrell Ball2019-02-141-25/+26
| | | | | | | | | | | | | | | | Fragmentation handling is added for supporting conntrack. Both v4 and v6 are supported. After discussion with several people, I decided to not store configuration state in the database to be more consistent with the kernel in future, similarity with other conntrack configuration which will not be in the database as well and overall simplicity. Accordingly, fragmentation handling is enabled by default. This patch enables fragmentation tests for the userspace datapath. Signed-off-by: Darrell Ball <dlu998@gmail.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* faq: Update OVS/DPDK version table for OVS 2.11.Kevin Traynor2019-02-131-0/+1
| | | | | | | Indicate that OVS 2.11 uses DPDK 18.11. Signed-off-by: Kevin Traynor <ktraynor@redhat.com> Signed-off-by: Ian Stokes <ian.stokes@intel.com>
* Remove support for OpenFlow 1.6 (draft).Ben Pfaff2019-02-051-13/+13
| | | | | | | | | ONF abandoned the OpenFlow specification, so that OpenFlow 1.6 will never be completed. It did not contain much in the way of useful features, so remove what support Open vSwitch already had. Signed-off-by: Ben Pfaff <blp@ovn.org> Acked-by: Justin Pettit <jpettit@ovn.org>
* datapath: Add support for kernel 4.18.xYifeng Sun2019-02-041-0/+1
| | | | | | | | | | | | | | No code changing is necessary to support 4.18.x. Only one kernel test failed and it is in the process of being fixed. Updated .travis.yml to include 4.18.x and also use latest 4.17 version. Updated test files to test 4.18 kernel. Tested-by: Greg Rose <gvrose8192@gmail.com> Reviewed-by: Greg Rose <gvrose8192@gmail.com> Signed-off-by: Yifeng Sun <pkusunyifeng@gmail.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* dpif-netdev: Per-port configurable EMC.Ilya Maximets2019-01-181-0/+13
| | | | | | | | | | | | | | | | | | | | | | | | Conditional EMC insert helps a lot in scenarios with high numbers of parallel flows, but in current implementation this option affects all the threads and ports at once. There are scenarios where we have different number of flows on different ports. For example, if one of the VMs encapsulates traffic using additional headers, it will receive large number of flows but only few flows will come out of this VM. In this scenario it's much faster to use EMC instead of classifier for traffic from the VM, but it's better to disable EMC for the traffic which flows to VM. To handle above issue introduced 'emc-enable' configurable to enable/disable EMC on a per-port basis. Ex.: ovs-vsctl set interface dpdk0 other_config:emc-enable=false EMC probability kept as is and it works for all the ports with 'emc-enable=true'. Signed-off-by: Ilya Maximets <i.maximets@samsung.com> Acked-by: Kevin Traynor <ktraynor@redhat.com> Signed-off-by: Ian Stokes <ian.stokes@intel.com>
* rhel: Split OpenvSwitch and OVN packagesNuman Siddique2019-01-161-4/+13
| | | | | | | | | | | | | | | | | | | | | | Up until now, OVN rpms were generated as sub packages of OpenvSwitch. This patch now splits it and makes OVN rpms independent. A new spec file - ovn-fedora.spec.in is added for this. The openvswitch-fedora.spec.in has been modified to create only OpenvSwitch packages. Since we are not splitting the OVN code, the spec files run the same build procedure. Only the required binaries/files are copied into the rpms. The new package names will be ovn, ovn-common, ovn-central, ovn-host, ovn-vtep and ovn-docker. Acked-by: Flavio Leitner <fbl@sysclose.org> Signed-off-by: Numan Siddique <nusiddiq@redhat.com> Acked-by: Timothy Redaelli <tredaelli@redhat.com> Tested-By: Timothy Redaelli <tredaelli@redhat.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* Adding support for PMD auto load balancingNitin Katiyar2019-01-161-0/+63
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Port rx queues that have not been statically assigned to PMDs are currently assigned based on periodically sampled load measurements. The assignment is performed at specific instances – port addition, port deletion, upon reassignment request via CLI etc. Due to change in traffic pattern over time it can cause uneven load among the PMDs and thus resulting in lower overall throughout. This patch enables the support of auto load balancing of PMDs based on measured load of RX queues. Each PMD measures the processing load for each of its associated queues every 10 seconds. If the aggregated PMD load reaches 95% for 6 consecutive intervals then PMD considers itself to be overloaded. If any PMD is overloaded, a dry-run of the PMD assignment algorithm is performed by OVS main thread. The dry-run does NOT change the existing queue to PMD assignments. If the resultant mapping of dry-run indicates an improved distribution of the load then the actual reassignment will be performed. The automatic rebalancing will be disabled by default and has to be enabled via configuration option. The interval (in minutes) between two consecutive rebalancing can also be configured via CLI, default is 1 min. Following example commands can be used to set the auto-lb params: ovs-vsctl set open_vswitch . other_config:pmd-auto-lb="true" ovs-vsctl set open_vswitch . other_config:pmd-auto-lb-rebalance-intvl="5" Co-authored-by: Rohith Basavaraja <rohith.basavaraja@gmail.com> Co-authored-by: Venkatesan Pradeep <venkatesan.pradeep@ericsson.com> Signed-off-by: Rohith Basavaraja <rohith.basavaraja@gmail.com> Signed-off-by: Venkatesan Pradeep <venkatesan.pradeep@ericsson.com> Signed-off-by: Nitin Katiyar <nitin.katiyar@ericsson.com> Acked-by: Kevin Traynor <ktraynor@redhat.com> Tested-by: Kevin Traynor <ktraynor@redhat.com> Signed-off-by: Ian Stokes <ian.stokes@intel.com>
* Correct documentation for getting DB's cidTerry Wilson2019-01-151-1/+1
| | | | | | Acked-by: Mark Michelson <mmichels@redhat.com> Signed-off-by: Terry Wilson <twilson@redhat.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* ovs-actions: New document describing OVS actions in detail.Ben Pfaff2019-01-103-39/+5
| | | | | Acked-by: Mark Michelson <mmichels@redhat.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* docs: Fix table title for VM MQ config in dpdk howto.Cian Ferriter2019-01-101-1/+1
| | | | | | | | | | Found this when searching "BIOS Settings" for use with DPDK. CC: Stephen Finucane <stephen@that.guru> Fixes: c50938a24031 ("doc: Convert INSTALL.DPDK-ADVANCED to rST") Signed-off-by: Cian Ferriter <cian.ferriter@intel.com> Acked-by: Stephen Finucane <stephen@that.guru> Signed-off-by: Ian Stokes <ian.stokes@intel.com>
* faq: unload kernel module when non-zero refcnt.William Tu2019-01-091-0/+14
| | | | | | | | | Describe the issue about reference count and how to drop it and unload the kernel module. Signed-off-by: William Tu <u9012063@gmail.com> Cc: Greg Rose <gvrose8192@gmail.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* doc: Add missing ':doc:' roleStephen Finucane2018-12-281-1/+1
| | | | | | | This was rendering in italics instead of cross-referencing as intended. Signed-off-by: Stephen Finucane <stephen@that.guru> Signed-off-by: Ben Pfaff <blp@ovn.org>
* ovn-sb.ovsschema: Avoid duplicated IPs in Encap table.Han Zhou2018-12-271-0/+28
| | | | | | | | | | | | | | | | | | | | When adding a new chassis, if there is an old chassis with same IP existed in Encap table, it is allowed to be added today. However, allowing it to be added results in problems: 1. The new chassis cannot work because none of the other chassises are able to create tunnel to it, because of the IP confliction with already existed tunnel to the old chassis. 2. All the other chassises will continuously retry creating the tunnel and complaining about the error. So, instead of hiding the problem, it is better to expose it while trying to add the second chassis with duplicated IP. This patch ensures it from the ovsdb schema. Signed-off-by: Han Zhou <hzhou8@ebay.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* dpdk: Update to use DPDK 18.11.Ophir Munk2018-12-133-10/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit adds support for DPDK v18.11, it includes the following changes. 1. Enable compilation and linkage with dpdk 18.11.0 The following dpdk commits which were introduced after dpdk 17.11.x require OVS updates to accommodate to the dpdk changes. - ce17edde ("ethdev: introduce Rx queue offloads API") - ab3ce1e0 ("ethdev: remove old offload API") - c06ddf96 ("meter: add configuration profile") - e58638c3 ("ethdev: fix TPID handling in flow API") - cd8c7c7c ("ethdev: replace bus specific struct with generic dev") - ac8d22de ("ethdev: flatten RSS configuration in flow API") 2. Limit configured rss hash functions to only those supported by the eth device. 3. Set default RSS key in struct action_rss_data, required by OVS commit- e8a2b5bf ("netdev-dpdk: implement flow offload with rte flow") when configured with "other_config:hw-offload=true". 4. DEV_RX_OFFLOAD_CRC_STRIP has been removed from DPDK 18.11. DEV_RX_OFFLOAD_KEEP_CRC can now be used to keep the CRC. Use the correct flag and check it is supported. 5. rte_eth_dev_attach/detach have been removed from DPDK 18.11. Replace them with rte_dev_probe/remove. 6. Update docs and travis to use DPDK18.11. This commit squashes the following commits present on the dpdk-latest branch: 7f021f902bb3 ("netdev-dpdk: Upgrade to dpdk v18.08") 270d9216f1ed ("netdev-dpdk: Set scatter based on capabilities") bef2cdc8f412 ("netdev-dpdk: Fix returning the field of malloced struct.") 73c1a65167fc ("redhat: change variable used for non-root user support") eb485f60ce44 ("dpdk: Update to use DPDK 18.11.") For credit all authors of the original commits above have been added as co-authors for this commmit. From: Ophir Munk <ophirmu@mellanox.com> Signed-off-by: Ophir Munk <ophirmu@mellanox.com> Signed-off-by: Kevin Traynor <ktraynor@redhat.com> Co-authored-by: Kevin Traynor <ktraynor@redhat.com> Signed-off-by: Ilya Maximets <i.maximets@samsung.com> Co-authored-by: Ilya Maximets <i.maximets@samsung.com> Signed-off-by: Timothy Redaelli <tredaelli@redhat.com> Co-authored-by: Timothy Redaelli <tredaelli@redhat.com> Signed-off-by: Ian Stokes <ian.stokes@intel.com>
* Documentation: Fixing some minor spelling mistakes and consistent usage of ↵Ashish Varma2018-12-031-9/+9
| | | | | | | certain keywords. Signed-off-by: Ashish Varma <ashishvarma.ovs@gmail.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* tests: Add support for Address Sanitizer.Ben Pfaff2018-12-031-0/+7
| | | | | | | | This makes the tests all pass cleanly when Address Sanitizer is enabled. Acked-by: Mark Michelson <mmichels@redhat.com> Acked-by: Justin Pettit <jpettit@ovn.org> Signed-off-by: Ben Pfaff <blp@ovn.org>
* netdev-dpdk: Add mbuf HEADROOM after alignment.Tiago Lam2018-11-281-14/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Commit dfaf00e started using the result of dpdk_buf_size() to calculate the available size on each mbuf, as opposed to using the previous MBUF_SIZE macro. However, this was calculating the mbuf size by adding up the MTU with RTE_PKTMBUF_HEADROOM and only then aligning to NETDEV_DPDK_MBUF_ALIGN. Instead, the accounting for the RTE_PKTMBUF_HEADROOM should only happen after alignment, as per below. Before alignment: ROUNDUP(MTU(1500) + RTE_PKTMBUF_HEADROOM(128), 1024) = 2048 After aligment: ROUNDUP(MTU(1500), 1024) + 128 = 2176 This might seem insignificant, however, it might have performance implications in DPDK, where each mbuf is expected to have 2k + RTE_PKTMBUF_HEADROOM of available space. This is because not only some NICs have course grained alignments of 1k, they will also take RTE_PKTMBUF_HEADROOM bytes from the overall available space in an mbuf when setting up their Rx requirements. Thus, only the "After alignment" case above would guarantee a 2k of available room, as the "Before alignment" would report only 1920B. Some extra information can be found at: https://mails.dpdk.org/archives/dev/2018-November/119219.html Note: This has been found by Ian Stokes while going through some af_packet checks. Reported-by: Ian Stokes <ian.stokes@intel.com> Fixes: dfaf00e ("netdev-dpdk: fix mbuf sizing") Signed-off-by: Tiago Lam <tiago.lam@intel.com> Signed-off-by: Ian Stokes <ian.stokes@intel.com>
* coding-style: Few visual enhancements for the document.Ilya Maximets2018-11-161-50/+50
| | | | | | | | Some keywords and numbers highlighted. Added few spaces to the examples. Signed-off-by: Ilya Maximets <i.maximets@samsung.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* faq: Fix typo in VLAN 9 configuration examples.chrone2018-11-151-2/+2
| | | | | | | | Fixed typo on the VLAN 9 configuration example where the device name should be vlan9 instead of vlan0. Signed-off-by: Charles Alva <charlesalva@gmail.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* coding-style: Remove redundant symbols from the examples.Ilya Maximets2018-11-151-2/+2
| | | | | | | | | | | Some backslashes was added while converting from .md to .rst. These symbols are printable in both pdf and html docs and should be removed. CC: Stephen Finucane <stephen@that.guru> Fixes: d124a408a4bc ("doc: Convert CodingStyle to rST") Signed-off-by: Ilya Maximets <i.maximets@samsung.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* Documentation: OVN RBAC and IPsec tutorialQiuyu Xiao2018-11-095-1/+287
| | | | | | | | This patch adds step-by-step guide for configuring OVN Role-Based Access Control and IPsec. Signed-off-by: Qiuyu Xiao <qiuyu.xiao.qyx@gmail.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* Documentation: IPsec tunnel tutorial and documentation.Qiuyu Xiao2018-11-096-1/+547
| | | | | | | | | | | | | tutorials/index.rst gives a step-by-setp guide to set up OVS IPsec tunnel. tutorials/ipsec.rst gives detailed explanation on the IPsec tunnel configuration methods and forwarding modes. Signed-off-by: Qiuyu Xiao <qiuyu.xiao.qyx@gmail.com> Signed-off-by: Ansis Atteka <aatteka@ovn.org> Co-authored-by: Ansis Atteka <aatteka@ovn.org> Signed-off-by: Ben Pfaff <blp@ovn.org>
* faq: Update information on meters.Ben Pfaff2018-11-091-3/+3
| | | | | Acked-by: Mark Michelson <mmichels@redhat.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* dns-resolve: Improve on handling of system DNS nameserverYifeng Sun2018-11-091-0/+2
| | | | | | | | | | | | | This patch enables OVS on windows to read system nameserver configuration. In addition, a new environment variable OVS_RESOLV_CONF is introduced. If set, it can be used as DNS server configuration file. This variable is supposed to be used for sandboxing other things. It is documented accordingly. Suggested-by: Ben Pfaff <blp@ovn.org> Suggested-by: Mark Michelson <mmichels@redhat.com> Signed-off-by: Yifeng Sun <pkusunyifeng@gmail.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* faq: update the ERSPAN/GRE tunnel feature.William Tu2018-11-091-1/+4
| | | | | | | | Add ERSPAN/GRE tunnel to datapath feature comparison table. Reviewed-by: Greg Rose <gvrose8192@gmail.com> Signed-off-by: William Tu <u9012063@gmail.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* faq: Specify QoS support is dependent on interface type.Darrell Ball2018-11-091-0/+4
| | | | | | | QoS support depends on interface type; document it. Signed-off-by: Darrell Ball <dlu998@gmail.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* Merge branch 'dpdk_merge' of https://github.com/istokes/ovs into HEADBen Pfaff2018-11-023-21/+14
|\
| * netdev-dpdk: fix mbuf sizingMark Kavanagh2018-11-021-14/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There are numerous factors that must be considered when calculating the size of an mbuf: - the data portion of the mbuf must be sized in accordance With Rx buffer alignment (typically 1024B). So, for example, in order to successfully receive and capture a 1500B packet, mbufs with a data portion of size 2048B must be used. - in OvS, the elements that comprise an mbuf are: * the dp packet, which includes a struct rte mbuf (704B) * RTE_PKTMBUF_HEADROOM (128B) * packet data (aligned to 1k, as previously described) * RTE_PKTMBUF_TAILROOM (typically 0) Some PMDs require that the total mbuf size (i.e. the total sum of all of the above-listed components' lengths) is cache-aligned. To satisfy this requirement, it may be necessary to round up the total mbuf size with respect to cacheline size. In doing so, it's possible that the dp_packet's data portion is inadvertently increased in size, such that it no longer adheres to Rx buffer alignment. Consequently, the following property of the mbuf no longer holds true: mbuf.data_len == mbuf.buf_len - mbuf.data_off This creates a problem in the case of multi-segment mbufs, where that assumption is assumed to be true for all but the final segment in an mbuf chain. Resolve this issue by adjusting the size of the mbuf's private data portion, as opposed to the packet data portion when aligning mbuf size to cachelines. Co-authored-by: Tiago Lam <tiago.lam@intel.com> Fixes: 4be4d22 ("netdev-dpdk: clean up mbuf initialization") Fixes: 31b88c9 ("netdev-dpdk: round up mbuf_size to cache_line_size") CC: Santosh Shukla <santosh.shukla@caviumnetworks.com> Signed-off-by: Mark Kavanagh <mark.b.kavanagh@intel.com> Signed-off-by: Tiago Lam <tiago.lam@intel.com> Acked-by: Santosh Shukla <santosh.shukla@caviumnetworks.com> Acked-by: Eelco Chaudron <echaudro@redhat.com> Signed-off-by: Ian Stokes <ian.stokes@intel.com>
| * Docs: Remove HWOL DPDK limitation.Ian Stokes2018-11-021-1/+0
| | | | | | | | | | | | | | | | | | Partial offload support was added to OVS DPDK in OVS 2.10. As such remove the limitation that OVS DPDK does not support HWOL from the DPDK install documentation. Acked-by: Flavio Leitner <fbl@sysclose.org> Signed-off-by: Ian Stokes <ian.stokes@intel.com>
| * Docs: Remove zero-copy QEMU limitation.Ian Stokes2018-11-021-6/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Remove note regarding zero-copy compatibility with QEMU >= 2.7. When zero-copy was introduced to OVS it was incompatible with QEMU >= 2.7. This issue has since been fixed in DPDK with commit 803aeecef123 ("vhost: fix dequeue zero copy with virtio1") and backported to DPDK LTS branches. Remove the reference to this issue in the zero-copy documentation. Cc: Ciara Loftus <ciara.loftus@intel.com> Acked-by: Ciara Loftus <ciara.loftus@intel.com> Signed-off-by: Ian Stokes <ian.stokes@intel.com>
* | ovsdb: Clarify that a server that leaves a cluster may never rejoin.Ben Pfaff2018-11-021-0/+3
|/ | | | | | | | This wasn't clear from the documentation. Reported-by; Paul Greenberg <greenpau@outlook.com> Reviewed-by: Yifeng Sun <pkusunyifeng@gmail.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* contributing: Signed-off-by tags should come last.Ben Pfaff2018-10-311-0/+6
| | | | | | | Acked-by: Flavio Leitner <fbl@sysclose.org> Reviewed-by: Greg Rose <gvrose8192@gmail.com> Suggested-by: Gregory Rose <gvrose8192@gmail.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* submitting-patches: Advise not to wrap tags across multiple lines.Ben Pfaff2018-10-311-0/+3
| | | | | | | | It makes parsing them more difficult. Acked-by: Flavio Leitner <fbl@sysclose.org> Reviewed-by: Greg Rose <gvrose8192@gmail.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* dpdk: Use DPDK 17.11.4 release.Ian Stokes2018-10-193-10/+10
| | | | | | | | | Modify travis linux build script to use the latest DPDK stable release 17.11.4. Update docs for latest DPDK stable releases. Signed-off-by: Ian Stokes <ian.stokes@intel.com> Acked-by: Kevin Traynor <ktraynor@redhat.com>
* system-dpdk: Skip all tests if there are no hugepagesBala Sankaran2018-10-121-0/+6
| | | | | | | | | | | A failure is quite harsh in this scenario. It's better to simply skip all the tests and let the user look at the logs to understand the missing hugepages. Signed-off-by: Bala Sankaran <bsankara@redhat.com> Co-authored-by: Aaron Conole <aconole@redhat.com> Signed-off-by: Aaron Conole <aconole@redhat.com> Signed-off-by: Ian Stokes <ian.stokes@intel.com>
* system-dpdk: Update test suite for non-phy testingAaron Conole2018-10-121-3/+5
| | | | | | | | | | | | This allows a system that doesn't have a dedicated DPDK nic to execute some DPDK tests. In this fashion, tests that operate on virtual ports (such as dpdkvhostuserclient) can be executed in a wider set of environments. Signed-off-by: Aaron Conole <aconole@redhat.com> Co-authored-by: Bala Sankaran <bsankara@redhat.com> Signed-off-by: Bala Sankaran <bsankara@redhat.com> Signed-off-by: Ian Stokes <ian.stokes@intel.com>
View Lorry Controller Status