summaryrefslogtreecommitdiff
path: root/ofproto/ofproto-dpif-mirror.c
Commit message (Collapse)AuthorAgeFilesLines
* ofproto-dpif-mirror: Fix bug that flag "need_revalidate" is never reset.Huanle Han2016-02-051-2/+4
| | | | | | | | | Flag "need_revalidate" on mbridge is set to true when an ofbundle destroy. And it's never reset. It causes the backer revalidate and the mac learning flush every time 'ofproto_run' is called. Signed-off-by: Huanle Han <hanxueluo@gmail.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* ofproto-dpif-mirror: Fix insane waste of memory and time in checking VLANs.Ben Pfaff2015-07-271-6/+12
| | | | | | | | | | | When a mirror was restricted to particular VLANs, this code was allocating, copying, and freeing a 512-byte block of memory just to check the value of a single bit in the block. This fixes the problem. Found by inspection. Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Andy Zhou <azhou@nicira.com>
* lib: Move vlog.h to <openvswitch/vlog.h>Thomas Graf2014-12-151-1/+1
| | | | | | | | A new function vlog_insert_module() is introduced to avoid using list_insert() from the vlog.h header. Signed-off-by: Thomas Graf <tgraf@noironetworks.com> Acked-by: Ben Pfaff <blp@nicira.com>
* mirror: Use 'struct ref_count' for refcounting.Joe Stringer2014-03-111-17/+13
| | | | | Signed-off-by: Joe Stringer <joestringer@nicira.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
* ofproto-dpif: Get rid of mirror_mask_ffs() function.Ben Pfaff2013-12-181-2/+1
| | | | | | | | | There's no need for it because we have the equivalent (actually more convenient) function raw_ctz(), which works with any integer type. Signed-off-by: Ben Pfaff <blp@nicira.com> CC: Alin Serdean <aserdean@cloudbasesolutions.com> CC: Gurucharan Shetty <shettyg@nicira.com>
* ofproto-dpif-mirror: Fix memory leak in mbridge_unref().Ben Pfaff2013-09-041-0/+1
| | | | | | | Found by valgrind. Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Ethan Jackson <ethan@nicira.com>
* ofproto-dpif: Modularize mirror code.Ethan Jackson2013-07-071-0/+500
This code modularizes ofproto-dpif's mirror code by moving it to ofproto-dpif-mirror. Not only does this shorten ofproto-dpif and hide complexity, but its also necessary for future patches which modularize ofproto-dpif-xlate in preparation for multi-threading. Signed-off-by: Ethan Jackson <ethan@nicira.com> Acked-by: Ben Pfaff <blp@nicira.com>