summaryrefslogtreecommitdiff
path: root/tests
Commit message (Collapse)AuthorAgeFilesLines
* expr: Make expr_to_flows() include conj_id flows.Ben Pfaff2015-04-291-11/+1
| | | | | | | | | | | | | When I wrote expr_to_flows() originally, I assumed that the caller could simply add an appropriate conj_id=X flow for each of the conjunctive matches. I forgot that the conj_id=X flows also need to include prerequisites for actions, e.g. if the OpenFlow actions manipulate TCP fields, then the conj_id=X field must match on eth_type=0x800 and ip_proto=6. That's hard for the caller to generate itself, so this commit changes expr_to_matches() to generate the conj_id=X flows also. Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Justin Pettit <jpettit@nicira.com>
* expr: Support string fields in expr_to_matches().Ben Pfaff2015-04-162-33/+67
| | | | | Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Russell Bryant <rbryant@redhat.com>
* expr: New module for Boolean expressions on fields, for use in OVN.Ben Pfaff2015-04-152-0/+1429
| | | | | | | | | | | | | | Known weaknesses: * String fields can't be converted to flows yet. A subsequent commit will fix this. * Flows aren't optimal in some situations likely to be common. I don't think either of those is a reason not to commit this; this is a solid base to build on. Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Russell Bryant <rbryant@redhat.com>
* lex: New lexical analyzer module for use in OVN.Ben Pfaff2015-04-154-2/+220
| | | | | | | | | I'm determined not to let the terrible style of pseudo-parsing we have in OVS leak into OVN. Here's the first step. Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Andy Zhou <azhou@nicira.com> Acked-by: Russell Bryant <rbryant@redhat.com>
* tests: gre: fix flags endiannessFlavio Leitner2015-04-102-3/+3
| | | | | | | | | The flags field is 16 bits so use network byte order in the test case and use the proper conversion methods when parsing and dumping. Signed-off-by: Flavio Leitner <fbl@redhat.com> Signed-off-by: Jesse Gross <jesse@nicira.com>
* test-csum: endianess fixFlavio Leitner2015-04-101-2/+5
| | | | | | | | | | The math is done in network byte order so the 32 bits won't match between big and little endian, so the assert fails. Reduce to 16 bits and then compare to the converted constant. Signed-off-by: Flavio Leitner <fbl@redhat.com> Signed-off-by: Jesse Gross <jesse@nicira.com>
* testsuite: ofproto-dpif: fix test namesFlavio Leitner2015-04-091-5/+5
| | | | | | | | | Some tests were not included when running the make TESTSUITEFLAGS="-k ofproto-dpif" check because the test name was out of the expected pattern. Signed-off-by: Flavio Leitner <fbl@redhat.com> Acked-by: Joe Stringer <joestringer@nicira.com>
* testsuite: work around patch bugFlavio Leitner2015-04-081-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Due to a CVE bug, the patch was modified to not allow following symlinks out of the workdir. However, this causes a bug when there is a regular file out of the workdir which breaks the current testsuite build. Steps to reproduce: ./boot.sh mkdir _gcc && cd _gcc ../configure make [...] /bin/sh /home/fleitner/ovs/testsuite/build-aux/missing autom4te --language=autotest -I '..' -o ../tests/testsuite.tmp ../tests/testsuite.at patch -p0 ../tests/testsuite.tmp ../tests/testsuite.patch Invalid file name ../tests/testsuite.tmp -- skipping patch Makefile:5155: recipe for target '../tests/testsuite' failed make[2]: *** [../tests/testsuite] Error 1 make[2]: Leaving directory '/home/fleitner/NetworkingServices/openvswitch/repo/testsuite/_gcc' Makefile:4087: recipe for target 'all-recursive' failed make[1]: *** [all-recursive] Error 1 Since it's just a temporary file, this patch changes to use the workdir as the place to put the file. Signed-off-by: Flavio Leitner <fbl@redhat.com> Signed-off-by: Gurucharan Shetty <gshetty@nicira.com>
* tunneling: Add UDP checksum support for userspace tunnels.Jesse Gross2015-04-072-7/+8
| | | | | | | | | Kernel based OVS recently added the ability to support checksums for UDP based tunnels (Geneve and VXLAN). This adds similar support for the userspace datapath to bring feature parity. Signed-off-by: Jesse Gross <jesse@nicira.com> Acked-by: Pravin B Shelar <pshelar@nicira.com>
* packet: Add IP pseudoheader checksum calculation.Jesse Gross2015-04-072-1/+32
| | | | | | | | | As OVS adds userspace support for being the endpoint in protocols like tunnels, it will need to be able to calculate pseudoheaders as part of the checksum calculation. Signed-off-by: Jesse Gross <jesse@nicira.com> Acked-by: Pravin B Shelar <pshelar@nicira.com>
* tunneling: Add userspace tunnel support for Geneve.Jesse Gross2015-04-072-0/+17
| | | | | | | | | | | This adds basic userspace dataplane support for the Geneve tunneling protocol. The rest of userspace only has the ability to handle Geneve without options and this follows that pattern for the time being. However, when the rest of userspace is updated it should be easy to extend the dataplane as well. Signed-off-by: Jesse Gross <jesse@nicira.com> Acked-by: Pravin B Shelar <pshelar@nicira.com>
* odp-util: Shift VXLAN VNI when printing/parsing.Jesse Gross2015-04-072-3/+3
| | | | | | | | | | | Currently when printing a userspace tunnel action for VXLAN, the VNI is treated as a 32 bit field rather than 24 bit. Even if this is the representation that we use internally, we should still show the right VNI to avoid confusing people. Signed-off-by: Jesse Gross <jesse@nicira.com> Acked-by: Pritesh Kothari <pritesh.kothari@cisco.com> Acked-by: Pravin B Shelar <pshelar@nicira.com>
* tunneling: Add check for GRE protocol is Ethernet.Jesse Gross2015-04-071-0/+16
| | | | | | | | | | | On receive, the userspace GRE code doesn't check the protocol field. Since OVS only understands Ethernet packets, this adds a check that the inner protocol is Ethernet and discards other types of packets. Signed-off-by: Jesse Gross <jesse@nicira.com> Acked-by: Pritesh Kothari <pritesh.kothari@cisco.com> Acked-by: Pravin B Shelar <pshelar@nicira.com>
* lib/list: Add LIST_FOR_EACH_POP.Jarno Rajahalme2015-04-062-1/+27
| | | | | | | | Makes popping each member of the list a bit easier. Signed-off-by: Jarno Rajahalme <jrajahalme@nicira.com> Acked-by: Russell Bryant <rbryant@redhat.com> Acked-by: Ben Pfaff <blp@nicira.com>
* ovsdb-server: Correct malformed error replies to certain JSON-RPC requests.Ben Pfaff2015-03-311-1/+1
| | | | | | | | I realized that this bug existed only a few weeks ago, but it has been there since the earliest ovsdb-server code. Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Alex Wang <alexw@nicira.com>
* ovsdb-idl: Tolerate missing tables and columns.Ben Pfaff2015-03-313-1/+161
| | | | | | | | | | | | | | | | | | | | | Until now, if ovs-vsctl (or another client of the C ovsdb-idl library) was compiled against a schema that had a column or table that was not in the database actually being used (e.g. during an upgrade), and the column or table was selected for monitoring, then ovsdb-idl would fail to get any data at all because ovsdb-server would report an error due to a request about a column or a table it didn't know about. This commit fixes the problem by making ovsdb-idl retrieve the database schema from the database server and omit any tables or columns that don't exist from its monitoring request. This works OK for the kinds of upgrades that OVSDB otherwise supports gracefully because it will simply make the missing columns or tables appear empty, which clients of the ovsdb-idl library already have to tolerate. VMware-BZ: #1413562 Reported-by: Alex Wang <alexw@nicira.com> Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Alex Wang <alexw@nicira.com>
* netdev: Fix user space tunneling for set_tunnel action.Ricky Li2015-03-261-1/+14
| | | | | | | | | | | | | | | e.g. Set tunnel id for encapsulated VxLAN packet (out_key=flow): ovs-vsctl add-port int-br vxlan0 -- set interface vxlan0 \ type=vxlan options:remote_ip=172.168.1.2 options:out_key=flow ovs-ofctl add-flow int-br in_port=LOCAL, icmp,\ actions=set_tunnel:3, output:1 (1 is the port# of vxlan0) Output tunnel ID should be modified to 3 with this patch. Signed-off-by: Ricky Li <ricky.li@intel.com> Acked-by: Pravin B Shelar <pshelar@nicira.com>
* flow_format: Do not format "in_port=0".Jarno Rajahalme2015-03-263-303/+303
| | | | | | | | | | flow_format() is used mainly for formating the headers of packets embedded in OpenFlow PACKET_IN messages. In this case the flow does not have a valid port number, and printing out "in_port=0" only confuses the resulting output. Besides, 0 is not a valid OpenFlow port number. Signed-off-by: Jarno Rajahalme <jrajahalme@nicira.com> Acked-by: Ben Pfaff <blp@nicira.com>
* ofproto-dpif: Restore metadata and registers on recirculation.Jarno Rajahalme2015-03-262-104/+123
| | | | | | | | | | | | | | | | | | | | | | | | xlate_actions() now considers an optional recirculation context (via 'xin') and restores OpenFlow pipeline metadata (registers, 'metadata', etc.) based on it. The recirculation context may contain an action set and stack to be restored and further actions to be executed upon recirculation. It also contains a table_id number to be used for rule lookup in cases where no post-recirculation actions are used. The translation context internal metadata is restored using a new internal action: UNROLL_XLATE action stores the translation context data visible to OpenFlow controllers via PACKET_IN messages. This includes the current table number and the current rule cookie. UNROLL_XLATE actions are inserted only when the remaining actions may generate PACKET_IN messages. These changes allow the post-MPLS recirculation to properly continue with the pipeline metadata that existed at the time of recirculation. The internal table is still consulted for bonds. Signed-off-by: Jarno Rajahalme <jrajahalme@nicira.com> Acked-by: Ethan Jackson <ethan@nicira.com> Acked-by: Ben Pfaff <blp@nicira.com>
* ofproto-dpif-xlate: Roll back group bucket actions after every bucket.Jarno Rajahalme2015-03-241-0/+12
| | | | | | | | | We used to roll back group bucket changes only for 'all' and 'indirect' group types, but the expected semantics of all group types is that any changes by the group bucket are not visible after the group has been executed. Signed-off-by: Jarno Rajahalme <jrajahalme@nicira.com> Acked-by: Ben Pfaff <blp@nicira.com>
* Implement hash fields select groupSimon Horman2015-03-242-4/+45
| | | | | | | | | | This is intended as a usable demonstration of how the NTR selection method extension might may be used. NTR selection method Signed-off-by: Simon Horman <simon.horman@netronome.com> [blp@nicira.com added a NEWS entry] Signed-off-by: Ben Pfaff <blp@nicira.com>
* Support NTR selection method in ovs-ofctl group commandsSimon Horman2015-03-241-2/+2
| | | | | | NTR selection method Signed-off-by: Simon Horman <simon.horman@netronome.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
* auto-attach: Support latest version of auto-attach LLDP TLVsDennis Flynn2015-03-231-16/+17
| | | | | | | | | | | | | | | | | The following enhancements to the auto-attach feature are provided - Support recent modifications to the AA element discovery TLV - Support recent Avaya Organizationally Unique ID (OUI) change. (This will change to IEEE assigned OUI once AA standard has been ratified) - Remove some Avaya specific #defines The primary purpose of this commit is to catch up with the latest changes made to the auto attach TLVs as the Auto Attach feature progresses through the 802.1Q IEEE standards committee. Most notably this includes some minor rework of the AA element discovery TLV and a recent change to the Avaya OUI value. Signed-off-by: Dennis Flynn <drflynn@avaya.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
* ovs-vsctl-bashcomp: Avoid setting the COMP_WORDBREAKS.Alex Wang2015-03-201-5/+5
| | | | | | | | | | | | | Modifying $COMP_WORDBREAKS in completion script is not the recommended as it is a global variable and the modification could affect the behavior of other completion scripts. As a workaround, this commit uses the _get_comp_words_by_ref which allows user to exclude characters out of $COMP_WORDBREAKS and reassemble input command line. However, as a side effect, the bash completion module cannot handle characters defined in $COMP_WORDBREAKS (e.g. ':' and '=') correctly in the resulting completions. Thusly, we need to trim the colon-word and equal-word prefixes from reply. Signed-off-by: Alex Wang <alexw@nicira.com>
* command-line: add ovs_cmdl_contextRussell Bryant2015-03-1711-222/+270
| | | | | | | | | | | | | | | | | | | | | | | I started working on a new command line utility that used this shared code. I wanted the ability to pass some data from common initialization code to all of the commands. You can find a similar pattern in ovs-vsctl. This patch updates the command handler to take a new struct, ovs_cmdl_context, instead of argc and argv directly. It includes argc and argv, but also includes an opaque type (void *), where the user of this API can attach its custom data it wants passed along to command handlers. This patch affected the ovstest sub-programs, as well. The patch includes a bit of an odd hack to OVSTEST_REGISTER() to avoid making the main() function of the sub-programs take a ovs_cmdl_context. The test main() functions still receive argc and argv directly, as that seems more natural. The test-subprograms themselves are able to make use of a context internally, though. Signed-off-by: Russell Bryant <rbryant@redhat.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
* ofproto-dpif-xlate: Preserve stack across patch port.Jarno Rajahalme2015-03-161-0/+49
| | | | | | | | | Prevent a peer patch port bridge from popping data off or pushing data to the stack of the first bridge. Found by inspection. Signed-off-by: Jarno Rajahalme <jrajahalme@nicira.com> Acked-by: Ben Pfaff <blp@nicira.com>
* match: Do not skip formatting a zero dp_hash.Jarno Rajahalme2015-03-162-3/+3
| | | | | | | | | | The dp_hash match should be printed whenever it is being matched. We keep the old behavior for flow_format(), which is mostly used to format PACKET_IN messages. This keeps those messages tidier and avoids changing a lot of test cases. Signed-off-by: Jarno Rajahalme <jrajahalme@nicira.com> Acked-by: Andy Zhou <azhou@nicira.com> Acked-by: Ben Pfaff <blp@nicira.com>
* Add testsuite.tmp.orig to .gitignoreAlin Serdean2015-03-161-0/+1
| | | | | | | Adding the file: tests/testsuite.tmp.orig to tests/.gitignore Signed-off-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
* test-hash: Improve comments.Alex Wang2015-03-161-68/+51
| | | | | | | | This commit tries to simplify and further clarify the test cases in test-hash. Signed-off-by: Alex Wang <alexw@nicira.com> Acked-by: Ben Pfaff <blp@nicira.com>
* command-line: add ovs_cmdl_ prefixRussell Bryant2015-03-1612-41/+41
| | | | | | | | | | | | | | | | | The coding style guidelines include the following: - Pick a unique name prefix (ending with an underscore) for each module, and apply that prefix to all of that module's externally visible names. Names of macro parameters, struct and union members, and parameters in function prototypes are not considered externally visible for this purpose. This patch adds the new prefix to the externally visible names. This makes it a bit more obvious what code is coming from common command line handling code. Signed-off-by: Russell Bryant <rbryant@redhat.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
* ovstest: Fix a typo in a comment.Russell Bryant2015-03-161-1/+1
| | | | | | | Fix a typo in an example of invoking 'ovstest' in a comment. Signed-off-by: Russell Bryant <rbryant@redhat.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
* ovs-vsctl-bashcomp: Fix build failure when bash version < 4.0.Alex Wang2015-03-131-3/+3
| | | | | | | | | The ovs-vsctl-bashcomp script does not work properly on bash (version < 4.0). This commit adds test for the bash version and avoids running the script/test when the bash version is not supported. Signed-off-by: Alex Wang <alexw@nicira.com> Acked-by: Ben Pfaff <blp@nicira.com>
* Use the IANA-assigned ports for OpenFlow and OVSDB.Justin Pettit2015-03-121-1/+1
| | | | | | | | We've been warning about the change since 2.1, which was released a year ago. Signed-off-by: Justin Pettit <jpettit@nicira.com> Acked-by: Ben Pfaff <blp@nicira.com>
* ovs-vsctl-bashcomp: Documentation and unit tests.Alex Wang2015-03-121-0/+460
| | | | | | | | | This commit includes the unit tests for ovs-vsctl-bashcomp and refines the ovs-command-bashcomp.INSTALL.md to introduce the bash completion for ovs-vsctl. Signed-off-by: Alex Wang <alexw@nicira.com> Acked-by: Ben Pfaff <blp@nicira.com>
* ovs-appctl-bashcomp: Keep naming consistency.Alex Wang2015-03-121-30/+30
| | | | | | | | | Before adding the completion script ovs-vsctl-bashcomp.bash for ovs-vsctl command, this commit renames the ovs-command-compgen.bash to ovs-appctl-bashcomp.bash to keep the script naming consistent. Signed-off-by: Alex Wang <alexw@nicira.com> Acked-by: Ben Pfaff <blp@nicira.com>
* lldp: Fix DPDK build.Pravin B Shelar2015-03-041-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes following dp-packet access. Removes netinet/if_ether.h include due to duplicate definition of ether_addr. ------ In file included from /usr/include/netinet/if_ether.h:60:0, from lib/lldp/lldpd.h:23, from lib/ovs-lldp.h:26, from lib/ovs-lldp.c:30: /usr/include/net/ethernet.h: At top level: /usr/include/net/ethernet.h:32:8: error: redefinition of 'struct ether_addr' struct ether_addr ^ In file included from ../dpdk/dpdk/x86_64-native-linuxapp-gcc/include/rte_ethdev.h:179:0, from lib/netdev-dpdk.h:18, from lib/dp-packet.h:25, from lib/ovs-lldp.h:23, from lib/ovs-lldp.c:30: ../dpdk/dpdk/x86_64-native-linuxapp-gcc/include/rte_ether.h:83:8: note: originally defined here struct ether_addr { ^ lib/ovs-lldp.c: In function 'lldp_process_packet': lib/ovs-lldp.c:676:30: error: 'const struct dp_packet' has no member named 'data_' (char *) p->data_, p->size_); ^ lib/ovs-lldp.c:676:40: error: 'const struct dp_packet' has no member named 'size_' (char *) p->data_, p->size_); ------ Signed-off-by: Pravin B Shelar <pshelar@nicira.com> Acked-by: Daniele Di Proietto <diproiettod@vmware.com> Acked-by: Ben Pfaff <blp@nicira.com>
* test-hash: Do not exit check_word_hash() when there is a failure.Alex Wang2015-03-041-1/+0
| | | | | | | | | | This commit makes check_word_hash() run to finish even when there is a failure during the run. The test will still fail due to the output check in AT_CHECK. And developers can benefit from having all failed hashes instead of only the first one. Signed-off-by: Alex Wang <alexw@nicira.com> Acked-by: Ben Pfaff <blp@nicira.com>
* test-hash: Test hash_bytes128() with single 128-bit word.Alex Wang2015-03-041-12/+89
| | | | | | | | | This commit adds a new test for hash_bytes128() using single 128-bit word. The test shows that there is no collision in all 19 consecutive bits checks, which indicates the hash function is good. Signed-off-by: Alex Wang <alexw@nicira.com> Acked-by: Joe Stringer <joestringer@nicira.com>
* lldpd: Fix use of list of struct lldpd_hardware.Ben Pfaff2015-03-031-3/+2
| | | | | | | | | | A list of some type should have type "struct ovs_list", not some other type that encapsulates it. This ovs_list is a bit puzzling in itself, because it appears to always have exactly one element. Signed-off-by: Ben Pfaff <blp@nicira.com>
* lldpd-structs: Fix type of c_id member.Ben Pfaff2015-03-031-2/+2
| | | | | | | This member is typically an Ethernet address so the appropriate type is uint8_t, not char. This eliminates a couple of casts. Signed-off-by: Ben Pfaff <blp@nicira.com>
* lldp-structs: Fix use of list of lldpd_aa_isid_vlan_maps_tlv.Ben Pfaff2015-03-031-8/+5
| | | | | | | A list of some type should have type "struct ovs_list", not some other type that encapsulates it. Signed-off-by: Ben Pfaff <blp@nicira.com>
* lldp: Change representation of ISID to uint32_t.Ben Pfaff2015-03-031-18/+6
| | | | | | | It's a lot more straightforward to deal with integer values as integers instead of arrays of bytes. Signed-off-by: Ben Pfaff <blp@nicira.com>
* test-aa: Make variables local to this file static.Ben Pfaff2015-03-031-3/+3
| | | | | | Found by sparse. Signed-off-by: Ben Pfaff <blp@nicira.com>
* lldp: Get rid of POKE macros in favor of inline functions.Ben Pfaff2015-03-031-3/+3
| | | | | | | | | | | The POKE macros previously used here don't match the style usually used in OVS and they require the user to know exactly how many bytes to reserve. This commit replaces them by easier-to-use inline functions that take advantage of the ofpbuf interface. Also removes a few PEEK macros that weren't used anywhere. Signed-off-by: Ben Pfaff <blp@nicira.com>
* auto-attach: Add auto-attach support to bridge layer and command setDennis Flynn2015-03-035-2/+343
| | | | | | | | | | | | | This is the final commit in the series of commits that deliver initial support for Auto-Attach. Specifically this commit delivers auto-attach support to the OVS bridge layer as well as the new auto-attach commands. The OVSDB schema is modified to define the new auto-attach entries. The man pages, unit tests, and news and license notice files are also updated. A unit test is provided to validate the construction of auto-attach packets. Signed-off-by: Ludovic Beliveau <ludovic.beliveau@windriver.com> Signed-off-by: Dennis Flynn <drflynn@avaya.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
* ofpbuf: Simplify ofpbuf API.Pravin B Shelar2015-03-035-23/+23
| | | | | | | | | | | | ofpbuf was complicated due to its wide usage across all layers of OVS, Now we have introduced independent dp_packet which can be used for datapath packet, we can simplify ofpbuf. Following patch removes DPDK mbuf and access API of ofpbuf members. Signed-off-by: Pravin B Shelar <pshelar@nicira.com> Acked-by: Jarno Rajahalme <jrajahalme@nicira.com> Acked-by: Ben Pfaff <blp@nicira.com>
* dp-packet: Remove ofpbuf dependency.Pravin B Shelar2015-03-034-16/+19
| | | | | | | | | | | | | Currently dp-packet make use of ofpbuf for managing packet buffers. That complicates ofpbuf, by making dp-packet independent of ofpbuf both libraries can be optimized for their own use case. This avoids mapping operation between ofpbuf and dp_packet in datapath upcalls. Signed-off-by: Pravin B Shelar <pshelar@nicira.com> Acked-by: Jarno Rajahalme <jrajahalme@nicira.com> Acked-by: Ben Pfaff <blp@nicira.com>
* test-hash: Remove the check_word_hash() for hash_bytes128_cb.Alex Wang2015-02-271-10/+0
| | | | | | | | | | | | | The original test fails on big-endian system due to the hash function performing not as well when input is uint32_t. In reality, users should only use hash_bytes128() to hash words larger than 128 bits (e.g. struct flow). Besides, we do check the 1-bit set case for 16 128-bit words in following test case. Therefore, the cleanest way to fix the failure in big-endian system seems to be just removing the check_word_hash() test for hash_bytes128_cb. Signed-off-by: Alex Wang <alexw@nicira.com> Acked-by: Ben Pfaff <blp@nicira.com>
* test-hash: Refine the check_256byte_hash().Alex Wang2015-02-271-18/+22
| | | | | | | | This commit refines the check_256byte_hash() function by moving some checks to outer loop. Signed-off-by: Alex Wang <alexw@nicira.com> Acked-by: Ben Pfaff <blp@nicira.com>
* test-hash: Make check_256byte_hash() test no 1-bits set case.Alex Wang2015-02-261-2/+4
| | | | | | | | | | | The test comment mentions that we will test the no 1-bits set case. So, this commit makes sure that it is tested. Signed-off-by: Alex Wang <alexw@nicira.com> --- PATCH->V2: - explain why calling set_bit128 with i or j == n_bits is okay.
View Lorry Controller Status