summaryrefslogtreecommitdiff
path: root/utilities
Commit message (Collapse)AuthorAgeFilesLines
* ovs-ofctl: Free leaked minimatchYifeng Sun2019-09-191-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | Valgrind reported: 1056: ofproto - bundle with multiple flow mods (OpenFlow 1.4) ==19220== 160 bytes in 2 blocks are definitely lost in loss record 24 of 34 ==19220== at 0x4C2DB8F: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==19220== by 0x4979A4: xmalloc (util.c:138) ==19220== by 0x42407D: miniflow_alloc (flow.c:3340) ==19220== by 0x4296CF: minimatch_init (match.c:1758) ==19220== by 0x46273D: parse_ofp_str__ (ofp-flow.c:1759) ==19220== by 0x465B9E: parse_ofp_str (ofp-flow.c:1790) ==19220== by 0x465CE0: parse_ofp_flow_mod_str (ofp-flow.c:1817) ==19220== by 0x465DF6: parse_ofp_flow_mod_file (ofp-flow.c:1876) ==19220== by 0x410BA3: ofctl_flow_mod_file.isra.19 (ovs-ofctl.c:1773) ==19220== by 0x417933: ovs_cmdl_run_command__ (command-line.c:223) ==19220== by 0x406F68: main (ovs-ofctl.c:179) This patch fixes it. Acked-by: William Tu <u9012063@gmail.com> Signed-off-by: Yifeng Sun <pkusunyifeng@gmail.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* ovs-bugtool: Add ip -s -s to get_device_stats.out.William Tu2019-09-181-0/+1
| | | | | | | | | | | The patch adds 'ip -s -s' to file get_device_stats.out to collect device statistics. When debugging tunnel related issues, the command shows much more detailed counters, ex: frame, crc, carrier, helping to understand the root cause when packets are dropped. Reviewed-by: Greg Rose <gvrose8192@gmail.com> Signed-off-by: William Tu <u9012063@gmail.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* checkpatch: Ignore utilities/bugtool.William Tu2019-09-171-0/+2
| | | | | | Reviewed-by: Greg Rose <gvrose8192@gmail.com> Signed-off-by: William Tu <u9012063@gmail.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* Remove OVN.Mark Michelson2019-09-062-240/+6
| | | | | | | | | | | | | | | | OVN is separated into its own repo. This commit removes the OVN source, OVN tests, and OVN documentation. It also removes mentions of OVN from most documentation. The only place where OVN has been left is in changelogs/NEWS, since we shouldn't mess with the history of the project. There is an exception here. The ovsdb-cluster tests rely on ovn-nbctl and ovn-sbctl to run. Therefore those ovn utilities, as well as their dependencies remain in the repo with this commit. Acked-by: Numan Siddique <nusiddiq@redhat.com> Signed-off-by: Mark Michelson <mmichels@redhat.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* Make pid_exists() more robust against empty pid argumentMichele Baldessari2019-08-291-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In some of our destructive testing of ovn-dbs inside containers managed by pacemaker we reached a situation where /var/run/openvswitch had empty .pid files. The current code does not deal well with them and pidfile_is_running() returns true in such a case and this confuses the OCF resource agent. - Before this change: Inside a container run: killall ovsdb-server; echo -n '' > /var/run/openvswitch/ovnnb_db.pid; echo -n '' > /var/run/openvswitch/ovnsb_db.pid We will observe that the cluster is unable to ever recover because it believes the ovn processes to be running when they really aren't and eventually just fails: podman container set: ovn-dbs-bundle [192.168.24.1:8787/rhosp15/openstack-ovn-northd:pcmklatest] ovn-dbs-bundle-0 (ocf::ovn:ovndb-servers): Master controller-0 ovn-dbs-bundle-1 (ocf::ovn:ovndb-servers): Stopped controller-1 ovn-dbs-bundle-2 (ocf::ovn:ovndb-servers): Slave controller-2 Let's make sure pid_exists() returns false when the pid is an empty string. - After this change the cluster is able to recover from this state and correctly start the resource: podman container set: ovn-dbs-bundle [192.168.24.1:8787/rhosp15/openstack-ovn-northd:pcmklatest] ovn-dbs-bundle-0 (ocf::ovn:ovndb-servers): Master controller-0 ovn-dbs-bundle-1 (ocf::ovn:ovndb-servers): Slave controller-1 ovn-dbs-bundle-2 (ocf::ovn:ovndb-servers): Slave controller-2 Fixes: 3028ce2595c8 ("ovs-lib: Allow "status" command to work as non-root.") Signed-off-by: Michele Baldessari <michele@acksyn.org> Signed-off-by: Ben Pfaff <blp@ovn.org>
* utilities: Improve ovs-dpctl-top flow parsingJaime Caamaño Ruiz2019-08-281-11/+12
| | | | | | | | | | * check that expected bytes and packets stats are correctly read from every flow. * check that the expected elements are read for every field type aggregation. Signed-off-by: Jaime Caamaño Ruiz <jcaamano@suse.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* ovs-lib: Add timeout at ovs-check-dead-ifs.William Tu2019-08-261-1/+2
| | | | | | | | | | | | | | | At SUSE12 SP3, we hit a case where ovs-check-dead-ifs tries to read an entry in /proc/<pid>/fd/<some fd> but hangs forever. The pid is a qemu-system-x86_64 process and we suspect it's an issue related to qemu, not ovs. As a result, force-reload-kmod hangs and OVS bridge never gets restarted. This patch adds a timeout of 5-seconds to ovs-check-dead-ifs. VMware-BZ: #2408059 Signed-off-by: William Tu <u9012063@gmail.com> Cc: Ashish Varma <ashishvarma.ovs@gmail.com> Cc: Gurucharan Shetty <guru@ovn.org> Signed-off-by: Gurucharan Shetty <guru@ovn.org>
* OVS: Containerize componentsAliasgar Ginwala2019-08-227-1/+155
| | | | | | | | | | | | 1. Start OVS components in containers so that building and shipping of OVS components is easy. 2. Load OVS kernel modules on host from container to avoid installing ovs on host. 3. Update documentation about how to build/run ovs in docker. Acked-by: Numan Siddique <nusiddiq@redhat.com> Signed-off-by: aginwala <aginwala@ebay.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* ovs-lib: Fix standalone db migration to raftAliasgar Ginwala2019-08-211-0/+1
| | | | | | | | | | | | | | | | Current code of create-cluster from standalone db takes backup of existing standalone db and then generates a new clustered dbs from backup dbs. Hence, during migration if nb and sb dbs are still present, create-cluster will fail saying file exists and will not really convert dbs to clustered dbs. This patch fixes the same. e.g message that pops up while migration from standalone to raft cluster: * Backing up database to /etc/openvswitch/ovnnb_db.db.backup5.13.0-1278623084 ovsdb-tool: I/O error: /etc/openvswitch/ovnnb_db.db: create failed (File exists) * Creating cluster database /etc/openvswitch/ovnnb_db.db from existing one Signed-off-by: aginwala <aginwala@ebay.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* checkpatch: Fix regexp for if, while, etc inside macros.Ilya Maximets2019-08-121-1/+1
| | | | | | | | | | | | | | | | This allows to use a one-character expression inside the 'if' statement and multiple spaces before the line continuation character. Fixes false positive in case like this: #define MACRO(ARG) \ if (a) { \ do_work(ARG); \ } Fixes: 16770c6d9179 ("checkpatch: support macro continuation") Signed-off-by: Ilya Maximets <i.maximets@samsung.com> Acked-by: Aaron Conole <aconole@redhat.com>
* checkpatch: Check FOR_EACH loops with numbers.Ilya Maximets2019-07-121-1/+1
| | | | | | | | | | | | | OVS has defines for loops like 'BITMAP_FOR_EACH_1' or 'ULLONG_FOR_EACH_1', but the regexp in checkpatch doesn't match with numbers and skips these loops while checking. This patch adds numbers into regexp and adds some FER_EACH loops to the unit tests. Signed-off-by: Ilya Maximets <i.maximets@samsung.com> Acked-by: Ben Pfaff <blp@ovn.org> Acked-by: Aaron Conole <aconole@redhat.com>
* ovs-ofctl: New testing command "parse-group".Ben Pfaff2019-06-091-1/+40
| | | | | | | This will be used in an upcoming test. Acked-by: Numan Siddique <nusiddiq@redhat.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* checkpatch: Ignore "sparse" headers.Ilya Maximets2019-05-291-0/+5
| | | | | Signed-off-by: Ilya Maximets <i.maximets@samsung.com> Acked-by: Aaron Conole <aconole@redhat.com>
* ovs-save: Handle cases of upgrades from very old OVS versions.Gurucharan Shetty2019-05-091-0/+11
| | | | | | | | | | | | | | | | | | | | | | | | | We have added code to ovs-save over the last few releases which makes the following bad assumptions. 1. The default OpenFlow version of running daemon is OpenFlow14. Impact: This causes upgrades from older OVS versions to end up with no flows in their bridges (even the default 'NORMAL' ones) causing traffic to stop. 2. That ovs-ofctl commands like dump-groups and dump-tlv-map will just work with old OVS versions. Impact: Does not look like it effects the upgrade in a bad away - except you get some errors. Since OpenFlow14 was enabled by default in OVS 2.8, this commit makes a lazy assumption that any upgrade of OVS from versions before 2.7 will not attempt to save and restore flows. VMware-BZ: #2340482 Signed-off-by: Gurucharan Shetty <guru@ovn.org> Acked-by: Ben Pfaff <blp@ovn.org>
* ovs-tcpdump: Fix E117 over-indented.Ilya Maximets2019-04-301-2/+2
| | | | | | | | | | utilities/ovs-tcpdump.in:376:9: E117 over-indented make[2]: *** [flake8-check] Error 1 CC: Liu Chang <txfh2007@aliyun.com> Fixes: 2eeadf73d931 ("ovs-tcpdump: Improve error message when tcpdump is not available.") Acked-by: Aaron Conole <aconole@redhat.com> Signed-off-by: Ilya Maximets <i.maximets@samsung.com>
* ovs-tcpdump: Improve error message when tcpdump is not available.Liu Chang2019-04-161-0/+9
| | | | | Signed-off-by: Liu Chang <txfh2007@aliyun.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* checkpatch: Fix handling of line endings.Ilya Maximets2019-04-151-1/+1
| | | | | | | | | Unlike manual splitting, 'splitlines' correctly handles different line endings. Without this change script fails to check files with '\r\n' endings treating the whole patch as a header. Signed-off-by: Ilya Maximets <i.maximets@samsung.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* checkpatch: Normalize exit code for WindowsAlin Gabriel Serdean2019-04-031-11/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Using python `sys.exit(-1)` on Windows produces mixed results. Let's take the following results from different shells: CMD >python -c "import sys; sys.exit(-1)" & echo %errorlevel% 1 MSYS $ python -c "import sys; sys.exit(-1)" && echo $? 0 WSL $ python -c "import sys; sys.exit(-1)"; echo $? 255 this results in the following tests to fail: checkpatch 10: checkpatch - sign-offs FAILED (checkpatch.at:32) 11: checkpatch - parenthesized constructs FAILED (checkpatch.at:32) 12: checkpatch - parenthesized constructs - for FAILED (checkpatch.at:32) 13: checkpatch - comments FAILED (checkpatch.at:32) because of: ./checkpatch.at:32: exit code was 0, expected 255 This patch introduces a positive constant for the default exit code (1) similar to other OVS utilities. Signed-off-by: Alin Gabriel Serdean <aserdean@ovn.org> Acked-by: Ben Pfaff <blp@ovn.org> Acked-by: Aaron Conole <aconole@redhat.com>
* ovs-vsctl: Add datapath_type column to show command.Ilya Maximets2019-03-221-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | Sometimes it's unclear which datapath type is in use by particular bridge. For example, if all the interfaces supported by both system and netdev datapaths it needs a DB query or log analysis to find out which 'datapath_type' is in use. Another case is that it's hard to figure out if patch ports are really connected to each other. They are definitely not connected if datapath types of their bridges differs. With this change non-default 'datapath_type's will be exposed to 'ovs-vsctl show' command, so it'll be easier to spot misconfiguration. $ ovs-vsctl show ... Bridge "br0" datapath_type: netdev Port "br0" Interface "br0" type: internal ... Acked-by: Eelco Chaudron <echaudro@redhat.com> Signed-off-by: Ilya Maximets <i.maximets@samsung.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* ofctl: break the loop if ovs_pcap_read returns errorLi RongQing2019-02-221-0/+1
| | | | | | | otherwise packet is NULL, and dereference it to cause segfault Signed-off-by: Li RongQing <lirongqing@baidu.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* checkpatch: Escape range operators inside regex.Ilya Maximets2019-02-221-3/+8
| | | | | | | | | | | | | | | | | | | | | ' -(' matches a single character in the range between ' ' (index 32) and '(' (index 40). This leads to the false positive: WARNING: Line lacks whitespace around operator #445 FILE: ovsdb/monitor.c:573: if (--mcs->n_refs == 0) { Need to escape '-' to have a right behaviour. This patch additionally escapes all other '-' chars in the similar regexes and makes them be one per line to ease the review in case of future changes. Basic unit tests added. CC: Joe Stringer <joe@ovn.org> Fixes: 0d7b16daea50 ("checkpatch: Check for infix operator whitespace.") Signed-off-by: Ilya Maximets <i.maximets@samsung.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* python: Fix E117 over-indented.Ilya Maximets2019-02-121-8/+8
| | | | | | | | | | | | | | | | New check was added to recent pycodestyle-2.5.0 and flake8 complains while building on Travis: ../utilities/bugtool/ovs-bugtool.in:767:17: E117 over-indented ../utilities/bugtool/ovs-bugtool.in:771:17: E117 over-indented ../utilities/bugtool/ovs-bugtool.in:774:17: E117 over-indented ../utilities/bugtool/ovs-bugtool.in:778:17: E117 over-indented ../python/ovs/db/error.py:33:17: E117 over-indented ../python/ovs/poller.py:118:21: E117 over-indented ../python/ovs/reconnect.py:244:17: E117 over-indented Signed-off-by: Ilya Maximets <i.maximets@samsung.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* ovs-ctl: Permit to specify additional optionsTimothy Redaelli2019-02-111-0/+4
| | | | | | | | | | | | | | | | | Currently using ovs-ctl is not possible to specify additional options for ovs-vswitchd and ovsdb-server (for example to specify a different loglevel during daemon startup). This patch adds --ovs-vswitchd-options and --ovsdb-server-options options to ovs-ctl in order to specify the additional options. Due to word splitting it may not be possible to specify an option that includes whitespaces. Reported-at: https://bugzilla.redhat.com/1664794 Reported-by: Matt Flusche <mflusche@redhat.com> Signed-off-by: Timothy Redaelli <tredaelli@redhat.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* ovs-lib.in: Cleanup old socket and pidfiles in stop_daemonTimothy Redaelli2019-02-111-0/+4
| | | | | | | | | | | | | | | | Currently if a client crashes (signal 11) the unix socket (.ctl) and the pidfile may not be deleted when you use ovs-ctl stop or restart. Moreover since ovs-appctl is used on a closed socket some warnings are printed. This commit deletes the pidfile and the unix socket then returns without running ovs-appctl if the pidfile point to a not-existing pid. Reported-at: https://bugzilla.redhat.com/1667845 Reported-by: Candido Campos <ccamposr@redhat.com> Signed-off-by: Timothy Redaelli <tredaelli@redhat.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* Remove support for OpenFlow 1.6 (draft).Ben Pfaff2019-02-052-6/+3
| | | | | | | | | ONF abandoned the OpenFlow specification, so that OpenFlow 1.6 will never be completed. It did not contain much in the way of useful features, so remove what support Open vSwitch already had. Signed-off-by: Ben Pfaff <blp@ovn.org> Acked-by: Justin Pettit <jpettit@ovn.org>
* ovs-tcpdump: Fix an undefined variableHyong Youb Kim2019-02-041-0/+1
| | | | | | | | | | | | | | | | | Run ovs-tcpdump without --span, and it throws the following exception. Define mirror_select_all to avoid the error. Traceback (most recent call last): File "/usr/local/bin/ovs-tcpdump", line 488, in <module> main() File "/usr/local/bin/ovs-tcpdump", line 454, in main mirror_select_all) UnboundLocalError: local variable 'mirror_select_all' referenced before assignment Fixes: 0475db71c650 ("ovs-tcpdump: Add --span to mirror all ports on bridge.") Acked-by: Ilya Maximets <i.maximets@samsung.com> Signed-off-by: Hyong Youb Kim <hyonkim@cisco.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* checkpatch: Check for C99 style comments.Ilya Maximets2019-01-181-0/+11
| | | | | | | | Coding-style document asks not to use C99 ( '//' ) comments. Acked-by: Aaron Conole <aconole@redhat.com> Signed-off-by: Ilya Maximets <i.maximets@samsung.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* ovs-vswitchd: Implement OFPT_TABLE_FEATURES table modification request.Ben Pfaff2019-01-152-21/+119
| | | | | | | | | This allows a controller to change the name of OpenFlow flow tables in the OVS software switch. CC: Brad Cowie <brad@cowie.nz> Acked-by: Justin Pettit <jpettit@ovn.org> Signed-off-by: Ben Pfaff <blp@ovn.org>
* checkpatch: Check style of FOREACH loops.Ilya Maximets2019-01-151-1/+1
| | | | | | | | | | Current checkpatch rules matches only OVS 'FOR_EACH' loops. This change will apply same style checks for DPDK iterators like 'RTE_ETH_FOREACH_MATCHING_DEV () {}'. Acked-by: Aaron Conole <aconole@redhat.com> Signed-off-by: Ilya Maximets <i.maximets@samsung.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* python: Fix invalid escape sequences.Ben Pfaff2019-01-112-13/+13
| | | | | | | | | | It appears that Python silently treats invalid escape sequences in strings as literals, e.g. "\." is the same as "\\.". Newer versions of checkpatch complain, and it does seem reasonable to me to fix these. Acked-by: Numan Siddique <nusiddiq@redhat.com> Tested-by: Numan Siddique <nusiddiq@redhat.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* ovs-actions: New document describing OVS actions in detail.Ben Pfaff2019-01-101-1054/+6
| | | | | Acked-by: Mark Michelson <mmichels@redhat.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* vconn: Allow timeout configuration for blocking connection.Ilya Maximets2019-01-101-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | On some systems in case where remote is not responding, socket could remain in SYN_SENT state for a really long time without errors waiting for connection. This leads to situations where vconn connection hangs for a few minutes waiting for connection to the DOWN remote. For example, this situation emulated by "refuse-connection" vconn testcase. This leads to test failures because Alarm signal arrives much faster than ETIMEDOUT from the socket: ./vconn.at:21: ovstest test-vconn refuse-connection tcp Alarm clock stderr: |socket_util|INFO|0:127.0.0.1: listening on port 63812 |poll_loop|DBG|wakeup due to 0-ms timeout |poll_loop|DBG|wakeup due to 10155-ms timeout |fatal_signal|WARN|terminating with signal 14 (Alarm clock) ./vconn.at:21: exit code was 142, expected 0 vconn.at:21: 535. tcp vconn - refuse connection (vconn.at:21): FAILED This patch allowes to specify timeout value for vconn blocking connections. If the connection takes more time, socket will be closed with ETIMEDOUT error code. Negative value could be used to wait infinitely. Signed-off-by: Ilya Maximets <i.maximets@samsung.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* utilities: gdb debug commands fix typosAndreas Karis2019-01-101-2/+2
| | | | | | | | Fix minor typos in ovs_gdb debug script. Acked-by: Eelco Chaudron <echaudro@redhat.com> Signed-off-by: Andreas Karis <akaris@redhat.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* utilities: Update gdb script so it works with all python versionsEelco Chaudron2019-01-101-20/+103
| | | | | | | | | | | | | | | | | Newer versions of Python require a different iterator function. This change will make the iterator classes work with all Python versions. Adds a fix for python3 as it does not support the long() type. The fix guaranties the script still works on Python 2.7. The uKey walker is rather slow on python3, so added a spinner to indicate we are still busy processing entries. Fix functions using the iterkeys() function on dictionaries. Tested-by: solomon <liwei.solomon@gmail.com> Signed-off-by: Eelco Chaudron <echaudro@redhat.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* ovs-tcpdump: Add --span to mirror all ports on bridge.Martin Fong2018-12-122-3/+12
| | | | | Signed-off-by: Martin Fong <mwfong@csl.sri.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* utilities: Add smap related command and iterator to the GDB scriptEelco Chaudron2018-12-121-3/+53
| | | | | | | | | | | | | | | | Adds "ovs_dump_smap <struct smap *>" command Example output: Breakpoint 1, trtcm_policer_qos_construct (details=0x135bad0, conf=0x7ffd31f5da28) at lib/netdev-dpdk.c:4154 (gdb) ovs_dump_smap 0x135bad0 cbs: 2048 cir: 151800 eir: 151800 pbs: 2048 Signed-off-by: Eelco Chaudron <echaudro@redhat.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* ovs-ctl: fix system-id.conf ownerDavid Marchand2018-12-102-3/+9
| | | | | | | | | | | | | | | | | | | | | | As far as RPMs are concerned, system-id.conf file is declared as being owned by openvswitch. At the first ovs startup, ovs-ctl creates this file if none exists without ensuring this. We end up with an inconsistency: $ rpm -V openvswitch .....UG.. c /etc/openvswitch/system-id.conf Fix this when ovs-ctl is the one who creates the file. Note: this issue ends up being hidden after a RPM upgrade, since the openvswitch user is enforced on the whole /etc/openvswitch directory as a %post operation. Acked-by: Timothy Redaelli <tredaelli@redhat.com> Acked-by: Flavio Leitner <fbl@sysclose.org> Signed-off-by: David Marchand <david.marchand@redhat.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* ovs-ctl: fallback to "uname -n" for fetching hostnameYousong Zhou2018-12-031-3/+4
| | | | | | | | | The command "hostname" is not available in OpenWrt by default. Strace result of hostname-3.13 on centos7 shows that bare "hostname" command calls uname() to fetch node name. Signed-off-by: Yousong Zhou <yszhou4tech@gmail.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* ovs-ofctl: update a man page about group syntaxNobuhiro MIKI2018-12-031-0/+4
| | | | Signed-off-by: Nobuhiro MIKI <nob@bobuhiro11.net>
* ovs-ofctl: Correct "out_group" field usage text in manpage.Ashish Varma2018-12-031-1/+1
| | | | | | | | Right now the man page of ovs-ofctl has "out_group=port". Correcting the output to group instead of port. Signed-off-by: Ashish Varma <ashishvarma.ovs@gmail.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* ovs-save: compatible with busybox ip commandYousong Zhou2018-12-031-1/+1
| | | | | | | | Busybox ip command will have exit code 1 for `ip -V` or `ip help` etc., use `ip link show` to cover both iproute2 and busybox ip command Signed-off-by: Yousong Zhou <yszhou4tech@gmail.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* debian and rhel: Create IPsec package.Qiuyu Xiao2018-11-091-0/+27
| | | | | | | | | Added rules and files to create debian and rpm ovs-ipsec packages. Signed-off-by: Qiuyu Xiao <qiuyu.xiao.qyx@gmail.com> Signed-off-by: Ansis Atteka <aatteka@ovn.org> Co-authored-by: Ansis Atteka <aatteka@ovn.org> Signed-off-by: Ben Pfaff <blp@ovn.org>
* checkpatch: fix typographical errorBala Sankaran2018-11-051-1/+1
| | | | | | | | A typographical error in a prompt for missing python enchant library is identified and fixed. Signed-off-by: Bala Sankaran <bsankara@redhat.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* checkpatch: Speed up checking when spell checking not enabled.Ben Pfaff2018-11-021-55/+62
| | | | | | | | | On my machine it takes almost a second for enchant to read its dictionary. This time is wasted when spell checking is not enabled. This commit makes checkpatch read the dictionary only when it will be used. Reviewed-by: Yifeng Sun <pkusunyifeng@gmail.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* checkpatch: Add explicit test for mailing list as author.Ben Pfaff2018-11-021-0/+3
| | | | | | | | Somehow some such patches snuck through. checkpatch caught them (and the committer missed that) but this makes it even more explicit. Reviewed-by: Yifeng Sun <pkusunyifeng@gmail.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* ovs-lib.in: Remove unnecessary conntrack flushYi-Hung Wei2018-10-311-3/+0
| | | | | | | | | | | | | | | We introduced flush-conntrack in force-reload-kmod script by commit 8bea39b186ca ("datapath: Prevent panic") to prevent kernel panic. It turns out that the kernel panic is actually triggered by the IPv4 secret timer, and it is fixed by commit 121905984724 ("compat: Initialize IPv4 reassembly secret timer"). This commit removes the unnecessary conntrack flush in the script. Signed-off-by: Yi-Hung Wei <yihung.wei@gmail.com> CC: Greg Rose <gvrose8192@gmail.com> Signed-off-by: Ben Pfaff <blp@ovn.org> Reviewed-by: Greg Rose <gvrose8192@gmail.com>
* manpages: Include ovs.tmac in most man roots.Ilya Maximets2018-10-3013-56/+13
| | | | | | | | | | | | | | | This allows to not redefine common macroses in every single file and allowes using things like .EX without warying about compatibility. manpages.mk updated automatically. Files that are already complete pages (i.e. has no *.in sources) wasn't touched, because this will require additional file manipulations and changes in makefiles/specs without serious profit. Signed-off-by: Ilya Maximets <i.maximets@samsung.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* ofp-table: Always format the table number in table features.Ben Pfaff2018-10-261-1/+0
| | | | | | | | | | | Table features should indicate the table number as well as the table name. Before this, the first line for each table looked like this: table myname ("myname"): but it's more useful if it's: table 123 ("myname"): Signed-off-by: Ben Pfaff <blp@ovn.org> Acked-by: Justin Pettit <jpettit@ovn.org>
* ofp-table: Better summarize table features and statistics.Ben Pfaff2018-10-261-4/+9
| | | | | | | | | | | | | | | | Before this patch, most dump-table-stats outputs would contain about 250 lines of the form: table #: ditto With this patch, they have one line like this: tables 2...254: ditto which is much easier to read. Signed-off-by: Ben Pfaff <blp@ovn.org> Acked-by: Justin Pettit <jpettit@ovn.org>
* ovs-ofctl: Update documentation for MPLS actions.Ben Pfaff2018-10-261-9/+3
| | | | | | Reported-by: lidejun <lidejun1@huawei.com> Signed-off-by: Ben Pfaff <blp@ovn.org> Acked-by: Justin Pettit <jpettit@ovn.org>
View Lorry Controller Status