summaryrefslogtreecommitdiff
path: root/xenserver
Commit message (Collapse)AuthorAgeFilesLines
...
* BFD: Add BFD output to bugtoolPavithra Ramesh2013-07-171-0/+5
| | | | | | | | This change includes the output of ovs-appctl bfd/show to ovs-bugtool output. Signed-off-by: Pavithra Ramesh <paramesh@vmware.com> Signed-off-by: Gurucharan Shetty <gshetty@nicira.com>
* rhel, xenserver: Create /var/log/openvswitch directory.Gurucharan Shetty2013-07-151-0/+1
| | | | | | | | During installation create the /var/log/openvswitch directory so that openvswitch startup script is able to write the ovs-ctl.log Signed-off-by: Gurucharan Shetty <gshetty@nicira.com> Acked-by: Ben Pfaff <blp@nicira.com>
* ovs-bugtool: Add ovsdb-server/list-dbs command to bugtool.Gurucharan Shetty2013-07-101-0/+5
| | | | | Signed-off-by: Gurucharan Shetty <gshetty@nicira.com> Acked-by: Ben Pfaff <blp@nicira.com>
* ovs-xapi-sync: Make bridge-id caching logic easier to understand.Ben Pfaff2013-06-191-17/+17
| | | | | | | | The previous code had many subtleties that were easy to miss. This code is intended to be more obviously correct. Signed-off-by: Ben Pfaff <blp@nicira.com> Tested-by: Gurucharan Shetty <shettyg@nicira.com>
* ovs-xapi-sync: Cache the bridge-id value for non nicira-bridge-id too.Gurucharan Shetty2013-06-181-31/+14
| | | | | | | | | | | | | | | | | | | | Currently we connect to xapi in case there are multiple external_ids:xs-network-uuids to get the single bridge id everytime we have a change in the database for all the interested columns in ovs-xapi-sync. The xs-network-uuids value can also change whenever new VLANs are added or deleted, which is a common use case. The disadvantage with this approach is that we query XAPI more often and set the bridge-id as "" if we don't get a valid response for our query. This can take down the logical connectivity for all the VMs on that xenserver. Instead of looking at the PIF records for all the xs-network-uuids, we can instead just look at the xapi record which has the same bridge name as the OVS bridge name and then cache its uuid. This value will hold true till the OVS bridge is recreated in which case we will re-read the value. Signed-off-by: Gurucharan Shetty <gshetty@nicira.com>
* leak-checker: Remove because it cannot be made thread-safe.Ben Pfaff2013-06-171-3/+1
| | | | | | | | | The underlying glibc interface is deprecated because the interface itself is not thread-safe. That means that there's no way for a layer on top of it to be thread-safe. Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Ethan Jackson <ethan@nicira.com>
* ovs-xapi-sync: Retry getting bridge-ids in case xapi is not ready.Gurucharan Shetty2013-06-141-3/+12
| | | | | | | | | | | | | When there are multiple xs-network-uuids set for a bridge, we query xapi to get the record that does not have a VLAN associated with it. For cases when xapi does not respond, retry again after a second. During the times when xapi does not respond, set the value as external_ids:bridge_id "". Bug #17877. Signed-off-by: Gurucharan Shetty <gshetty@nicira.com>
* Fix misspellings in comments and docs.Andy Hill2013-06-042-2/+2
| | | | | | | | Flagged with: https://github.com/lyda/misspell-check Run with: git ls-files | misspellings -f - Signed-off-by: Andy Hill <hillad@gmail.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
* ovs-xapi-sync: Handle exceptions from XAPI for get_single_bridge_id.Gurucharan Shetty2013-05-241-7/+17
| | | | | | | | | | There are possibilities when records disappear underneath ovs-xapi-sync. In this particular case, when VLAN network was deleted, the corresponding record in bridge's external_ids:xs_network_ids column was not deleted by xenserver. In situations like that handle the exceptions cleanly. Bug #17390. Signed-off-by: Gurucharan Shetty <gshetty@nicira.com>
* ovs-xapi-sync: Handle multiple xs-network-uuids for xs 6.1.Gurucharan Shetty2013-05-201-0/+22
| | | | | | | | | | | | | | | | | | | For xenservers with version less than 6.1, interface reconfiguration happened through interface-reconfigure scripts in this repo. In cases where there were multiple xs-network-uuids for a single bridge, interface-reconfigure script would add the network uuid associated with the non-VLAN network as the first record. ovs-xapi-sync would just blindly use the first record to create the bridge-id But it looks like for xenserver 6.1, interface-reconfigure script is no longer used and xenserver natively writes the xs-network-uuids. So, in ovs-xapi-sync we no longer can copy the first value in xs-network-uuids as bridge-id. This commit fetches the PIF record for each xs-network-uuids and the network that does not have a VLAN associated with it is copied over to bridge-id. Bug #17090. Signed-off-by: Gurucharan Shetty <gshetty@nicira.com>
* Revert "rhel, xenserver: Punch holes through firewall for VXLAN."Gurucharan Shetty2013-04-161-1/+0
| | | | | | | | | | This reverts commit 5902b4ed6. For end users that do not plan to use tunnels or use only selected tunnels, it probably is a bad idea to punch firewall holes by default. Opening holes like this may surprise the user. Signed-off-by: Gurucharan Shetty <gshetty@nicira.com>
* rhel, xenserver: Punch holes through firewall for VXLAN.Gurucharan Shetty2013-04-081-0/+1
| | | | | Bug #15518. Signed-off-by: Gurucharan Shetty <gshetty@nicira.com>
* xenserver: Add information about some bugtool scripts.Gurucharan Shetty2013-03-251-1/+17
| | | | | | | The README file in xenserver directory currently misses information about a few bugtool scripts. Add them. Signed-off-by: Gurucharan Shetty <gshetty@nicira.com>
* ovs-bugtool: Add ovs-appctl dpif commands to debug bundle.Gurucharan Shetty2013-03-251-0/+5
| | | | | | | | | | | | | With single datapath, 'ovs-dpctl dump-flows ' dumps datapath flows for all the userspace bridges in a system. It can get a little harder to figure out the datapath flows belonging to a particular userspace bridge. This patch adds the 'ovs-appctl dpif/show' and 'ovs-appctl dpif/dump-flows' output for each userspace bridge. This gives us a summary of configured datapaths and all datapath flow entries for each bridge separately. Signed-off-by: Gurucharan Shetty <gshetty@nicira.com>
* ovs-bugtool: Add ovs-ofctl commands to bugtool plugin scripts.Gurucharan Shetty2013-03-211-0/+10
| | | | | | | This patch adds two new scripts that run "ovs-ofctl show" and "ovs-ofctl dump-flows" on each bridge. Signed-off-by: Gurucharan Shetty <gshetty@nicira.com>
* ovs-vsctl: Try connecting only once for active connections by default.Ben Pfaff2013-03-153-6/+6
| | | | | | | | | | | | | | | | | | | | | | | Until now, ovs-vsctl has kept trying to the database server until it succeeded or the timeout expired (if one was specified with --timeout). This meant that if ovsdb-server wasn't running, then ovs-vsctl would hang. The result was that almost every ovs-vsctl invocation in scripts specified a timeout on the off-chance that the database server might not be running. But it's difficult to choose a good timeout. A timeout that is too short can cause spurious failures. A timeout that is too long causes long delays if the server really isn't running. This commit should alleviate this problem. It changes ovs-vsctl's behavior so that, if it fails to connect to the server, it exits unsuccessfully. This makes --timeout obsolete for the purpose of avoiding a hang if the database server isn't running. (--timeout is still useful to avoid a hang if ovsdb-server is running but ovs-vswitchd is not, for ovs-vsctl commands that modify the database. --no-wait also avoids that issue.) Bug #2393. Bug #15594. Reported-by: Jeff Merrick <jmerrick@vmware.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
* debian, rhel, xenserver: Ability to collect ovs-ctl logs.Gurucharan Shetty2013-03-151-6/+5
| | | | | | | | | | | | We use ovs-ctl from startup scripts to start, stop, restart, force-reload-kmod OVS daemons. ovs-ctl gives quite a descriptive o/p while running the above commands. But the o/p goes to stdout. Sometimes, this output is quite useful to debug issues. With this patch, we store the o/p of ovs-ctl when called from startup scripts in /var/log/openvswitch/ovs-ctl.log Signed-off-by: Gurucharan Shetty <gshetty@nicira.com>
* xenserver: Include ovs-bugtool in xenserver rpm.Gurucharan Shetty2013-02-151-3/+4
| | | | | | | | | | | | | | | | | | | Currently we do not include ovs-bugtool in xenserver rpms. This is because xen-bugtool provides the information required to debug openvswitch. But xen-bugtool also provides a lot more data that is not required for openvswitch debugging. This makes the debug bundle quite huge. Also, xen-bugtool takes a lot of time to collect the required information. For example, in my xenserver6.0.2 with 100 OVS interfaces, 'xen-bugtool -y -s' takes 180 seconds to finish creating a debug bundle with a size of 124M. On the other hand, if we run a ovs-bugtool command of the form 'ovs-bugtool -y -s --log-days=10 --outfile bundle.tar.gz', it takes 5 seconds to finish with a debug bundle size of 28M. Signed-off-by: Gurucharan Shetty <gshetty@nicira.com>
* rhel, xenserver: Make logrotate daily and compress old logs.Gurucharan Shetty2013-02-141-0/+2
| | | | | | | | | | | | The default values can be different and usually comes from /etc/logrotate.conf. For xenserver6.0.2, the values in /etc/logrotate.conf is daily and compress. So this patch does not make any difference. But it does future proof against any changes in xenserver in the future. For rhel6.1, the values are weekly and un-compress. Signed-off-by: Gurucharan Shetty <gshetty@nicira.com>
* openvswitch: Remove Linux bridge compatibility.Pravin B Shelar2012-12-271-5/+1
| | | | | | | | | Currently brcompat does not work on master due to recent datapath changes. We have decided to remove it as it is not used very widely. Signed-off-by: Pravin B Shelar <pshelar@nicira.com> Acked-by: Jesse Gross <jesse@nicira.com>
* xenserver, rhel, debian: Use ovs-ctl restart.Gurucharan Shetty2012-10-241-2/+12
| | | | | | | | | | | | | | ovs-ctl has a new command called "restart" which saves and restores the openflow flows on bridges. Use that command from the init scripts when doing a "restart --save-flows=yes". Also, the debian package postinst script can set the variable OVS_RESTART_SAVE_FLOWS to "yes" to ask for save and restore of flows. Feature #13555. Signed-off-by: Gurucharan Shetty <gshetty@nicira.com>
* utilities: New helper ovs-parse-backtrace.Ethan Jackson2012-10-171-0/+2
| | | | | | | | The new ovs-parse-backtrace utility makes the output of ovs-appctl backtrace more human readable by removing duplicate traces and converting addresses to function names. Signed-off-by: Ethan Jackson <ethan@nicira.com>
* Don't assume python is in /usr/bin.Ed Maste2012-07-301-1/+1
| | | | | Signed-off-by: Ed Maste <emaste@freebsd.org> Signed-off-by: Ben Pfaff <blp@nicira.com>
* Fix build error on XenServerAnsis Atteka2012-07-021-1/+1
| | | | | | A missing backslash broke the build. Signed-off-by: Ansis Atteka <aatteka@nicira.com>
* ovs-l3ping: A new test utility that allows to detect L3 tunneling issuesAnsis Atteka2012-07-021-2/+4
| | | | | | | | | | | | | | | | | | ovs-l3ping is similar to ovs-test, but the main difference is that it does not require administrator to open firewall holes for the XML/RPC control connection. This is achieved by encapsulating the Control Connection over the L3 tunnel itself. This tool is not intended as a replacement for ovs-test, because ovs-test covers much broader set of test cases. Sample usage: Node1: ovs-l3ping -s 192.168.122.236,10.1.1.1 -t gre Node2: ovs-l3ping -c 192.168.122.220,10.1.1.2,10.1.1.1 -t gre Issue#11791 Signed-off-by: Ansis Atteka <aatteka@nicira.com>
* xenserver: Improve efficiency of code by using get_all_records_where()Rob Hoes2012-06-271-4/+3
| | | | | | | | | | | Replace the get_record() for network references which caused as many slave-to-master calls as there are Network records plus one. The get_all_records_where() call gets exactly what is needed with a single call. Signed-off-by: Rob Hoes <rob.hoes@citrix.com> Acked-by: Dominic Curran <dominic.curran@citrix.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
* xenserver, rhel: Enable extra ovs-ctl options from init scripts.Ben Pfaff2012-06-152-0/+5
| | | | | | | | This is useful for passing wrapper script options and possibly for other purposes. Bug #11889. Signed-off-by: Ben Pfaff <blp@nicira.com>
* Properly reopen python daemon log files after rotation.Ben Pfaff2012-05-221-7/+4
| | | | | | | The OVS Python daemons weren't reopening their log files after rotation, so all the log information after the second rotation was lost. Signed-off-by: Ben Pfaff <blp@nicira.com>
* vlog: Take advantage of relaxed "-v" syntax through the tree.Ben Pfaff2012-05-224-9/+9
| | | | | | | | The vlog manpage implies that writing ANY explicitly is obsolete, but examples elsewhere in the documentation and code still tend to add it. This removes them. Signed-off-by: Ben Pfaff <blp@nicira.com>
* python: Break unixctl implementation into registry, client, and server.Ben Pfaff2012-05-221-1/+2
| | | | | | | | | | | I wish to add some unixctl commands to the Python vlog module. However, importing ovs.unixctl in ovs.vlog creates a circular dependency, because ovs.unixctl imports ovs.vlog already. The solution, in this commit, is to break the unixctl module into three parts: a register (ovs.unixctl) that does not depend on ovs.vlog, and client (ovs.unixctl.client) and server (ovs.unixctl.server) modules that do. This breaks the circular dependency. Signed-off-by: Ben Pfaff <blp@nicira.com>
* bugtool: Collect bond state information from ovs.Arun Sharma2012-05-101-0/+1
| | | | | | | | | | This is an enhancement in bugtool archive output to determine the bond state information. It is implemented as a plugin which internally calls "ovs-appctl bond/show" command to get bond state. Feature #11283. Signed-off-by: Arun Sharma <arun.sharma@calsoftinc.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
* Global replace of Nicira Networks.Raju Subramanian2012-05-0212-13/+13
| | | | | | | | Replaced all instances of Nicira Networks(, Inc) to Nicira, Inc. Feature #10593 Signed-off-by: Raju Subramanian <rsubramanian@nicira.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
* ovs-ctl: Make "force-reload-kmod" warn when DHCP clients must be restarted.Ben Pfaff2012-05-011-0/+1
| | | | | | | | | | | | | This should make it more obvious when the admin needs to restart a DHCP client (or other daemon). Without this, unless the admin carefully reads the documentation, the first notice he gets about a need to restart the DHCP client can easily be when the lease expires and the machine drops off the network. Bug #5391. Tested-by: Gurucharan Shetty <gshetty@nicira.com> Suggested-by: Duffie Cooley <dcooley@nicira.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
* xenserver: Update Open vSwitch post upgrade instructions.Gurucharan Shetty2012-04-271-8/+13
| | | | | | | | | | | Currently, when we upgrade the userspace rpm for XenServer, we print a message asking users to reboot the hypervisor. This is not needed. The reboot of hypervisor is needed when we upgrade the rpm containing the kernel module. This reboot can sometimes be avoided by running a "service openvswitch force-reload-kmod". Signed-off-by: Gurucharan Shetty <gshetty@nicira.com>
* Python binaries to write comment in db show-log while updating databaseArun Sharma2012-04-101-0/+1
| | | | | | | | | | | This is an improvement in python script ovs-xapi-sync to call add_comment() method while updating database. This will help developer to debug binaries and database from ovsdb-tool show-log command output and understand which python binary is updating db. Feature #10543 Signed-off-by: Arun Sharma <arun.sharma@calsoftinc.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
* bugtool - Collect version information for all running Open vSwitch daemons.Arun Sharma2012-04-051-1/+8
| | | | | | | | | | | | This is an improvement in {ovs|xen}-bugtool archive output to determine the version which was running for all the OVS daemons. It is implemented as a plugin which internally calls "ovs-appctl -t <daemon> version" command for daemons whose pid file is present in /var/run/openvswitch directory. Feature #10383 Signed-off-by: Arun Sharma <arun.sharma@calsoftinc.com> [blp@nicira.com updated debian/copyright.in] Signed-off-by: Ben Pfaff <blp@nicira.com>
* xenserver: Recognize XenServer 5.6-SP2 scripts in RPM %post.Ben Pfaff2012-03-221-0/+6
| | | | | | | | | Somehow we forgot to put the md5sums for 5.6-SP2 so users were getting scary error messages. Bug #10210. Reported-by: Ronald Lee <rlee@nicira.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
* xenserver: Verify updates in ovs-xapi-sync.Ethan Jackson2012-03-191-0/+3
| | | | | | | This prevents potential race conditions when updating database tables. Signed-off-by: Ethan Jackson <ethan@nicira.com>
* configure: Remove --with-build-number.Ben Pfaff2012-03-191-4/+3
| | | | | | | | | | From early days, Nicira used the --with-build-number option to configure to stamp our internal builds. We've since switched to another scheme, so this option is obsolete. Good riddance. Signed-off-by: Ben Pfaff <blp@nicira.com>
* idl: Convert python daemons to utilize SchemaHelper.Ethan Jackson2012-03-091-30/+5
| | | | | | | | The recently added SchemaHelper class significantly simplifies IDL instantiation in Python. This commit converts all users of the old method to the new method, and removes support for the old method. Signed-off-by: Ethan Jackson <ethan@nicira.com>
* ovs-xapi-sync: Use unixctl to trigger cache flushes.Ethan Jackson2012-03-092-19/+17
| | | | | | | | Typically Open vSwitch communicates with running processes using unixctl. This patch converts ovs-xapi-sync to the strategy for consistency. Signed-off-by: Ethan Jackson <ethan@nicira.com>
* ovs-xapi-sync: Add unixctl support.Ethan Jackson2012-03-091-0/+21
| | | | | | | With this patch, users can query a running ovs-xapi-sync's version or ask it to exit using ovs-appctl. Signed-off-by: Ethan Jackson <ethan@nicira.com>
* ovs-xapi-sync: Cache nicira-bridge-id in ovs-xapi-sync.Ethan Jackson2012-03-091-14/+13
| | | | | | | Communicating with xapi from Python can be quite expensive so it makes sense to cache this data if convenient. Signed-off-by: Ethan Jackson <ethan@nicira.com>
* ovs-xapi-sync: Remove useless root_prefix global.Ethan Jackson2012-03-091-7/+2
| | | | | | | There's no reason for this variable to be global, or to exist at all for that matter. Signed-off-by: Ethan Jackson <ethan@nicira.com>
* datapath: omit _mod from module namesChris Wright2012-03-091-4/+4
| | | | | | | | | | | | | | | This renames the datapath modules: openvswitch_mod -> openvswitch brcompat_mod -> brcompat The first makes the module name consistent with upstream, and the latter is just for internal consistency. This makes tools, and documentation refer to a common module name regardless if it's coming from upstream linux or built from datapath/ as part of a local build. Signed-off-by: Chris Wright <chrisw@sous-sol.org> Signed-off-by: Jesse Gross <jesse@nicira.com>
* ovs-xapi-sync: Rerun processing when a db update arrives during a commit.Ben Pfaff2012-03-081-1/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | The logic in ovs-xapi-sync didn't handle the case where ovsdb-server sends a database update before it replies to a transaction that ovs-xapi-sync sent, like this: ovs-xapi-sync ovsdb-server ------------- ------------ . . . transaction request ---> <--- database contents update <--- transaction reply . . . The update was not lost but ovs-xapi-sync would not process it until the database changed again. Bug #10082. Reported-by: Krishna Miriyala <krishna@nicira.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
* xenserver: Add vm-id to the external_ids.Gurucharan Shetty2012-03-061-0/+39
| | | | | | | | | | | | The vm-id external id in the interface table will uniquely identify a VM that is connected to a bridge through that interface. In xenserver, this will have the same value as the external id - xs-vm-uuid and can be overridden by setting the nicira-vm-id key in the other_config field of VM record of XAPI. Bug #10020. Signed-off-by: Gurucharan Shetty <gshetty@nicira.com>
* xenserver: Fix rule for generating xenserver/openvswitch-xen.spec.Ben Pfaff2012-03-021-3/+3
| | | | | | | | | Commands in Makefiles have to begin with a hard tab, otherwise they are ignored, which is what happened here. Fixes "make distcheck". Signed-off-by: Ben Pfaff <blp@nicira.com>
* xenserver: Restart ovs-xapi-sync on kmod reload.Ethan Jackson2012-02-291-7/+14
| | | | | | | | | | | Some users never restart OVS, they just reload the kernel module on each new version. Since ovs-xapi-sync is a daemon, a restart is required to use the new code. Therefore, without this patch, users could unwittingly use stale versions of ovs-xapi-sync. Bug #9919. Signed-off-by: Ethan Jackson <ethan@nicira.com> Diagnosed-by: Ben Pfaff <blp@nicira.com>
* xenserver: Always update the bridge ID in ovs-xapi-sync.Ethan Jackson2012-02-291-3/+2
| | | | | | | | In some cases we were seeing this column get stale. Bug #9929. Signed-off-by: Ethan Jackson <ethan@nicira.com> Diagnosed-by: Justin Pettit <jpettit@nicira.com>
View Lorry Controller Status