From 09995ba1240576ff028721d90432923588e585a0 Mon Sep 17 00:00:00 2001 From: Alin Serdean Date: Mon, 28 Nov 2016 14:11:57 +0000 Subject: datapath-windows: null comparison for icmp and tcp header This patch checks if the TCP or ICMP header exists before trying to use them. The issue was found using the driver under low resources. Signed-off-by: Alin Gabriel Serdean Acked-by: Sairam Venugopal Signed-off-by: Gurucharan Shetty --- datapath-windows/ovsext/Conntrack.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'datapath-windows/ovsext/Conntrack.c') diff --git a/datapath-windows/ovsext/Conntrack.c b/datapath-windows/ovsext/Conntrack.c index e663c3b1d..56a7cbc82 100644 --- a/datapath-windows/ovsext/Conntrack.c +++ b/datapath-windows/ovsext/Conntrack.c @@ -194,7 +194,7 @@ OvsCtEntryCreate(PNET_BUFFER_LIST curNbl, TCPHdr tcpStorage; const TCPHdr *tcp; tcp = OvsGetTcp(curNbl, l4Offset, &tcpStorage); - if (!OvsConntrackValidateTcpPacket(tcp)) { + if (!tcp || !OvsConntrackValidateTcpPacket(tcp)) { goto invalid; } @@ -215,7 +215,7 @@ OvsCtEntryCreate(PNET_BUFFER_LIST curNbl, ICMPHdr storage; const ICMPHdr *icmp; icmp = OvsGetIcmp(curNbl, l4Offset, &storage); - if (!OvsConntrackValidateIcmpPacket(icmp)) { + if (!icmp || !OvsConntrackValidateIcmpPacket(icmp)) { goto invalid; } -- cgit v1.2.1