From 18b19ad911702dcaa861368f1bb059ed5e84ae31 Mon Sep 17 00:00:00 2001 From: Sorin Vinturis Date: Fri, 19 Jun 2015 16:33:56 +0000 Subject: datapath-windows: Initialize reference count when enabling extension When the extension is initialized the global reference count, used for preventing early deallocation of the switch extension, is set to 1. Enabling and then disabling the extension leaves the latter reference count to zero. Because of this the switch context fails to be acquired, i.e OvsAcquireSwitchContext returns zero, and that affects driver's communication to the userspace. The solution is to initialize the reference count each time the extension is enabled. Signed-off-by: Sorin Vinturis Reported-by: Nithin Raju Reported-at: https://github.com/openvswitch/ovs-issues/issues/86 Acked-by: Nithin Raju Signed-off-by: Gurucharan Shetty --- datapath-windows/ovsext/Switch.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'datapath-windows/ovsext/Switch.c') diff --git a/datapath-windows/ovsext/Switch.c b/datapath-windows/ovsext/Switch.c index 99a306d26..f176fa09f 100644 --- a/datapath-windows/ovsext/Switch.c +++ b/datapath-windows/ovsext/Switch.c @@ -46,7 +46,7 @@ extern PDEVICE_OBJECT gOvsDeviceObject; * Reference count used to prevent premature deallocation of the global switch * context structure, gOvsSwitchContext. */ -volatile LONG gOvsSwitchContextRefCount = 1; +volatile LONG gOvsSwitchContextRefCount = 0; static NDIS_STATUS OvsCreateSwitch(NDIS_HANDLE ndisFilterHandle, POVS_SWITCH_CONTEXT *switchContextOut); @@ -137,6 +137,7 @@ OvsExtAttach(NDIS_HANDLE ndisFilterHandle, switchContext->controlFlowState = OvsSwitchAttached; switchContext->dataFlowState = OvsSwitchPaused; + gOvsSwitchContextRefCount = 1; gOvsSwitchContext = switchContext; KeMemoryBarrier(); -- cgit v1.2.1