From 960b789f59690c9d59f20473962c61a0f8b38176 Mon Sep 17 00:00:00 2001 From: Alin Serdean Date: Mon, 6 Nov 2017 17:33:35 +0200 Subject: datapath-windows: Vport check RtlStringCbLengthW return value The result of `RtlStringCbLengthW` is not currently checked and triggers a warning using the WDK 8.1 static analysis. This patch treats the result of `RtlStringCbLengthW`. Signed-off-by: Alin Gabriel Serdean Acked-by: Shashank Ram --- datapath-windows/ovsext/Vport.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) (limited to 'datapath-windows/ovsext') diff --git a/datapath-windows/ovsext/Vport.c b/datapath-windows/ovsext/Vport.c index 075f4199a..7cf2497e3 100644 --- a/datapath-windows/ovsext/Vport.c +++ b/datapath-windows/ovsext/Vport.c @@ -1144,8 +1144,13 @@ GetNICAlias(PNDIS_SWITCH_NIC_PARAMETERS nicParam, if (status == STATUS_SUCCESS) { RtlStringCbPrintfW(portFriendlyName->String, IF_MAX_STRING_SIZE, L"%s", interfaceName); - RtlStringCbLengthW(portFriendlyName->String, IF_MAX_STRING_SIZE, - &len); + status = RtlStringCbLengthW(portFriendlyName->String, + IF_MAX_STRING_SIZE, &len); + if (!NT_SUCCESS(status)) { + OVS_LOG_ERROR("Failed to get the length of the string," + "status: %x", status); + return status; + } portFriendlyName->Length = (USHORT)len; } else { OVS_LOG_ERROR("Fail to convert interface LUID to alias, status: %x", -- cgit v1.2.1