From 0770429e38f49df374f6c337f4969504a97ab1b2 Mon Sep 17 00:00:00 2001 From: Ilya Maximets Date: Tue, 30 Jul 2019 17:00:06 +0300 Subject: dpif-netlink: Allow offloading of flows with dl_type 0x1234. 'dpif_probe_feature()' always has DPIF_FP_PROBE flag set. Other probing code uses dpif_execute() with DPIF_OP_EXECUTE, hence never calls parse_flow_put(). Thus, this 'if' statement is wrong and should be removed as it only forbids offloading of the real legitimate flows with dl_type 0x1234. Dummy flows never reach this code. CC: Paul Blakey Fixes: 8b668ee3f0cc ("dpif-netlink: Use netdev flow put api to insert a flow") Reported-by: Eli Britstein Acked-by: Roi Dayan Signed-off-by: Ilya Maximets --- lib/dpif-netlink.c | 5 ----- 1 file changed, 5 deletions(-) (limited to 'lib/dpif-netlink.c') diff --git a/lib/dpif-netlink.c b/lib/dpif-netlink.c index 985a28426..7bc71d6d1 100644 --- a/lib/dpif-netlink.c +++ b/lib/dpif-netlink.c @@ -2005,11 +2005,6 @@ parse_flow_put(struct dpif_netlink *dpif, struct dpif_flow_put *put) return err; } - /* When we try to install a dummy flow from a probed feature. */ - if (match.flow.dl_type == htons(0x1234)) { - return EOPNOTSUPP; - } - in_port = match.flow.in_port.odp_port; dev = netdev_ports_get(in_port, dpif_class); if (!dev) { -- cgit v1.2.1