From 2a638b8d22be66bb631b2273a72cd4c8451de065 Mon Sep 17 00:00:00 2001 From: Alex Wang Date: Fri, 27 Feb 2015 09:07:18 -0800 Subject: test-hash: Remove the check_word_hash() for hash_bytes128_cb. The original test fails on big-endian system due to the hash function performing not as well when input is uint32_t. In reality, users should only use hash_bytes128() to hash words larger than 128 bits (e.g. struct flow). Besides, we do check the 1-bit set case for 16 128-bit words in following test case. Therefore, the cleanest way to fix the failure in big-endian system seems to be just removing the check_word_hash() test for hash_bytes128_cb. Signed-off-by: Alex Wang Acked-by: Ben Pfaff --- lib/hash.h | 1 + 1 file changed, 1 insertion(+) (limited to 'lib/hash.h') diff --git a/lib/hash.h b/lib/hash.h index 9253760b5..65c52b986 100644 --- a/lib/hash.h +++ b/lib/hash.h @@ -33,6 +33,7 @@ hash_rot(uint32_t x, int k) } uint32_t hash_bytes(const void *, size_t n_bytes, uint32_t basis); +/* The hash input must be a word larger than 128 bits. */ void hash_bytes128(const void *_, size_t n_bytes, uint32_t basis, ovs_u128 *out); -- cgit v1.2.1