From 24f8381214966e90819bf4a9ecabf076cbfc1b08 Mon Sep 17 00:00:00 2001 From: Jarno Rajahalme Date: Mon, 7 Jul 2014 13:18:46 -0700 Subject: Use ovs_refcount_unref_relaxed. After a quick analysis, in most cases the access to refcounted objects is clearly protected either with an explicit lock/mutex, or RCU. there are only a few places where I left a call to ovs_refcount_unref(). Upon closer analysis it may well be that those could also use the relaxed form. Signed-off-by: Jarno Rajahalme Acked-by: Ben Pfaff --- lib/lacp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'lib/lacp.c') diff --git a/lib/lacp.c b/lib/lacp.c index 0d30e518b..3b50d46fe 100644 --- a/lib/lacp.c +++ b/lib/lacp.c @@ -251,7 +251,7 @@ lacp_ref(const struct lacp *lacp_) void lacp_unref(struct lacp *lacp) OVS_EXCLUDED(mutex) { - if (lacp && ovs_refcount_unref(&lacp->ref_cnt) == 1) { + if (lacp && ovs_refcount_unref_relaxed(&lacp->ref_cnt) == 1) { struct slave *slave, *next; lacp_lock(); -- cgit v1.2.1