From 9b7dde9ae07dfbfddba2528751e00c4e7e66c56a Mon Sep 17 00:00:00 2001 From: Ilya Maximets Date: Wed, 20 Jun 2018 10:44:51 +0300 Subject: rconn: Suppress 'connected' log for unreliable connections. Recent assertion failure fix changed rconn workflow for unreliable connections (such as connections from ovs-ofctl) from |rconn|DBG|br-int<->unix#151: entering ACTIVE |rconn|DBG|br-int<->unix#151: connection closed by peer |rconn|DBG|br-int<->unix#151: entering DISCONNECTED To |rconn|DBG|br-int<->unix#200: entering CONNECTING |rconn|INFO|br-int<->unix#200: connected |rconn|DBG|br-int<->unix#200: entering ACTIVE |rconn|DBG|br-int<->unix#200: connection closed by peer |rconn|DBG|br-int<->unix#200: entering DISCONNECTED Many monitoring/configuring tools (ex. ovs-neutron-agent) uses ovs-ofctl frequently to check the statuses of installed flows. This produces a lot of "connected" logs, that are useless in general. Fix that by changing the log level to DBG for unreliable connections. Suggested-by: Ben Pfaff Fixes: c9a9b9b00bf5 ("rconn: Introduce new invariant to fix assertion failure in corner case.") Signed-off-by: Ilya Maximets Signed-off-by: Ben Pfaff --- lib/rconn.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'lib') diff --git a/lib/rconn.c b/lib/rconn.c index a3f811fed..3fabc504f 100644 --- a/lib/rconn.c +++ b/lib/rconn.c @@ -511,7 +511,7 @@ run_CONNECTING(struct rconn *rc) { int retval = vconn_connect(rc->vconn); if (!retval) { - VLOG_INFO("%s: connected", rc->name); + VLOG(rc->reliable ? VLL_INFO : VLL_DBG, "%s: connected", rc->name); rc->n_successful_connections++; state_transition(rc, S_ACTIVE); rc->version = vconn_get_version(rc->vconn); -- cgit v1.2.1