From 43898d4c72219eb9c0d4e7ee5c421380251f080d Mon Sep 17 00:00:00 2001 From: William Tu Date: Tue, 28 Jun 2016 22:02:28 -0700 Subject: ovsdb: Fix dead assignment reported by clang. Clang reports variable 'error' never been used. Fix by returning error when table_update->type != JSON_OBJECT. Signed-off-by: William Tu Signed-off-by: Ben Pfaff --- ovsdb/replication.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'ovsdb/replication.c') diff --git a/ovsdb/replication.c b/ovsdb/replication.c index 3d1bc332c..a267a3a00 100644 --- a/ovsdb/replication.c +++ b/ovsdb/replication.c @@ -468,8 +468,8 @@ process_table_update(struct json *table_update, const char *table_name, struct ovsdb_error *error; if (table_update->type != JSON_OBJECT) { - error = ovsdb_error("Not a JSON object", - " for table is not object"); + return ovsdb_error("Not a JSON object", + " for table is not object"); } table = ovsdb_get_table(database, table_name); -- cgit v1.2.1