From 63ae068ebf3d0ff7e3cb8d810ef87766187b7821 Mon Sep 17 00:00:00 2001 From: Ben Pfaff Date: Fri, 26 May 2017 16:03:54 -0700 Subject: ovs-ofctl: Close pcap file at end of ofctl_ofp_parse_pcap(). Seem wise even if not mandatory. Found by Coverity. Reported-at: https://scan3.coverity.com/reports.htm#v16889/p10449/fileInstanceId=14763047&defectInstanceId=4305314&mergedDefectId=180420 Signed-off-by: Ben Pfaff Acked-by: Justin Pettit --- utilities/ovs-ofctl.c | 1 + 1 file changed, 1 insertion(+) (limited to 'utilities/ovs-ofctl.c') diff --git a/utilities/ovs-ofctl.c b/utilities/ovs-ofctl.c index 90043bf41..dca9be3a5 100644 --- a/utilities/ovs-ofctl.c +++ b/utilities/ovs-ofctl.c @@ -2591,6 +2591,7 @@ ofctl_ofp_parse_pcap(struct ovs_cmdl_context *ctx) dp_packet_delete(packet); } tcp_reader_close(reader); + fclose(file); } static void -- cgit v1.2.1