diff options
author | Vladislav Grishenko <themiron@users.noreply.github.com> | 2020-05-29 18:26:22 +0500 |
---|---|---|
committer | GitHub <noreply@github.com> | 2020-05-29 21:26:22 +0800 |
commit | b0243b0e7bdb5fc0e5111abc8ec6698522309c3f (patch) | |
tree | 25f1979d834d80a139dc2dfbf334d9d9735ecc9a | |
parent | 4faf06aae794a5b720fd3653ae2870e639a264fd (diff) | |
download | dropbear-b0243b0e7bdb5fc0e5111abc8ec6698522309c3f.tar.gz |
Fix ChaCha20 on 32-bit platforms (#99)
* Fix ChaCha20 on 32-bit platforms
On 32-bit platforms with old compiler STORE64H() parameter is
not auto-expanded to 64-bit value, causing wrong IV data.
Spotted on BCM4706 MIPS32r2 with GCC 4.2.4:
Exit before auth: Integrity error (bad packet size 2065808956)
* Fix Chacha20-Poly1305 and AES-GCM debug messages
Functions were renamed earlier and trace messages - not.
-rw-r--r-- | chachapoly.c | 8 | ||||
-rw-r--r-- | gcm.c | 4 |
2 files changed, 6 insertions, 6 deletions
diff --git a/chachapoly.c b/chachapoly.c index 8fb06c5..c065fac 100644 --- a/chachapoly.c +++ b/chachapoly.c @@ -82,7 +82,7 @@ static int dropbear_chachapoly_crypt(unsigned int seq, return CRYPT_ERROR; } - STORE64H(seq, seqbuf); + STORE64H((uint64_t)seq, seqbuf); chacha_ivctr64(&state->chacha, seqbuf, sizeof(seqbuf), 0); if ((err = chacha_keystream(&state->chacha, key, sizeof(key))) != CRYPT_OK) { return err; @@ -122,13 +122,13 @@ static int dropbear_chachapoly_getlength(unsigned int seq, unsigned char seqbuf[8], buf[4]; int err; - TRACE2(("enter dropbear_chachapoly_parse")) + TRACE2(("enter dropbear_chachapoly_getlength")) if (len < sizeof(buf)) { return CRYPT_ERROR; } - STORE64H(seq, seqbuf); + STORE64H((uint64_t)seq, seqbuf); chacha_ivctr64(&state->header, seqbuf, sizeof(seqbuf), 0); if ((err = chacha_crypt(&state->header, in, sizeof(buf), buf)) != CRYPT_OK) { return err; @@ -136,7 +136,7 @@ static int dropbear_chachapoly_getlength(unsigned int seq, LOAD32H(*outlen, buf); - TRACE2(("leave dropbear_chachapoly_parse")) + TRACE2(("leave dropbear_chachapoly_getlength")) return CRYPT_OK; } @@ -100,7 +100,7 @@ static int dropbear_gcm_crypt(unsigned int UNUSED(seq), static int dropbear_gcm_getlength(unsigned int UNUSED(seq), const unsigned char *in, unsigned int *outlen, unsigned long len, dropbear_gcm_state* UNUSED(state)) { - TRACE2(("enter dropbear_gcm_parse")) + TRACE2(("enter dropbear_gcm_getlength")) if (len < 4) { return CRYPT_ERROR; @@ -108,7 +108,7 @@ static int dropbear_gcm_getlength(unsigned int UNUSED(seq), LOAD32H(*outlen, in); - TRACE2(("leave dropbear_gcm_parse")) + TRACE2(("leave dropbear_gcm_getlength")) return CRYPT_OK; } |