From ebf7e9028f2facf1a87c56dd261bda82ab9bcc59 Mon Sep 17 00:00:00 2001 From: Christian Marangi Date: Sun, 17 Jul 2022 11:44:24 +0200 Subject: libfstools: handle gzip return value in block_volume_format Fix the following compilation warning: libfstools/common.c: In function 'block_volume_format': libfstools/common.c:120:17: error: ignoring return value of 'system' declared with attribute 'warn_unused_result' [-Werror=unused-result] 120 | system(str); | ^~~~~~~~~~~ Correctly handle return value from gzip and print an error on such case. Signed-off-by: Christian Marangi --- libfstools/common.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libfstools/common.c b/libfstools/common.c index 1b22d2c..55c1b87 100644 --- a/libfstools/common.c +++ b/libfstools/common.c @@ -117,7 +117,11 @@ int block_volume_format(struct volume *v, uint64_t offset, const char *bdev) switch (volume_identify(v)) { case FS_TARGZ: snprintf(str, sizeof(str), "gzip -cd %s > /tmp/sysupgrade.tar", v->blk); - system(str); + ret = system(str); + if (ret < 0) { + ULOG_ERR("failed extracting %s\n", v->blk); + break; + } /* fall-through */ case FS_NONE: ULOG_INFO("overlay filesystem in %s has not been formatted yet\n", v->blk); -- cgit v1.2.1