From 7c942bffdd21f52ad6273c73d5bd2868283f3c42 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= Date: Tue, 16 Jul 2019 11:41:16 +0200 Subject: luci2: initialize package pointers to NULL MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit uci_load() does not guarantee setting passed pointer to NULL on error. It could result in using uninitialized pointed & crash. Signed-off-by: Rafał Miłecki --- luci2/src/rpcd/luci2.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/luci2/src/rpcd/luci2.c b/luci2/src/rpcd/luci2.c index c8ef9bf..7c37144 100644 --- a/luci2/src/rpcd/luci2.c +++ b/luci2/src/rpcd/luci2.c @@ -217,7 +217,7 @@ rpc_luci2_system_log(struct ubus_context *ctx, struct ubus_object *obj, int logsize = 0; const char *logfile = NULL; struct stat st; - struct uci_package *p; + struct uci_package *p = NULL; struct uci_element *e; struct uci_section *s; struct uci_ptr ptr = { .package = "system" }; @@ -1235,7 +1235,7 @@ static FILE * dnsmasq_leasefile(void) { FILE *leases = NULL; - struct uci_package *p; + struct uci_package *p = NULL; struct uci_element *e; struct uci_section *s; struct uci_ptr ptr = { -- cgit v1.2.1