summaryrefslogtreecommitdiff
path: root/device.h
diff options
context:
space:
mode:
authorStijn Tintel <stijn@linux-ipv6.be>2022-12-08 00:57:08 +0200
committerStijn Tintel <stijn@linux-ipv6.be>2022-12-08 00:57:08 +0200
commit02ada7a28b9390625d29aad6308f623df930342a (patch)
tree7a508b08ad81c5976343c7685a1c700ee8e395fd /device.h
parent86586994c97ca99d2da57224575d4a28760725e2 (diff)
downloadnetifd-staging/stintel/ifnamsiz.tar.gz
treewide: fix use of IFNAMSIZstaging/stintel/ifnamsiz
IFNAMSIZ already includes an extra byte for the null character terminating the string. Adding an extra byte can cause the interface name to be truncated, resulting in undefined behaviour. Drop the extra byte. For the bonding case, the interface name written to sysfs should be prefixed with + or - so we do need an extra byte. Signed-off-by: Stijn Tintel <stijn@linux-ipv6.be>
Diffstat (limited to 'device.h')
-rw-r--r--device.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/device.h b/device.h
index 37f8c37..6751628 100644
--- a/device.h
+++ b/device.h
@@ -219,7 +219,7 @@ struct device {
struct vlist_tree vlans;
struct kvlist vlan_aliases;
- char ifname[IFNAMSIZ + 1];
+ char ifname[IFNAMSIZ];
int ifindex;
struct blob_attr *config;