diff options
author | Stijn Tintel <stijn@linux-ipv6.be> | 2022-12-08 00:57:08 +0200 |
---|---|---|
committer | Stijn Tintel <stijn@linux-ipv6.be> | 2022-12-08 00:57:08 +0200 |
commit | 02ada7a28b9390625d29aad6308f623df930342a (patch) | |
tree | 7a508b08ad81c5976343c7685a1c700ee8e395fd /iprule.h | |
parent | 86586994c97ca99d2da57224575d4a28760725e2 (diff) | |
download | netifd-staging/stintel/ifnamsiz.tar.gz |
treewide: fix use of IFNAMSIZstaging/stintel/ifnamsiz
IFNAMSIZ already includes an extra byte for the null character
terminating the string. Adding an extra byte can cause the interface
name to be truncated, resulting in undefined behaviour.
Drop the extra byte. For the bonding case, the interface name written to
sysfs should be prefixed with + or - so we do need an extra byte.
Signed-off-by: Stijn Tintel <stijn@linux-ipv6.be>
Diffstat (limited to 'iprule.h')
-rw-r--r-- | iprule.h | 4 |
1 files changed, 2 insertions, 2 deletions
@@ -77,8 +77,8 @@ struct iprule { struct interface_user out_iface_user; /* device name */ - char in_dev[IFNAMSIZ + 1]; - char out_dev[IFNAMSIZ + 1]; + char in_dev[IFNAMSIZ]; + char out_dev[IFNAMSIZ]; /* everything below is used as avl tree key */ /* don't change the order */ |