diff options
author | Hauke Mehrtens <hauke@hauke-m.de> | 2023-02-12 21:07:31 +0100 |
---|---|---|
committer | Hauke Mehrtens <hauke@hauke-m.de> | 2023-02-19 16:08:28 +0100 |
commit | 19372d8528d25d9774c1c6ede2642bdf57ce3cc3 (patch) | |
tree | d7bdc939ff703af66c9b884d9f28dab1ce0bc2df /ubus.c | |
parent | ed65a00adc751d102c2041a4a9a32df9dad52b9e (diff) | |
download | netifd-19372d8528d25d9774c1c6ede2642bdf57ce3cc3.tar.gz |
netifd: Fix multiple -Wsign-compare warnings
This fixes warnings like this:
warning: comparison of integer expressions of different signedness: 'int' and 'long unsigned int' [-Wsign-compare]
Mostly this was an int compared to a size_t returned by ARRAY_SIZE().
The easiest fix is to count on the size_t type.
The ifindex is sometimes an unsigned int and sometimes a signed int in
the kernel interfaces. I think it normally fits into an unsigned 16 bit
value, so this should be fine. Do the one comparison where the
compiler complains as a long.
Casting the result of sizeof() to int should be safe. These values are
never out of range of int.
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
Diffstat (limited to 'ubus.c')
-rw-r--r-- | ubus.c | 4 |
1 files changed, 2 insertions, 2 deletions
@@ -1132,7 +1132,7 @@ netifd_handle_iface(struct ubus_context *ctx, struct ubus_object *obj, { struct interface *iface; struct blob_attr *tb; - int i; + size_t i; blobmsg_parse(&iface_policy, 1, &tb, blob_data(msg), blob_len(msg)); if (!tb) @@ -1158,7 +1158,7 @@ netifd_handle_iface(struct ubus_context *ctx, struct ubus_object *obj, static void netifd_add_iface_object(void) { struct ubus_method *methods; - int i; + size_t i; methods = calloc(1, sizeof(iface_object_methods)); if (!methods) |