treewide: fix use of IFNAMSIZstaging/stintel/ifnamsiz

IFNAMSIZ already includes an extra byte for the null character
terminating the string. Adding an extra byte can cause the interface
name to be truncated, resulting in undefined behaviour.

Drop the extra byte. For the bonding case, the interface name written to
sysfs should be prefixed with + or - so we do need an extra byte.

Signed-off-by: Stijn Tintel <stijn@linux-ipv6.be>

1 files changed, 2 insertions, 2 deletions

diff --git a/vlan.c b/vlan.c
index 23b20a9..3d444a9 100644
--- a/vlan.c
+++ b/vlan.c
@@ -128,7 +128,7 @@ static int vlan_set_device_state(struct device *dev, bool up)
 
 static void vlan_dev_cb(struct device_user *dep, enum device_event ev)
 {
-	char name[IFNAMSIZ + 1];
+	char name[IFNAMSIZ];
 	struct vlan_device *vldev;
 
 	vldev = container_of(dep, struct vlan_device, dep);
@@ -175,7 +175,7 @@ static struct device *get_vlan_device(struct device *dev, char *id_str, bool cre
 	};
 	struct vlan_device *vldev;
 	struct device_user *dep;
-	char name[IFNAMSIZ + 1];
+	char name[IFNAMSIZ];
 	char *err = NULL;
 	int id, *alias_id;