From 60293a7a3656aab8c10f2d1827d1da88ad46d32c Mon Sep 17 00:00:00 2001 From: Alexander Couzens Date: Fri, 29 Jun 2018 04:30:13 +0200 Subject: replace fall throughs in switch/cases where possible with simple code changes fall throughs are usually error-prone, especially when someone else extend it. Signed-off-by: Alexander Couzens Acked-by: Hans Dedecker --- alias.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) (limited to 'alias.c') diff --git a/alias.c b/alias.c index 649f2d1..3b14b87 100644 --- a/alias.c +++ b/alias.c @@ -87,19 +87,20 @@ alias_device_set_state(struct device *dev, bool state) static void alias_device_cb(struct device_user *dep, enum device_event ev) { struct alias_device *alias; - bool new_state = false; alias = container_of(dep, struct alias_device, dep); switch (ev) { case DEV_EVENT_ADD: - new_state = true; + device_set_present(&alias->dev, true); + break; case DEV_EVENT_REMOVE: - device_set_present(&alias->dev, new_state); + device_set_present(&alias->dev, false); break; case DEV_EVENT_LINK_UP: - new_state = true; + device_set_link(&alias->dev, true); + break; case DEV_EVENT_LINK_DOWN: - device_set_link(&alias->dev, new_state); + device_set_link(&alias->dev, false); break; case DEV_EVENT_UPDATE_IFINDEX: device_set_ifindex(&alias->dev, dep->dev->ifindex); -- cgit v1.2.1