From 5d655d1d3f6880b53ea5bafda159c02da038548f Mon Sep 17 00:00:00 2001 From: Hans Dedecker Date: Wed, 18 Jun 2014 05:55:47 +0000 Subject: netifd: Check device_claim return code in all cases Fixes observed issue a tunnel interface is reported as up although device_claim failed Signed-off-by: Hans Dedecker --- proto-shell.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'proto-shell.c') diff --git a/proto-shell.c b/proto-shell.c index c4039ed..9fad3a0 100644 --- a/proto-shell.c +++ b/proto-shell.c @@ -463,7 +463,9 @@ proto_shell_update_link(struct proto_shell_state *state, struct blob_attr *data, return UBUS_STATUS_INVALID_ARGUMENT; interface_set_l3_dev(iface, dev); - device_claim(&iface->l3_dev); + if (device_claim(&iface->l3_dev) < 0) + return UBUS_STATUS_UNKNOWN_ERROR; + device_set_present(dev, true); interface_update_start(iface); -- cgit v1.2.1