From 5a4ac30c7a15712d01110befec1acfe86c2cbed0 Mon Sep 17 00:00:00 2001 From: Felix Fietkau Date: Mon, 27 Sep 2021 18:56:21 +0200 Subject: netifd: rework/fix device free handling Instead of explicitly preventing free in specific code sections using device_lock/device_unlock, defer all device free handling via uloop timeout This avoids an entire class of lurking use-after-free bugs triggered by device event processing and simplifies the code Signed-off-by: Felix Fietkau --- ubus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'ubus.c') diff --git a/ubus.c b/ubus.c index 56cce81..4770cb6 100644 --- a/ubus.c +++ b/ubus.c @@ -291,7 +291,7 @@ netifd_handle_alias(struct ubus_context *ctx, struct ubus_object *obj, return 0; error: - device_free_unused(dev); + device_free_unused(); return UBUS_STATUS_INVALID_ARGUMENT; } -- cgit v1.2.1