From 773e8da41532b23888511cd864fbd251ecadc577 Mon Sep 17 00:00:00 2001 From: Nick Hainke Date: Tue, 31 Aug 2021 11:09:19 +0200 Subject: initd: fix off-by-one error in mkdev.c Substract 1 from bufsize so len can not be out of bounds. Same hanling as in "udevtrigger.c" in "sysfs_resolve_link". Replaces: 8eb1d783 Coverity CID: 1330087 Readlink used insecurely Signed-off-by: Nick Hainke --- initd/mkdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/initd/mkdev.c b/initd/mkdev.c index 44101aa..f0a1e84 100644 --- a/initd/mkdev.c +++ b/initd/mkdev.c @@ -82,7 +82,7 @@ static void find_devs(bool block) continue; strcpy(path, dp->d_name); - len = readlink(buf2, buf, sizeof(buf)); + len = readlink(buf2, buf, sizeof(buf) - 1); if (len <= 0) continue; -- cgit v1.2.1