From 4c7b720b9c63b826fb9404e454ae54f2ef5649d5 Mon Sep 17 00:00:00 2001 From: Rosen Penev Date: Mon, 18 Jul 2022 15:12:38 -0700 Subject: kmodloader: fix GCC fanalyzer warnings memory leaks and missing NULL checks. Signed-off-by: Rosen Penev --- kmodloader.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/kmodloader.c b/kmodloader.c index 4b2ffa7..b2e7a8b 100644 --- a/kmodloader.c +++ b/kmodloader.c @@ -336,6 +336,11 @@ static int scan_loaded_modules(void) /* possibly a module outside /lib/modules// */ n = alloc_module(m.name, NULL, 0, m.depends, m.size); } + if (!n) { + ULOG_ERR("Failed to allocate memory for module\n"); + return -1; + } + n->usage = m.usage; n->state = LOADED; } @@ -583,6 +588,11 @@ static int insert_module(char *path, const char *options) struct stat s; int fd, ret = -1; + if (!path) { + ULOG_ERR("Path not specified\n"); + return ret; + } + if (stat(path, &s)) { ULOG_ERR("missing module %s\n", path); return ret; @@ -1164,6 +1174,8 @@ load_options(void) continue; } } + + fclose(f); } int main(int argc, char **argv) -- cgit v1.2.1