diff options
author | Yousong Zhou <yszhou4tech@gmail.com> | 2015-01-24 23:07:53 +0800 |
---|---|---|
committer | Felix Fietkau <nbd@openwrt.org> | 2015-01-24 20:46:48 +0100 |
commit | 790d30606d545956a64f183c3199f472a70a6385 (patch) | |
tree | af63d6f92edd6b5c3ffb86bbb22acda2602893d2 | |
parent | 3e26ec5716e8b23706bbb566b136eb06138ad978 (diff) | |
download | uci-790d30606d545956a64f183c3199f472a70a6385.tar.gz |
Add a few notes on the return value of uci_lookup_ptr().
While at it, use UCI_OK instead of literal integer 0 for return value of
uci_lookup_ptr().
Signed-off-by: Yousong Zhou <yszhou4tech@gmail.com>
-rw-r--r-- | list.c | 5 | ||||
-rw-r--r-- | uci.h | 7 |
2 files changed, 10 insertions, 2 deletions
@@ -431,11 +431,12 @@ uci_lookup_ptr(struct uci_context *ctx, struct uci_ptr *ptr, char *str, bool ext complete: ptr->flags |= UCI_LOOKUP_COMPLETE; abort: - return 0; + return UCI_OK; notfound: UCI_THROW(ctx, UCI_ERR_NOTFOUND); - return 0; + /* not a chance here */ + return UCI_ERR_NOTFOUND; } __private struct uci_element * @@ -154,6 +154,13 @@ extern int uci_unload(struct uci_context *ctx, struct uci_package *p); * Note: uci_lookup_ptr will automatically load a config package if necessary * @str must not be constant, as it will be modified and used for the strings inside @ptr, * thus it must also be available as long as @ptr is in use. + * + * This function returns UCI_ERR_NOTFOUND if the package specified in the tuple + * string cannot be found. Otherwise it will return UCI_OK. + * + * Note that failures in looking up other parts, if they are also specfied, + * including section and option, will also have a return value UCI_OK but with + * ptr->flags * UCI_LOOKUP_COMPLETE not set. */ extern int uci_lookup_ptr(struct uci_context *ctx, struct uci_ptr *ptr, char *str, bool extended); |