| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When the whitespace job was added, we marked it with
only: merge_requests
because we wanted it to only run on new merge requests.
However, adding an `only` clause like this disables all the
unmarked jobs for merge requests, which means we don't get
the more important feedback about build failures.
Instead, use the `rules` key, added in Gitlab 12.3. This
more flexible mechanism is currently recommended and lets
us specify what we want without having to add additional
decorations to every other job.
|
|
|
|
|
|
|
|
| |
There is a small typo in celt/fixed_generic.h.
Should read `nearest` rather than `neareast`.
Signed-off-by: Ralph Giles <giles@thaumas.net>
|
|
|
|
|
|
|
|
|
|
|
| |
meson.source_root() and meson.build_root() have been deprecated in
latest Meson release because they are a trap. They point to the root of
parent project instead of root of current subproject. Meson 0.56.0 added
meson.project_source/build_root() but it is just as easy to use
meson.current_source/build_dir() in the root meson.build file and avoids
bumping required meson version.
Signed-off-by: Ralph Giles <giles@thaumas.net>
|
|
|
|
| |
Signed-off-by: Ralph Giles <giles@thaumas.net>
|
|
|
|
| |
Signed-off-by: Ralph Giles <giles@thaumas.net>
|
|
|
|
| |
Signed-off-by: Ralph Giles <giles@thaumas.net>
|
|
|
|
| |
Signed-off-by: Ralph Giles <giles@thaumas.net>
|
|
|
|
| |
Signed-off-by: Ralph Giles <giles@thaumas.net>
|
|
|
|
|
|
|
|
| |
This is required for Windows because it doesn't have RPATH,
thus it fails to find Opus if it's not in the same directory
as the executables or in PATH.
Signed-off-by: Ralph Giles <giles@thaumas.net>
|
|
|
|
|
|
|
| |
This is required in case the output path for tests is changed
by a project adding Opus as submodule.
Signed-off-by: Ralph Giles <giles@thaumas.net>
|
|
|
|
| |
Signed-off-by: Ralph Giles <giles@thaumas.net>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Tested on:
- Linux/x86* with gcc
- Android armv7 arm64 x86 x86_64 with clang
- Windows x86 x86_64 with Visual Studio 2017
- Windows x86 x86_64 with MinGW
- macOS x86_64 with clang
- iOS arm64 x86_64 with clang
Co-authored by: Nirbheek Chauhan <nirbheek@centricular.com>
https://gitlab.xiph.org/xiph/opus/-/merge_requests/13
|
|
|
|
|
|
| |
Specify the precision as float to avoid truncating from double.
Signed-off-by: Mark Harris <mark.hsj@gmail.com>
|
|
|
|
|
|
|
|
|
|
|
| |
Actually check for read errors instead of just storing the
return value in a variable that then never gets checked.
Also fixes "conversion from 'size_t' to 'int', possible loss
of data" compiler warnings on Windows with MSVC caused by
storing the size_t returned by fread() into an int variable.
Signed-off-by: Mark Harris <mark.hsj@gmail.com>
|
|
|
|
|
|
|
|
| |
_WIN32 is defined on all Windows platforms by every compiler that
targets Windows. We do not need WIN32 at all.
Signed-off-by: Mark Harris <mark.hsj@gmail.com>
Resolves https://github.com/xiph/opus/pull/104
|
|
|
|
|
|
| |
This broke 5 years ago in 43120f00758219a784f952754f33b9788a8d731b
Signed-off-by: Mark Harris <mark.hsj@gmail.com>
|
|
|
|
| |
Signed-off-by: Mark Harris <mark.hsj@gmail.com>
|
| |
|
| |
|
| |
|
|
|
|
| |
version parsing
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use a versioned gcc container image for more consistent
test results. This is the same version we're using for
other projects, but of course it will need to be bumped
periodically.
The current gcc release is 10.2. The oldest supported
release is 8.4, so this is in the middle of the support
window.
Signed-off-by: Marvin Scholz <epirat07@gmail.com>
|
|
|
|
|
|
| |
.. just like the way it is done in celt/x86/x86cpu.c.
Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>
|
|
|
|
| |
Use the fuzzed sub-length of the input data instead of the whole input.
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The autotools build doesn't set OPUS_HAVE_RTCD for arm targets,
assuming all the supported intrinsics will work on the runtime
cpu.
The cmake build however defines this by default when the neon
extension is available on the target. On Linux, the runtime
cpu detection reads /proc/cpuinfo, so removing stdio.h from
celt/os_support.h meant that the cmake build for arm targets
failed.
We don't currently have ci runs for that configuration, so
this only became apparent through manual testing.
Signed-off-by: Marcus Asteborg <maastebo@microsoft.com>
Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>
|
|
|
|
| |
Signed-off-by: Ralph Giles <giles@thaumas.net>
|
|
|
|
| |
Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>
|
| |
|
|
|
|
|
|
|
| |
Add newer source directories to the destdir file tree so we
can include all sources referenced from opus_sources.mk.
Signed-off-by: Ralph Giles <giles@thaumas.net>
|
|
|
|
|
|
|
|
| |
[[ ]], the compound command is not supported by all
shell interpreter. [ ], the buildin command is more
common.
Signed-off-by: Ralph Giles <giles@thaumas.net>
|
|
|
|
| |
Signed-off-by: Mark Harris <mark.hsj@gmail.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CMAKE_SOURCE_DIR corresponds to the top project's source directory.
CMAKE_BINARY_DIR corresponds to the top project's binary directory.
The usage of these variables doesn't cause any problems when Opus is built as a standalone project.
This is not the case when Opus is added as submodule: the variables are set by the project that calls "add_subdirectory()".
The fix consists in using PROJECT_SOURCE_DIR and PROJECT_BINARY_DIR, which always refer to the current project.
Signed-off-by: Mark Harris <mark.hsj@gmail.com>
|
|
|
|
| |
Signed-off-by: Mark Harris <mark.hsj@gmail.com>
|
|
|
|
| |
Signed-off-by: Mark Harris <mark.hsj@gmail.com>
|
|
|
|
| |
Signed-off-by: Mark Harris <mark.hsj@gmail.com>
|
|
|
|
| |
Signed-off-by: Mark Harris <mark.hsj@gmail.com>
|
|
|
|
| |
Signed-off-by: Mark Harris <mark.hsj@gmail.com>
|
|
|
|
| |
Signed-off-by: Mark Harris <mark.hsj@gmail.com>
|
|
|
|
| |
Signed-off-by: Mark Harris <mark.hsj@gmail.com>
|
|
|
|
|
|
|
|
|
| |
This lighter-weight intrinsics header is available starting
with Microsoft Visual Studio 2017, so the previous change
to allow this header failed when building with Visual
Studio 2015.
Restores the appveyor continuous integration build.
|
|
|
|
|
|
| |
remove usage of stdio.h in production code
Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>
|
|
|
|
|
|
| |
in tests.
Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>
|
|
|
|
| |
Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>
|
|
|
|
| |
Signed-off-by: Ralph Giles <giles@thaumas.net>
|
|
|
|
|
|
|
| |
Add doc/trivial_example.c to the autotools build so we get
some minimal verification that the code compiles.
Signed-off-by: Mark Harris <mark.hsj@gmail.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Silence a gcc warning by checking the return value of the fread()
call instead of the feof() guard. This prevents an infinite loop
in the case of a read error. Otherwise, when end-of-file is reached
fread() will certainly return a smaller number of elements read
than requested, so both cases are handled now.
Add a comment to clarify that we're dropping a partial frame on
purpose to keep the code simple.
Also add more braces around conditional bodies for less error-prone
style.
Signed-off-by: Mark Harris <mark.hsj@gmail.com>
|