From a8e2a2b1a8ab2cb9d9e7d4fe21128ac9e769fe4e Mon Sep 17 00:00:00 2001 From: Jean-Marc Valin Date: Wed, 26 Sep 2018 22:57:36 -0400 Subject: Prevent the SILK counter from overflowing after 2 years and 9 months or "just" 1 year and 4 months for 10-ms frames. The overflow can eventually cause a divide-by-zero when counter == -16 Thanks to Dmitry Malinin for reporting the bug. --- silk/VAD.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'silk') diff --git a/silk/VAD.c b/silk/VAD.c index 541e5056..d0cda521 100644 --- a/silk/VAD.c +++ b/silk/VAD.c @@ -312,6 +312,8 @@ void silk_VAD_GetNoiseLevels( /* Initially faster smoothing */ if( psSilk_VAD->counter < 1000 ) { /* 1000 = 20 sec */ min_coef = silk_DIV32_16( silk_int16_MAX, silk_RSHIFT( psSilk_VAD->counter, 4 ) + 1 ); + /* Increment frame counter */ + psSilk_VAD->counter++; } else { min_coef = 0; } @@ -355,7 +357,4 @@ void silk_VAD_GetNoiseLevels( /* Store as part of state */ psSilk_VAD->NL[ k ] = nl; } - - /* Increment frame counter */ - psSilk_VAD->counter++; } -- cgit v1.2.1