diff options
| author | Matthew Barnes <mbarnes@redhat.com> | 2015-09-11 13:15:58 -0400 |
|---|---|---|
| committer | Matthew Barnes <mbarnes@redhat.com> | 2015-09-11 13:19:01 -0400 |
| commit | 2233d443e76ba0557b6c57a76e0668b991003fb9 (patch) | |
| tree | ea1a2487e9e431f8c12257179e8db7c5cb74b038 | |
| parent | bddb25f79e1a95d154b219905988d6f11303f411 (diff) | |
| download | ostree-2233d443e76ba0557b6c57a76e0668b991003fb9.tar.gz | |
commit: Clarify reasoning for "commit-update-summary" default
In case anyone else gets the idea of changing the default for archive-z2
repos. Should have the rationale captured in the source code somewhere.
| -rw-r--r-- | src/ostree/ot-builtin-commit.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/src/ostree/ot-builtin-commit.c b/src/ostree/ot-builtin-commit.c index db3700b2..3176ae93 100644 --- a/src/ostree/ot-builtin-commit.c +++ b/src/ostree/ot-builtin-commit.c @@ -524,6 +524,11 @@ ostree_builtin_commit (int argc, char **argv, GCancellable *cancellable, GError if (!ostree_repo_commit_transaction (repo, &stats, cancellable, error)) goto out; + /* The default for this option is FALSE, even for archive-z2 repos, + * because ostree supports multiple processes committing to the same + * repo (but different refs) concurrently, and in fact gnome-continuous + * actually does this. In that context it's best to update the summary + * explicitly instead of automatically here. */ if (!ot_keyfile_get_boolean_with_default (ostree_repo_get_config (repo), "core", "commit-update-summary", FALSE, &update_summary, error)) |