diff options
| author | Jonathan Lebon <jonathan@jlebon.com> | 2021-03-02 15:24:02 -0500 |
|---|---|---|
| committer | Jonathan Lebon <jonathan@jlebon.com> | 2021-03-02 15:36:27 -0500 |
| commit | 02b61979245e65ab0324ba0b07ea82b384c721d8 (patch) | |
| tree | a64948be564148a05034ebe7ee0ee373fedc3276 | |
| parent | fd9d422c51ce1b761f216f08a9da3776996bc7c7 (diff) | |
| download | ostree-02b61979245e65ab0324ba0b07ea82b384c721d8.tar.gz | |
lib/sysroot: Add comments and debug statements around sysroot parsing
Was looking at this code more closely today to investigate issues
related to bootlink mismatches (#2283).
| -rw-r--r-- | src/libostree/ostree-sysroot.c | 12 |
1 files changed, 11 insertions, 1 deletions
diff --git a/src/libostree/ostree-sysroot.c b/src/libostree/ostree-sysroot.c index e3d7e425..3dec0e53 100644 --- a/src/libostree/ostree-sysroot.c +++ b/src/libostree/ostree-sysroot.c @@ -449,6 +449,7 @@ _ostree_sysroot_parse_deploy_path_name (const char *name, return TRUE; } +/* For a given bootversion, get its subbootversion from `/ostree/boot.$bootversion`. */ gboolean _ostree_sysroot_read_current_subbootversion (OstreeSysroot *self, int bootversion, @@ -465,6 +466,7 @@ _ostree_sysroot_read_current_subbootversion (OstreeSysroot *self, return FALSE; if (errno == ENOENT) { + g_debug ("Didn't find $sysroot/ostree/boot.%d symlink; assuming subbootversion 0", bootversion); *out_subbootversion = 0; } else @@ -516,6 +518,7 @@ compare_loader_configs_for_sorting (gconstpointer a_pp, return compare_boot_loader_configs (a, b); } +/* Read all the bootconfigs from `/boot/loader/`. */ gboolean _ostree_sysroot_read_boot_loader_configs (OstreeSysroot *self, int bootversion, @@ -574,6 +577,7 @@ _ostree_sysroot_read_boot_loader_configs (OstreeSysroot *self, return TRUE; } +/* Get the bootversion from the `/boot/loader` symlink. */ static gboolean read_current_bootversion (OstreeSysroot *self, int *out_bootversion, @@ -587,6 +591,7 @@ read_current_bootversion (OstreeSysroot *self, return FALSE; if (errno == ENOENT) { + g_debug ("Didn't find $sysroot/boot/loader symlink; assuming bootversion 0"); ret_bootversion = 0; } else @@ -698,7 +703,7 @@ parse_deployment (OstreeSysroot *self, return FALSE; g_autofree char *errprefix = - g_strdup_printf ("Parsing deployment %i in stateroot '%s'", treebootserial, osname); + g_strdup_printf ("Parsing deployment %s in stateroot '%s'", boot_link, osname); GLNX_AUTO_PREFIX_ERROR(errprefix, error); const char *relative_boot_link = boot_link; @@ -799,6 +804,8 @@ get_ostree_kernel_arg_from_config (OstreeBootconfigParser *config) return NULL; } +/* From a BLS config, use its ostree= karg to find the deployment it points to and add it to + * the inout_deployments array. */ static gboolean list_deployments_process_one_boot_entry (OstreeSysroot *self, OstreeBootconfigParser *config, @@ -1016,6 +1023,9 @@ _ostree_sysroot_reload_staged (OstreeSysroot *self, return TRUE; } +/* Loads the current bootversion, subbootversion, and deplyments, starting from the + * bootloader configs which are the source of truth. + */ static gboolean sysroot_load_from_bootloader_configs (OstreeSysroot *self, GCancellable *cancellable, |