summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorColin Walters <walters@verbum.org>2021-10-08 08:59:52 -0400
committerColin Walters <walters@verbum.org>2021-10-13 17:13:14 -0400
commita8eed03a1974c285cb7ddf550c7385a4783bb97d (patch)
tree3a6dd2222b55935af191feacb1b40ad6d9663890
parent16157e77e5cf017043aac516309eb6e123aed03a (diff)
downloadostree-a8eed03a1974c285cb7ddf550c7385a4783bb97d.tar.gz
remote: Fix gcc `-fanalyzer` warning
In general, we're probably going to need to change most of our `g_return_if_fail` to `g_assert`. The analyzer flags that the function can return `NULL`, but the caller isn't prepared for this. In practice, let's abort.
-rw-r--r--src/libostree/ostree-remote.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/libostree/ostree-remote.c b/src/libostree/ostree-remote.c
index 2b068e15..93c1a328 100644
--- a/src/libostree/ostree-remote.c
+++ b/src/libostree/ostree-remote.c
@@ -65,8 +65,8 @@ ostree_remote_new_dynamic (const gchar *name,
{
OstreeRemote *remote;
- g_return_val_if_fail (name != NULL && *name != '\0', NULL);
- g_return_val_if_fail (refspec_name == NULL || *refspec_name != '\0', NULL);
+ g_assert (name != NULL && *name != '\0');
+ g_assert (refspec_name == NULL || *refspec_name != '\0');
remote = g_slice_new0 (OstreeRemote);
remote->ref_count = 1;