diff options
| author | Colin Walters <walters@verbum.org> | 2014-06-21 17:30:11 -0400 |
|---|---|---|
| committer | Colin Walters <walters@verbum.org> | 2014-06-21 18:08:49 -0400 |
| commit | 54079982d8667f3f908a2f03a11c1c8ee0619839 (patch) | |
| tree | 0856055feff504b54e95a2e36cb3f239c9d8087a | |
| parent | 2dc0cea50310a6707d45351cfdf9a334c2bc85c1 (diff) | |
| download | ostree-54079982d8667f3f908a2f03a11c1c8ee0619839.tar.gz | |
[staticanalysis]: Actually check errors on splice() of objects
We were using unsigned size when we should have been using signed,
this means we basically weren't checking for errors on write...ouch.
Luckily if we e.g. hit ENOSPC during a pull, the checksums wouldn't
match and we'd return an error anyways. However when writing an
object, we'd end up silently ignoring it =/
https://bugzilla.gnome.org/show_bug.cgi?id=732020
| -rw-r--r-- | src/libostree/ostree-repo-commit.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/libostree/ostree-repo-commit.c b/src/libostree/ostree-repo-commit.c index 3ae8ae24..68cff05d 100644 --- a/src/libostree/ostree-repo-commit.c +++ b/src/libostree/ostree-repo-commit.c @@ -365,7 +365,7 @@ write_object (OstreeRepo *self, gboolean temp_file_is_regular; gboolean is_symlink = FALSE; char loose_objpath[_OSTREE_LOOSE_PATH_MAX]; - gsize unpacked_size = 0; + gssize unpacked_size = 0; gboolean indexable = FALSE; g_return_val_if_fail (expected_checksum || out_csum, FALSE); |