summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLuca BRUNO <luca.bruno@coreos.com>2022-01-19 13:44:10 +0000
committerLuca BRUNO <luca.bruno@coreos.com>2022-01-19 14:10:24 +0000
commit6230b3eeab52b132d5b7e4e164380389325db040 (patch)
treec573aeeeb02ad6bc8a3b958a94bf4f6006291f1d
parenta05b02fa9c280a9601dbd18144aee0b0a303071a (diff)
downloadostree-6230b3eeab52b132d5b7e4e164380389325db040.tar.gz
lib/commit: always validate metadata
This tweaks commit logic in order to always validate metadata, including on commits where the expected checksum is already known.
-rw-r--r--src/libostree/ostree-repo-commit.c8
1 files changed, 2 insertions, 6 deletions
diff --git a/src/libostree/ostree-repo-commit.c b/src/libostree/ostree-repo-commit.c
index e2c86d96..a5aa63b0 100644
--- a/src/libostree/ostree-repo-commit.c
+++ b/src/libostree/ostree-repo-commit.c
@@ -2478,12 +2478,8 @@ ostree_repo_write_metadata (OstreeRepo *self,
normalized = g_variant_get_normal_form (object);
}
- /* For untrusted objects, verify their structure here */
- if (expected_checksum)
- {
- if (!_ostree_validate_structureof_metadata (objtype, object, error))
- return FALSE;
- }
+ if (!_ostree_validate_structureof_metadata (objtype, object, error))
+ return FALSE;
g_autoptr(GBytes) vdata = g_variant_get_data_as_bytes (normalized);
if (!write_metadata_object (self, objtype, expected_checksum,