summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
* Merge pull request #2246 from smcv/pull-summary-sigs-mtimeOpenShift Merge Robot2020-11-301-0/+12
|\ | | | | test-pull-summary-sigs: Set timestamps to serve expected files
| * test-pull-summary-sigs: Set timestamps to serve expected filesSimon McVittie2020-11-221-0/+12
|/ | | | | | | | | | | | | | | | | | | | | | If this is not done, the test can fail when the temporary directory is a tmpfs: for example this happens during build-time testing with /var/tmp on tmpfs or TEST_TMPDIR pointing to a tmpfs, or installed-tests with gnome-desktop-testing-runner allocating the test directory on a tmpfs. In particular, many of Debian's official autobuilders now do the entire build and test procedure in a chroot hosted on a tmpfs, to improve build performance and prevent fsync overhead. In this situation, it appears that overwriting summary.sig with a copy of summary.sig.2 is not sufficient for the web server to tell the libostree client that it needs to be re-downloaded. I'm not completely sure why, because tmpfs does appear to have sub-second-resolution timestamps, but forcing a distinct mtime is certainly enough to resolve it. Resolves: https://github.com/ostreedev/ostree/issues/2245 Bug-Debian: https://bugs.debian.org/975418 Signed-off-by: Simon McVittie <smcv@collabora.com>
* Merge pull request #2244 from lucab/ups/docs-release-guideOpenShift Merge Robot2020-11-194-8/+70
|\ | | | | templates: add release-checklist
| * templates: add release-checklistLuca BRUNO2020-11-184-8/+70
| | | | | | | | This collects all release steps in a release-checklist template.
* | Merge pull request #2243 from lucab/ups/workflow-checkoutOpenShift Merge Robot2020-11-181-0/+3
|\ \ | |/ |/| workflow/release: further refinements
| * workflow/release: further refinementsLuca BRUNO2020-11-181-0/+3
|/ | | | | | | This tweaks the release GH workflow further so that it only triggers when the `configure.ac` file (which owns the version) changes. Plus it properly checkouts the PR branch to avoid wrongly looking at a synthetic merge commit.
* Merge pull request #2242 from stb-tester/tarball-import-xattrsOpenShift Merge Robot2020-11-172-2/+122
|\ | | | | ostree commit --tree=tar: Import xattrs from tarballs
| * ostree commit --tree=tar: Import xattrs from tarballsWilliam Manley2020-11-172-2/+122
| | | | | | | | | | If you specify an `xattr_callback` the xattrs will still be taken from there for now.
* | Merge pull request #2241 from lucab/release-2020.8OpenShift Merge Robot2020-11-175-17/+20
|\ \ | |/ |/| Release 2020.8
| * configure: post-release version bumpLuca BRUNO2020-11-171-2/+2
| |
| * Release 2020.8v2020.8Luca BRUNO2020-11-175-17/+20
|/
* Merge pull request #2240 from lucab/ups/ci-pr-titleOpenShift Merge Robot2020-11-161-3/+2
|\ | | | | workflows/release: pattern-match on PR title
| * workflows/release: pattern-match on PR titleLuca BRUNO2020-11-161-3/+2
|/ | | | | This adds an additional condition in order to run sanity check all PRs starting with `Release` (case-insensitive).
* Merge pull request #2239 from lucab/ups/gh-actionsOpenShift Merge Robot2020-11-162-1/+29
|\ | | | | ci: run ci-release-build.sh on GitHub
| * ci: run ci-release-build.sh on GitHubLuca BRUNO2020-11-162-1/+29
|/ | | | | This adds a GitHub action in order to run ci-release-build.sh on release PRs (detected via the `kind/release` label).
* Merge pull request #2232 from cgwalters/deploy-docsOpenShift Merge Robot2020-11-121-4/+81
|\ | | | | deployment: Add a bunch of docs and fix annotations
| * deployment: Add a bunch of docs and fix annotationsColin Walters2020-11-111-4/+81
| | | | | | | | | | We were missing docs for these, also add some nullability annotations. Motivated by using these from the Rust bindings.
* | Merge pull request #2235 from cgwalters/checkout-some-new-styleOpenShift Merge Robot2020-11-121-69/+31
|\ \ | | | | | | bin/checkout: Port some to new style
| * | bin/checkout: Port some to new styleColin Walters2020-11-111-69/+31
| | | | | | | | | | | | | | | I was reading this code for unrelated reasons and noticed it was still old style; port most (but not all) to new style.
* | | Merge pull request #2231 from cgwalters/some-nullable-annotationsOpenShift Merge Robot2020-11-121-2/+2
|\ \ \ | |_|/ |/| | deployment: Ensure query_deployments_for returns nullable values
| * | deployment: Ensure query_deployments_for returns nullable valuesColin Walters2020-11-111-2/+2
|/ / | | | | | | | | Since that's a common case; hit this while working on rpm-ostree code using the ostree-rs bindings.
* | Merge pull request #2236 from lucab/ups/travis-xenialOpenShift Merge Robot2020-11-111-1/+0
|\ \ | | | | | | ci/travis: move to newer base distro
| * | ci/travis: move to newer base distroLuca BRUNO2020-11-101-1/+0
|/ / | | | | | | | | This removes the old pinned distro (Ubuntu Trusty 14.04) from Travis, moving to the newer default distro (Ubuntu Xenial 16.04).
* | Merge pull request #2233 from cgwalters/repo-annotationsOpenShift Merge Robot2020-11-091-9/+9
|\ \ | |/ |/| sysroot: Fix up some GI nullable annotations
| * sysroot: Fix up some GI nullable annotationsColin Walters2020-11-061-9/+9
| | | | | | | | | | Hit `ostree_sysroot_repo()` shouldn't be nullable while using the ostree Rust bindings.
* | Merge pull request #2228 from jlebon/pr/drop-volatileOpenShift Merge Robot2020-11-036-13/+13
|\ \ | | | | | | Drop use of `volatile`
| * | Drop use of `volatile`Jonathan Lebon2020-11-026-13/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As detailed in gitlab.gnome.org/GNOME/glib/-/issues/600#note_877282, volatile isn't actually needed in these contexts because the atomic operations already give us strong enough guarantees. In GCC 11, this triggers a diagnostic due to the volatile qualifier getting dropped anyway. There is a WIP to do the same in glib: https://gitlab.gnome.org/GNOME/glib/-/merge_requests/1719 This obsoletes this downstream patch: https://src.fedoraproject.org/rpms/ostree/c/b8c5a6fb
* | | Merge pull request #2230 from alexlarsson/pull-dont-save-passed-in-summaryOpenShift Merge Robot2020-11-031-1/+1
|\ \ \ | |_|/ |/| | pull: Don't save into cache passed in GByte summaries
| * | pull: Don't save into cache passed in GByte summariesAlexander Larsson2020-11-031-1/+1
| |/ | | | | | | | | | | | | | | | | The cache shouldn't be affected by the user passing in some other summary as it may not be the "official one". I ran into this in flatpak where the passed summary was correct, but the re-saving of the cache updated the mtime of the cached file which led to later http If-Modified-Since calls failing to update.
* | Merge pull request #2229 from dbnicholson/static-delta-generate-annotationsOpenShift Merge Robot2020-11-031-3/+3
|\ \ | |/ |/| lib/deltas: Annotate from checksum as nullable
| * lib/deltas: Annotate from checksum as nullableDan Nicholson2020-11-021-3/+3
|/ | | | | Without this you can't create a scratch delta from GI. While here, switch the deprecated allow-none annotations to nullable.
* Merge pull request #2226 from alexlarsson/fix-gir-argOpenShift Merge Robot2020-10-281-1/+1
|\ | | | | ostree_repo_gpg_sign_data: Fix API doc argument name
| * ostree_repo_gpg_sign_data: Fix API doc argument nameAlexander Larsson2020-10-281-1/+1
| | | | | | | | | | I got: src/libostree/ostree-repo.c:5232: Warning: OSTree: ostree_repo_gpg_sign_data: unknown parameter 'out_signature' in documentation comment, should be 'out_signatures'
* | Merge pull request #2224 from stb-tester/bootloader-refactoringsOpenShift Merge Robot2020-10-286-158/+204
|\ \ | | | | | | Bootloader probing and construction refactoring
| * | fixup! Refactor `ostree_sysroot_query_bootloader`William Manley2020-10-271-0/+3
| | |
| * | fixup! Refactor: Centralise choosing the appropriate bootloaderWilliam Manley2020-10-271-1/+0
| | |
| * | Tests: Refactor bootloader-entries-crosscheckWilliam Manley2020-10-261-87/+92
| | | | | | | | | | | | | | | | | | I've made this use functions to make it easier to add support for more bootloaders. Seeing as there will be a big diff anyway I've also adjusted the formatting to make it pep8 compliant.
| * | Refactor `ostree_sysroot_query_bootloader`William Manley2020-10-261-49/+47
| | | | | | | | | | | | | | | This is more regular, so will make it easier to add more bootloader types in the future.
| * | Add support for explicitly requesting any specific bootloader typeWilliam Manley2020-10-263-1/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | ...with the `sysroot.bootloader` configuration option. This can be useful when converting a system to use `ostree` which doesn't currently have a bootloader configuration that `ostree` can automatically detect, and is also useful in combination with the `--sysroot` option when provisioning a rootfs for systems other than the one you're running `ostree admin deploy` on.
| * | Refactor: sysroot.bootloader: Store enum value rather than stringWilliam Manley2020-10-263-55/+73
| | | | | | | | | | | | | | | | | | It's easier to extend and it centralises the config parsing. In other places we will no longer need to use `g_str_equal` to match these values, a `switch` statement will be sufficient.
| * | Refactor: Centralise choosing the appropriate bootloaderWilliam Manley2020-10-262-43/+44
| | | | | | | | | | | | In preparation for enhancing `_ostree_sysroot_query_bootloader`
| * | ostree_repo_get_bootloader: Document transfer noneWilliam Manley2020-10-261-1/+1
| |/ | | | | | | I think this may affect bindings too.
* | Merge pull request #2225 from jlebon/pr/clear-timerOpenShift Merge Robot2020-10-271-5/+2
|\ \ | |/ |/| lib/fetch-curl: Unref timeout source
| * lib/fetch-curl: Unref timeout sourceJonathan Lebon2020-10-271-4/+1
| | | | | | | | | | | | | | | | | | | | | | The timeout timer should always be one-shot, so let's just always destroy it in the callback. The main context has its own ref on it, so it won't be freed behind its back. This *should* fix a leak that was brought up in https://bugzilla.redhat.com/show_bug.cgi?id=1891761. Reported-by: Milan Crha <mcrha@redhat.com>
| * lib/fetcher-curl: Use G_SOURCE_REMOVE instead of FALSEJonathan Lebon2020-10-271-1/+1
|/ | | | | | They're equivalent, though I prefer the former because it's more descriptive and it makes it really obvious that it's a `GSource` callback.
* Merge pull request #2188 from alexlarsson/delta-indexesOpenShift Merge Robot2020-10-2316-525/+1329
|\ | | | | Add indexes for deltas outside of the summary
| * ostree pull: Add more g_debug spew around fetching deltasAlexander Larsson2020-10-231-0/+3
| | | | | | | | This is useful to debug what is happening when downloading via deltas.
| * Add ostree_repo_gpg_sign_data()Alexander Larsson2020-10-234-0/+73
| | | | | | | | | | This is similar to ostree_sign_data() but for the old gpg code. Flatpak will need this to reproduce a signed summary.
| * tests: Add a testcase to ensure we're not using the summary if we don't need itAlexander Larsson2020-10-231-2/+21
| | | | | | | | | | With deltas outside the summary, if a commit is specified when pulling we don't download the summary. Verify this.
| * pull: Only download summary if we need it for the pull operationAlexander Larsson2020-10-232-435/+480
| | | | | | | | | | | | | | | | | | | | If we have a commit id for all the refs we're pulling, and if we don't need the summary to list all the refs when mirroring then the only reason to download the summary is for the list of deltas. With the new "indexed-deltas" property in the config file (and mirrored to the summary file) we can detect when we don't need the summary for deltas and completely avoid downloading it then.