summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* configure: post-release version bumprelease-2021.5Colin Walters2021-10-051-2/+2
|
* Release 2021.5v2021.5Colin Walters2021-10-055-11/+11
|
* Merge pull request #2449 from cgwalters/mtree-from-commitJonathan Lebon2021-10-055-9/+47
|\
| * lib: Add an API to construct a `MutableTree` from a commitColin Walters2021-10-015-9/+47
| | | | | | | | | | | | | | This is nicer than having the caller parse the commit object, or indirect via the `OstreeRepoFile*` object of the root. Will be used in ostree-rs-ext around tar parsing.
* | Merge pull request #2454 from lucab/ups/auto-txn-completeColin Walters2021-10-054-35/+156
|\ \ | | | | | | repo/private: allow committing/aborting through a transaction guard
| * | repo/private: allow committing/aborting through a transaction guardLuca BRUNO2021-10-054-35/+156
| |/ | | | | | | | | | | | | | | | | This enhances the auto-transaction logic, augmenting the scope of a transaction guard. It allows committing or aborting a transaction through its guard. It also supports tracking the completion status of a transaction guard, avoiding double commits/aborts, while retaining the auto-cleanup logic.
* | Merge pull request #2453 from cgwalters/etc-ignore-socketsJonathan Lebon2021-10-043-3/+28
|\ \ | |/ |/|
| * deploy: Ignore sockets, fifos in /etc during mergeColin Walters2021-10-013-3/+28
|/ | | | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=1945274 is an issue where a privileged kubernetes daemonset is writing a socket into `/etc`. This makes ostree upgrades barf. Now, they should clearly move it to `/run`. However, one option is for us to just ignore it instead of erroring out. Some brief investigation shows that e.g. `git add somesocket` is a silent no-op, which is an argument in favor of ignoring it. Closes: https://github.com/ostreedev/ostree/issues/2446
* Merge pull request #2447 from cgwalters/sepolicy-for-commitColin Walters2021-09-306-35/+77
|\ | | | | repo: Add an API to init `OstreeSePolicy` from commit directly
| * sepolicy: Add deprecation comment for `_get_path()`Colin Walters2021-09-301-1/+5
| | | | | | | | | | Came up in review https://github.com/ostreedev/ostree/pull/2447#issuecomment-931428312
| * repo: Add an API to init `OstreeSePolicy` from commit directlyColin Walters2021-09-306-34/+72
| | | | | | | | | | | | | | | | | | | | This is part of `OstreeCommitModifier`, but I'm not using that in some of the ostree-ext Rust code. It just makes more sense as a direct policy API, where it should have been in the first place. There's already support for setting a policy object on a commit modifier, so that's all the old API needs to do now.
* | Merge pull request #2451 from cgwalters/fsck-happyJonathan Lebon2021-09-301-0/+3
|\ \
| * | fsck: Print a success messageColin Walters2021-09-301-0/+3
| |/ | | | | | | | | | | | | | | | | There's a general Unix philosophy that "silence is golden". However, when one is explicitly invoking an error check it's nice to see explicit success. We already print various statistics, so ending with a happy note has no extra cost.
* | Merge pull request #2450 from cgwalters/revdep-ext-ciJonathan Lebon2021-09-303-12/+12
|\ \ | |/ |/|
| * tests: Use ostree-ext 0.3.0Colin Walters2021-09-303-12/+12
| | | | | | | | | | This updates to the modern glib 0.14 and paves the way for some reverse dependency testing by using ostree-ext's code.
* | Merge pull request #2448 from cgwalters/fix-selinux-policyColin Walters2021-09-302-7/+25
|\ \ | |/ |/| bin/commit: Fix --tree=tar with --selinux-policy
| * bin/commit: Fix --tree=tar with --selinux-policyColin Walters2021-09-302-7/+25
|/ | | | | | | | | | | | The logic for `--selinux-policy` ended up in the `--tree=dir` path, but there's no reason for that. Fix the imported labeling with `--tree=tar`. Prep for use with containers. We had this bug because the previous logic was trying to avoid duplicating the code for generic `--selinux-policy` and the case of `--selinux-policy-from-base --tree=dir`. It's a bit more code, but it's cleaner if we dis-entangle them.
* Merge pull request #2440 from cgwalters/unit-test-countingColin Walters2021-09-133-7/+19
|\ | | | | two small unit test patches
| * tests: Add new TAP APIsColin Walters2021-09-102-4/+15
| | | | | | | | | | | | | | | | | | | | | | Having to touch a global test counter when adding tests is a recipe for conflicts between PRs. The TAP protocol allows *ending* with the expected number of tests, so the best way to do this is to have an explicit API like our `tap_ok` which bumps a counter, then end with `tap_end`. I ported one test as a demo.
| * tests/pull-test: Avoid duplicating test numbersColin Walters2021-09-101-3/+4
|/ | | | | We do this in other places; avoids touching two numbers when adding tests. Let computers do the addition.
* Merge pull request #2438 from cgwalters/release-2021.4v2021.4Colin Walters2021-09-095-11/+12
|\ | | | | Release 2021.4
| * configure: post-release version bumpColin Walters2021-09-082-5/+5
| |
| * Release 2021.4Colin Walters2021-09-084-8/+9
|/
* Merge pull request #2434 from cgwalters/custom-remoteColin Walters2021-09-085-22/+93
|\ | | | | Add support for "custom remotes"
| * Add support for "custom remotes"Colin Walters2021-09-085-22/+93
| | | | | | | | | | | | | | | | | | | | This will be helpful for the "ostree native container" work in https://github.com/ostreedev/ostree-rs-ext/ Basically in order to reuse GPG/signapi verification, we need to support adding a remote, even though it can't be used via `ostree pull`. (At least, not until we merge ostree-rs-ext into ostree, but even then I think the principle stands)
* | Merge pull request #2435 from RBuddel/fix-delta-files-resume-legacy-transactionLuca Bruno2021-09-081-1/+1
|\ \ | | | | | | repo-pull: legacy_transaction_resuming flag ignored
| * | repo-pull: legacy_transaction_resuming flag ignoredBuddelmann, Richard RB2021-09-081-1/+1
| |/ | | | | | | | | | | for deltafiles the legacy_transaction_resuming flag is not used, which will mark the commit as done, even if files are missing. using already existing commitstate_is_partial function as fix
* | Merge pull request #2430 from cgwalters/stabilize-stagingLuca Bruno2021-09-085-7/+25
|\ \ | |/ |/| upgrade: Stabilize deployment staging
| * upgrade: Stabilize deployment stagingColin Walters2021-09-075-7/+25
|/ | | | | | | | | | We're waaay overdue for this, it's been the default in rpm-ostree for years, and solves several important bugs around not capturing `/etc` while things are running. Also, `ostree admin upgrade --stage` (should) become idempotent. Closes: https://github.com/ostreedev/ostree/issues/2389
* Merge pull request #2428 from lucab/ups/tests-selinux-basicColin Walters2021-09-072-4/+14
|\ | | | | tests: fix bare mode unprivileged 'make check'
| * tests: skip a broken fsck caseLuca BRUNO2021-09-061-1/+4
| | | | | | | | | | | | There are some existing issues around fsck in unprivileged bare mode, so this test does not really work at the moment. Leaving it as a FIXME for the moment.
| * tests/basic: avoid changing ownershipLuca BRUNO2021-09-061-1/+1
| | | | | | | | | | This avoids possible issues when trying to chmod, tweaking permissions instead.
| * tests/basic: Skip --no-xattrs if we have selinuxColin Walters2021-09-061-1/+8
| | | | | | | | | | | | | | | | | | It cannot work to use `--no-xattrs` when SELinux is enabled because we get a `security.selinux` attribute on created files regardless. So just skip this test if true. Also add some `ostree fsck`s in here which helped me debug this.
| * libtest: tweak selinux/relabel messageLuca BRUNO2021-09-061-1/+1
|/
* Merge pull request #2340 from cgwalters/sign-verify-apiColin Walters2021-08-3110-3/+311
|\ | | | | Add an API to verify a commit signature explicitly
| * Add an API to verify a commit signature explicitlyColin Walters2021-08-3010-3/+311
| | | | | | | | | | | | | | | | | | | | | | | | | | We have a bunch of APIs to do GPG verification of a commit, but that doesn't generalize to signapi. Further, they require the caller to check the signature status explicitly which seems like a trap. This much higher level API works with both GPG and signapi. The intention is to use this in things that are doing "external pulls" like the ostree-ext tar import support. There we will get the commitmeta from the tarball and we want to verify it at the same time we import the commit.
* | Merge pull request #2426 from cgwalters/xattrs-bareuseronly-unionLuca Bruno2021-08-271-2/+2
|\ \ | | | | | | checkout: Also ignore xattrs for union in bare-user-only mode
| * | checkout: Also ignore xattrs for union in bare-user-only modeColin Walters2021-08-261-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | Followup to PRs related to https://github.com/ostreedev/ostree/issues/2410 Since the test suite now covers this the test was failing on a Fedora SELinux enabled host where we see `security.selinux` even if not in the commit.
* | | Merge pull request #2425 from cgwalters/hardlink-correct-errnoLuca Bruno2021-08-271-0/+2
|\ \ \ | | | | | | | | checkout: Save errno when re-throwing
| * | | checkout: Save errno when re-throwingColin Walters2021-08-261-0/+2
| |/ / | | | | | | | | | | | | | | | | | | | | | I was seeing an `EPERM` here which was confusing. It turned out the real error was `EEXIST`. Since we're referring to the original error, but we do a lot of computation in the middle, we need to save errno.
* | | Merge pull request #2424 from cgwalters/test-nonroot-ciColin Walters2021-08-261-1/+4
|\ \ \ | | | | | | | | ci: Run GH action CI build+test as non-root
| * | | ci: Run main GH action CI build+test as non-rootColin Walters2021-08-261-1/+4
| |/ / | | | | | | | | | | | | | | | This is really the standard best practice, matching how e.g. dpkg/rpm work, as well as most local development environments (including mine) with e.g. `toolbox`.
* | | Merge pull request #2422 from cgwalters/allow-none-detachedDan Nicholson2021-08-261-1/+3
|\ \ \ | |/ / |/| | lib: Change read_commit_detached_metadata to be nullable
| * | lib: Change read_commit_detached_metadata to be nullableColin Walters2021-08-251-1/+3
| |/ | | | | | | Hit this while working on some Rust code.
* | Merge pull request #2421 from lucab/ups/auto-txn-fixesColin Walters2021-08-251-3/+12
|\ \ | |/ |/| lib: improve transactions auto-cleanup logic
| * lib: improve transactions auto-cleanup logicLuca BRUNO2021-08-251-3/+12
|/ | | | | | | | | | This fixes some aspects of OstreeRepoAutoTransaction and re-aligns it with the logic in flatpak. Specifically: * link to the underlying repo through refcounting * bridge internal errors to warning messages * verify the input pointer type This is a preparation step before exposing this logic as a public API.
* Merge pull request #2418 from lucab/ups/lib-commit-xattrsLuca Bruno2021-08-246-34/+27
|\ | | | | commit: automatically skip xattrs in bare-user-only mode
| * tests: update several bare-user-only checksLuca BRUNO2021-08-242-26/+18
| |
| * lib/commit: automatically skip xattrs in bare-user-only modeLuca BRUNO2021-08-242-3/+4
| |
| * builtins/commit: set up relevant flags in bare-user-only modeLuca BRUNO2021-08-241-3/+3
| | | | | | | | | | This detects bare-user-only mode and automatically enables a commit modifier with relevant flags.