summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* configure: post-release version bumprelease-2021.6Luca BRUNO2021-11-231-2/+2
|
* Release 2021.6v2021.6Luca BRUNO2021-11-231-1/+1
|
* Merge pull request #2486 from jlebon/pr/remount-ostreeColin Walters2021-11-221-17/+41
|\ | | | | app: Only remount /sysroot if needed
| * app: Only remount /sysroot if neededJonathan Lebon2021-11-191-17/+41
|/ | | | | | | | We should only try to remount `/sysroot` if we're actually handling the sysroot repo and the repo isn't writable. We already have public APIs to check each of those, so let's use them. Closes: #2485
* Merge pull request #2484 from dbnicholson/prune-serializeColin Walters2021-11-181-12/+9
|\ | | | | lib/prune: Avoid unnecessary object serialization
| * lib/prune: Avoid unnecessary object serializationDan Nicholson2021-11-181-12/+9
|/ | | | | | `repo_prune_internal` was deserializing each object and passing the components to `maybe_prune_loose_object`, which promptly reserialized it.
* Merge pull request #2481 from refi64/null-errorLuca Bruno2021-11-122-6/+16
|\ | | | | lib: Avoid dereferencing NULL error values
| * lib: Avoid dereferencing NULL error valuesRyan Gonzalez2021-11-122-6/+16
|/ | | | | | Otherwise, this will segfault when callers don't need any exact errors. Signed-off-by: Ryan Gonzalez <ryan.gonzalez@collabora.com>
* Merge pull request #2479 from cgwalters/ci-capshColin Walters2021-11-091-0/+1
|\ | | | | ci: Require `libcap2-bin` for `capsh`
| * ci: Require `libcap2-bin` for `capsh`Colin Walters2021-11-091-0/+1
| | | | | | | | | | This was previously pulled in indirectly, but it looks like we need to require it explicitly in newer Ubuntu.
* | Merge pull request #2477 from ratajs/patch-1Colin Walters2021-11-091-1/+2
|\ \ | | | | | | Add Fedora Kinoite link
| * \ Merge branch 'ostreedev:main' into patch-1Šimon (Simon) Rataj2021-11-041-24/+66
| |\ \ | | |/
| * | Added Fedora Kinoite linkŠimon (Simon) Rataj2021-11-031-1/+2
| | |
* | | Merge pull request #2476 from valentindavid/valentindavid/glib-fixColin Walters2021-11-091-1/+1
|\ \ \ | |_|/ |/| | lib: Fix a bad call to g_file_get_child
| * | lib: Fix a bad call to g_file_get_childValentin David2021-11-031-1/+1
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In Glib, since commit 3a6e8bc8876e149c36b6b14c6a25a718edb581ed, `g_file_get_child` does not accept absolute path as paramater anymore. The broken assertion was encountered during `ostree admin deploy` command for the checkout of subpath `etc`. Example of error log: ``` (ostree admin deploy:1640): GLib-GIO-CRITICAL **: 03:42:00.570: g_file_get_child: assertion '!g_path_is_absolute (name)' failed (ostree admin deploy:1640): GLib-GIO-CRITICAL **: 03:42:00.570: g_file_query_info: assertion 'G_IS_FILE (file)' failed ** OSTree:ERROR:src/ostree/ot-main.c:232:ostree_run: assertion failed: (success || error) Bail out! OSTree:ERROR:src/ostree/ot-main.c:232:ostree_run: assertion failed: (success || error) ```
* | Merge pull request #2187 from cgwalters/sysroot-ro-initramfsColin Walters2021-11-041-24/+66
|\ \ | |/ |/| prepare-root: Set up sysroot readonly in initramfs
| * prepare-root: Set up sysroot readonly in initramfsColin Walters2021-11-031-24/+66
|/ | | | | | | | Let's ensure things are right from the start in the initramfs; this closes off various race conditions. Followup to https://github.com/ostreedev/ostree/pull/2113/commits/35642259175973617da937f3cab6ce5f13c95077 Closes: https://github.com/ostreedev/ostree/issues/2115
* Merge pull request #2475 from lucab/ups/prepare-root-check-firstColin Walters2021-11-011-14/+14
|\ | | | | prepare-root: check for read-only sysroot status early on
| * prepare-root: check for read-only sysroot status early onLuca BRUNO2021-11-011-14/+14
|/ | | | | | | | This moves read-only sysroot checks upfront, so that they are not intermixed with mount operations. It has no immediate side-effects, but allow these check to be independent from the rest of the mounting logic (and future changes to it).
* Merge pull request #2472 from lucab/ups/prepare-root-checked-printfJonathan Lebon2021-10-261-3/+6
|\
| * prepare-root: check return codes for errors when assembling pathsLuca BRUNO2021-10-261-3/+6
| | | | | | | | | | This adds checks around all `snprintf` calls in order to detect failures and gracefully abort.
* | Merge pull request #2473 from lucab/ups/prepare-root-less-global-mutable-stateJonathan Lebon2021-10-261-4/+1
|\ \ | |/ |/|
| * prepare-root: get rid of a global variableLuca BRUNO2021-10-261-4/+1
|/ | | | | This moves a global mutable variable to a smaller local scope, as it is not really used outside of that.
* Merge pull request #2471 from lucab/ups/prepare-root-silent-mountsColin Walters2021-10-261-13/+13
|\ | | | | prepare-root: make all mount operations silent
| * prepare-root: make all mount operations silentLuca BRUNO2021-10-261-13/+13
|/ | | | | | | This adds a `MS_SILENT` flag to all `mount(2)` calls, reducing the amount of kernel logs produced on each boot. Those messages do not contain actionable details, and in the "mount plus read-only remount" case they can easily become highly redundant.
* Merge pull request #2468 from lucab/ups/tests-var-mountLuca Bruno2021-10-191-6/+3
|\ | | | | tests/var-mount: tweak test setup
| * tests/var-mount: tweak test setupLuca BRUNO2021-10-191-6/+3
|/ | | | | | | | This reworks the var-mount destructive test in order to properly use the datadir for the current stateroot instead of a duplicated one. In turn, it ensures that the resulting `var.mount` after reboot is correctly pointing to the same location which hosted `/var` on the previous boot.
* Merge pull request #2466 from cgwalters/ci-fanalyzerLuca Bruno2021-10-182-3/+3
|\ | | | | ci: Enable -fanalyzer
| * tests/rollsum: Use `g_malloc` not `malloc`Colin Walters2021-10-181-2/+2
| | | | | | | | To pacify gcc's `-fanalyzer`.
| * ci: Enable -fanalyzerColin Walters2021-10-151-1/+1
|/ | | | | | | | | Followup to https://github.com/ostreedev/ostree/pull/2463 One thing I noticed here is we lost usage of `build-check.sh` which also invokes `clang`, which doesn't speak `-fanalyzer` and would be broken by this if we try to enable `build-check.sh` again. But that can come later.
* Merge pull request #2455 from cgwalters/packitLuca Bruno2021-10-152-21/+23
|\ | | | | Attempt to update packit flow to build in COPR
| * Attempt to update packit flow to build in COPRColin Walters2021-10-142-21/+23
| | | | | | | | | | No idea if this will really work, but at least `packit srpm` does work now.
* | Merge pull request #2467 from cgwalters/bump-libglnx-20211014Jonathan Lebon2021-10-141-0/+0
|\ \ | |/ |/|
| * libglnx: Bump to ef502aabf7d3a0d37f9c4d228f870ac93404447bColin Walters2021-10-141-0/+0
|/ | | | | | Various fixes there, including one for `gcc -fanalyzer`. Update submodule: libglnx
* Merge pull request #2463 from cgwalters/fix-fanalyzerLuca Bruno2021-10-147-19/+25
|\ | | | | Fix various mostly theoretical gcc `-fanalyzer` issues
| * variantutil: Fix gcc `-fanalyzer` warninColin Walters2021-10-131-8/+7
| | | | | | | | | | Add some not-NULL assertions for return values from glib, and upgrade some `g_return_if_fail` to `g_assert`.
| * utils: Fix unreachable `NULL` deref by adding assertionColin Walters2021-10-131-2/+5
| | | | | | | | Again this one is just in theory, but let's add an assertion.
| * static-delta: Fix probably not actually possible NULL derefColin Walters2021-10-131-1/+1
| | | | | | | | | | | | Flagged by `gcc -fanalyzer`. I didn't study this really deeply but I think it's not actually reachable. Anyways, let's catch it on general principle.
| * fetcher/soup: Fix gcc `-fanalyzer` warningColin Walters2021-10-131-1/+1
| | | | | | | | | | | | | | | | | | In general, we're probably going to need to change most of our `g_return_if_fail` to `g_assert`. The analyzer flags that the function can return `NULL`, but the caller isn't prepared for this. In practice, let's abort.
| * sysroot: Fix gcc `-fanalyzer` warningColin Walters2021-10-131-2/+6
| | | | | | | | | | | | | | | | | | In general, we're probably going to need to change most of our `g_return_if_fail` to `g_assert`. The analyzer flags that the function can return `NULL`, but the caller isn't prepared for this. In practice, let's abort.
| * deployment: Fix gcc `-fanalyzer` warningColin Walters2021-10-131-3/+3
| | | | | | | | | | | | | | | | | | In general, we're probably going to need to change most of our `g_return_if_fail` to `g_assert`. The analyzer flags that the function can return `NULL`, but the caller isn't prepared for this. In practice, let's abort.
| * remote: Fix gcc `-fanalyzer` warningColin Walters2021-10-131-2/+2
| | | | | | | | | | | | | | | | | | In general, we're probably going to need to change most of our `g_return_if_fail` to `g_assert`. The analyzer flags that the function can return `NULL`, but the caller isn't prepared for this. In practice, let's abort.
* | Merge pull request #2464 from lucab/ups/box-auto-txnColin Walters2021-10-132-16/+51
|\ \ | |/ |/| repo/private: move OstreeRepoAutoTransaction to a boxed type
| * repo/private: move OstreeRepoAutoTransaction to a boxed typeLuca BRUNO2021-10-112-16/+51
| | | | | | | | | | | | | | This defines `OstreeRepoAutoTransaction` as a boxed type, in order to support auto-generating bindings for it. That first requires adding internal reference-counting to it, to allow freely copying/freeing references to a single transaction guard.
* | Merge pull request #2465 from travier/docfixesLuca Bruno2021-10-121-0/+4
|\ \ | |/ |/| docs: Do not convert -- & --- to en/em-dash
| * docs: Do not convert -- & --- to en/em-dashTimothée Ravier2021-10-111-0/+4
|/ | | | | '--' is frequently used for command line options and was thus incorrectly rendered as a special en-dash symbol.
* Merge pull request #2461 from lucab/ups/prepare-root-loggingColin Walters2021-10-071-4/+13
|\ | | | | prepare-root: tweak log messages to clarify errors
| * prepare-root: tweak log messages to clarify errorsLuca BRUNO2021-10-071-4/+13
|/ | | | | | | | This rewords errors and log messages in the functions which take care of preparing sysroot in initramfs. Depending on the boot flow, it is possible to reach this logic with a sysroot mounted (unexpectedly) as read-only. In that case, let's clearly point out the problematic mountpoint.
* Merge pull request #2460 from cgwalters/gir-no-tls-interactionJonathan Lebon2021-10-075-4/+4
|\
| * Remove OstreeTlsCertInteraction bits from introspectionColin Walters2021-10-065-4/+4
| | | | | | | | | | | | | | | | We filter out everything named `-private.h` from scanning, which differs from the gtk-doc exclude. Eventually this will be solved when we switch to the new gir-based docs. Came up in https://github.com/ostreedev/ostree-rs/pull/34#discussion_r723337772
View Lorry Controller Status