summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
| * prepare-root: check for read-only sysroot status early onLuca BRUNO2021-11-011-14/+14
|/ | | | | | | | This moves read-only sysroot checks upfront, so that they are not intermixed with mount operations. It has no immediate side-effects, but allow these check to be independent from the rest of the mounting logic (and future changes to it).
* Merge pull request #2472 from lucab/ups/prepare-root-checked-printfJonathan Lebon2021-10-261-3/+6
|\
| * prepare-root: check return codes for errors when assembling pathsLuca BRUNO2021-10-261-3/+6
| | | | | | | | | | This adds checks around all `snprintf` calls in order to detect failures and gracefully abort.
* | Merge pull request #2473 from lucab/ups/prepare-root-less-global-mutable-stateJonathan Lebon2021-10-261-4/+1
|\ \ | |/ |/|
| * prepare-root: get rid of a global variableLuca BRUNO2021-10-261-4/+1
|/ | | | | This moves a global mutable variable to a smaller local scope, as it is not really used outside of that.
* Merge pull request #2471 from lucab/ups/prepare-root-silent-mountsColin Walters2021-10-261-13/+13
|\ | | | | prepare-root: make all mount operations silent
| * prepare-root: make all mount operations silentLuca BRUNO2021-10-261-13/+13
|/ | | | | | | This adds a `MS_SILENT` flag to all `mount(2)` calls, reducing the amount of kernel logs produced on each boot. Those messages do not contain actionable details, and in the "mount plus read-only remount" case they can easily become highly redundant.
* Merge pull request #2468 from lucab/ups/tests-var-mountLuca Bruno2021-10-191-6/+3
|\ | | | | tests/var-mount: tweak test setup
| * tests/var-mount: tweak test setupLuca BRUNO2021-10-191-6/+3
|/ | | | | | | | This reworks the var-mount destructive test in order to properly use the datadir for the current stateroot instead of a duplicated one. In turn, it ensures that the resulting `var.mount` after reboot is correctly pointing to the same location which hosted `/var` on the previous boot.
* Merge pull request #2466 from cgwalters/ci-fanalyzerLuca Bruno2021-10-182-3/+3
|\ | | | | ci: Enable -fanalyzer
| * tests/rollsum: Use `g_malloc` not `malloc`Colin Walters2021-10-181-2/+2
| | | | | | | | To pacify gcc's `-fanalyzer`.
| * ci: Enable -fanalyzerColin Walters2021-10-151-1/+1
|/ | | | | | | | | Followup to https://github.com/ostreedev/ostree/pull/2463 One thing I noticed here is we lost usage of `build-check.sh` which also invokes `clang`, which doesn't speak `-fanalyzer` and would be broken by this if we try to enable `build-check.sh` again. But that can come later.
* Merge pull request #2455 from cgwalters/packitLuca Bruno2021-10-152-21/+23
|\ | | | | Attempt to update packit flow to build in COPR
| * Attempt to update packit flow to build in COPRColin Walters2021-10-142-21/+23
| | | | | | | | | | No idea if this will really work, but at least `packit srpm` does work now.
* | Merge pull request #2467 from cgwalters/bump-libglnx-20211014Jonathan Lebon2021-10-141-0/+0
|\ \ | |/ |/|
| * libglnx: Bump to ef502aabf7d3a0d37f9c4d228f870ac93404447bColin Walters2021-10-141-0/+0
|/ | | | | | Various fixes there, including one for `gcc -fanalyzer`. Update submodule: libglnx
* Merge pull request #2463 from cgwalters/fix-fanalyzerLuca Bruno2021-10-147-19/+25
|\ | | | | Fix various mostly theoretical gcc `-fanalyzer` issues
| * variantutil: Fix gcc `-fanalyzer` warninColin Walters2021-10-131-8/+7
| | | | | | | | | | Add some not-NULL assertions for return values from glib, and upgrade some `g_return_if_fail` to `g_assert`.
| * utils: Fix unreachable `NULL` deref by adding assertionColin Walters2021-10-131-2/+5
| | | | | | | | Again this one is just in theory, but let's add an assertion.
| * static-delta: Fix probably not actually possible NULL derefColin Walters2021-10-131-1/+1
| | | | | | | | | | | | Flagged by `gcc -fanalyzer`. I didn't study this really deeply but I think it's not actually reachable. Anyways, let's catch it on general principle.
| * fetcher/soup: Fix gcc `-fanalyzer` warningColin Walters2021-10-131-1/+1
| | | | | | | | | | | | | | | | | | In general, we're probably going to need to change most of our `g_return_if_fail` to `g_assert`. The analyzer flags that the function can return `NULL`, but the caller isn't prepared for this. In practice, let's abort.
| * sysroot: Fix gcc `-fanalyzer` warningColin Walters2021-10-131-2/+6
| | | | | | | | | | | | | | | | | | In general, we're probably going to need to change most of our `g_return_if_fail` to `g_assert`. The analyzer flags that the function can return `NULL`, but the caller isn't prepared for this. In practice, let's abort.
| * deployment: Fix gcc `-fanalyzer` warningColin Walters2021-10-131-3/+3
| | | | | | | | | | | | | | | | | | In general, we're probably going to need to change most of our `g_return_if_fail` to `g_assert`. The analyzer flags that the function can return `NULL`, but the caller isn't prepared for this. In practice, let's abort.
| * remote: Fix gcc `-fanalyzer` warningColin Walters2021-10-131-2/+2
| | | | | | | | | | | | | | | | | | In general, we're probably going to need to change most of our `g_return_if_fail` to `g_assert`. The analyzer flags that the function can return `NULL`, but the caller isn't prepared for this. In practice, let's abort.
* | Merge pull request #2464 from lucab/ups/box-auto-txnColin Walters2021-10-132-16/+51
|\ \ | |/ |/| repo/private: move OstreeRepoAutoTransaction to a boxed type
| * repo/private: move OstreeRepoAutoTransaction to a boxed typeLuca BRUNO2021-10-112-16/+51
| | | | | | | | | | | | | | This defines `OstreeRepoAutoTransaction` as a boxed type, in order to support auto-generating bindings for it. That first requires adding internal reference-counting to it, to allow freely copying/freeing references to a single transaction guard.
* | Merge pull request #2465 from travier/docfixesLuca Bruno2021-10-121-0/+4
|\ \ | |/ |/| docs: Do not convert -- & --- to en/em-dash
| * docs: Do not convert -- & --- to en/em-dashTimothée Ravier2021-10-111-0/+4
|/ | | | | '--' is frequently used for command line options and was thus incorrectly rendered as a special en-dash symbol.
* Merge pull request #2461 from lucab/ups/prepare-root-loggingColin Walters2021-10-071-4/+13
|\ | | | | prepare-root: tweak log messages to clarify errors
| * prepare-root: tweak log messages to clarify errorsLuca BRUNO2021-10-071-4/+13
|/ | | | | | | | This rewords errors and log messages in the functions which take care of preparing sysroot in initramfs. Depending on the boot flow, it is possible to reach this logic with a sysroot mounted (unexpectedly) as read-only. In that case, let's clearly point out the problematic mountpoint.
* Merge pull request #2460 from cgwalters/gir-no-tls-interactionJonathan Lebon2021-10-075-4/+4
|\
| * Remove OstreeTlsCertInteraction bits from introspectionColin Walters2021-10-065-4/+4
| | | | | | | | | | | | | | | | We filter out everything named `-private.h` from scanning, which differs from the gtk-doc exclude. Eventually this will be solved when we switch to the new gir-based docs. Came up in https://github.com/ostreedev/ostree-rs/pull/34#discussion_r723337772
* | Merge pull request #2459 from smcv/test-commit-signColin Walters2021-10-061-2/+6
|\ \ | |/ |/| test-commit-sign.sh: Skip a unit test when running as an installed-test
| * test-commit-sign.sh: Skip a unit test when running as an installed-testSimon McVittie2021-10-051-2/+6
| | | | | | | | Signed-off-by: Simon McVittie <smcv@debian.org>
* | Merge pull request #2458 from ostreedev/release-2021.5Colin Walters2021-10-065-11/+11
|\ \ | |/ |/| Release 2021.5
| * configure: post-release version bumprelease-2021.5Colin Walters2021-10-051-2/+2
| |
| * Release 2021.5v2021.5Colin Walters2021-10-055-11/+11
|/
* Merge pull request #2449 from cgwalters/mtree-from-commitJonathan Lebon2021-10-055-9/+47
|\
| * lib: Add an API to construct a `MutableTree` from a commitColin Walters2021-10-015-9/+47
| | | | | | | | | | | | | | This is nicer than having the caller parse the commit object, or indirect via the `OstreeRepoFile*` object of the root. Will be used in ostree-rs-ext around tar parsing.
* | Merge pull request #2454 from lucab/ups/auto-txn-completeColin Walters2021-10-054-35/+156
|\ \ | | | | | | repo/private: allow committing/aborting through a transaction guard
| * | repo/private: allow committing/aborting through a transaction guardLuca BRUNO2021-10-054-35/+156
| |/ | | | | | | | | | | | | | | | | This enhances the auto-transaction logic, augmenting the scope of a transaction guard. It allows committing or aborting a transaction through its guard. It also supports tracking the completion status of a transaction guard, avoiding double commits/aborts, while retaining the auto-cleanup logic.
* | Merge pull request #2453 from cgwalters/etc-ignore-socketsJonathan Lebon2021-10-043-3/+28
|\ \ | |/ |/|
| * deploy: Ignore sockets, fifos in /etc during mergeColin Walters2021-10-013-3/+28
|/ | | | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=1945274 is an issue where a privileged kubernetes daemonset is writing a socket into `/etc`. This makes ostree upgrades barf. Now, they should clearly move it to `/run`. However, one option is for us to just ignore it instead of erroring out. Some brief investigation shows that e.g. `git add somesocket` is a silent no-op, which is an argument in favor of ignoring it. Closes: https://github.com/ostreedev/ostree/issues/2446
* Merge pull request #2447 from cgwalters/sepolicy-for-commitColin Walters2021-09-306-35/+77
|\ | | | | repo: Add an API to init `OstreeSePolicy` from commit directly
| * sepolicy: Add deprecation comment for `_get_path()`Colin Walters2021-09-301-1/+5
| | | | | | | | | | Came up in review https://github.com/ostreedev/ostree/pull/2447#issuecomment-931428312
| * repo: Add an API to init `OstreeSePolicy` from commit directlyColin Walters2021-09-306-34/+72
| | | | | | | | | | | | | | | | | | | | This is part of `OstreeCommitModifier`, but I'm not using that in some of the ostree-ext Rust code. It just makes more sense as a direct policy API, where it should have been in the first place. There's already support for setting a policy object on a commit modifier, so that's all the old API needs to do now.
* | Merge pull request #2451 from cgwalters/fsck-happyJonathan Lebon2021-09-301-0/+3
|\ \
| * | fsck: Print a success messageColin Walters2021-09-301-0/+3
| |/ | | | | | | | | | | | | | | | | There's a general Unix philosophy that "silence is golden". However, when one is explicitly invoking an error check it's nice to see explicit success. We already print various statistics, so ending with a happy note has no extra cost.
* | Merge pull request #2450 from cgwalters/revdep-ext-ciJonathan Lebon2021-09-303-12/+12
|\ \ | |/ |/|
| * tests: Use ostree-ext 0.3.0Colin Walters2021-09-303-12/+12
| | | | | | | | | | This updates to the modern glib 0.14 and paves the way for some reverse dependency testing by using ostree-ext's code.
View Lorry Controller Status