summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* configure: post-release version bumprelease-2022.1Luca BRUNO2022-01-051-2/+2
|
* Release 2022.1v2022.1Luca BRUNO2022-01-051-3/+3
|
* Merge pull request #2506 from lucab/ups/dependabot-configDan Nicholson2022-01-041-0/+7
|\ | | | | github: add dependabot config
| * github: add dependabot configLuca BRUNO2022-01-041-0/+7
|/ | | | | This adds a configuration file for dependabot, taking care of automatic updates for all git submodules.
* Merge pull request #2376 from smcv/fuse3Luca Bruno2022-01-044-6/+81
|\ | | | | rofiles-fuse: Build using FUSE 3 if possible, falling back to FUSE 2
| * rofiles-fuse: Build using FUSE 3 if possible, falling back to FUSE 2Simon McVittie2022-01-044-6/+81
|/ | | | | | | | This adds build-time configuration logic to automatically detect and switch between libfuse 2.x and 3.x. Signed-off-by: Simon McVittie <smcv@collabora.com> Co-authored-by: Luca BRUNO <luca.bruno@coreos.com>
* Merge pull request #2505 from lucab/ups/bsdiff-error-throwColin Walters2022-01-031-1/+1
|\ | | | | lib/static-delta: throw a proper error on bspatch failure
| * lib/static-delta: throw a proper error on bspatch failureLuca BRUNO2022-01-031-1/+1
| | | | | | | | | | This makes sure that a populated GError is returned when bsdiff patching fails. The human-friendly label also helps in debugging.
* | Merge pull request #2504 from lucab/ups/bsdiff-CVE-2014-9862Colin Walters2022-01-031-0/+0
|\ \ | |/ |/| bsdiff: bump submodule, pick up fix for CVE-2014-9862
| * bsdiff: bump submodule, pick up fix for CVE-2014-9862Luca BRUNO2022-01-031-0/+0
|/ | | | | | | | | This updates the bsdiff submodule to latest upstream revision, in order to pick up additional bound checks for CVE-2014-9862. Update submodule: bsdiff Ref: * https://www.x41-dsec.de/lab/advisories/x41-2020-006-bspatch/
* Merge pull request #2503 from lucab/ups/libostree-content-writer-headerColin Walters2022-01-032-0/+2
|\ | | | | lib: use ostree-content-writer header
| * lib: use ostree-content-writer headerLuca BRUNO2022-01-032-0/+2
|/ | | | | | This installs and exposes the content of `ostree-content-writer.h`, so that library consumers can properly reference symbols defined in that header.
* Merge pull request #2502 from cgwalters/analyzerDan Nicholson2021-12-212-49/+4
|\ | | | | two minor clang-analyzer fixes
| * tests: Fix clang-analyzer not seeing through `g_error()`Colin Walters2021-12-211-4/+4
| | | | | | | | | | | | | | | | Basically due to the glib structured logging rework we lost the `noreturn` attribute on `g_error()`. This is fixed in glib as of https://gitlab.gnome.org/GNOME/glib/-/commit/f97ff20adf4eb7b952dd83e2c13046fe9e282f50 But we might as well just throw an error here.
| * soup-uri: Fix clang-analyzer warning by dropping dead codeColin Walters2021-12-211-45/+0
|/ | | | | | | | Fixes `Argument with 'nonnull' attribute passed null` by making the code not exist at all anymore. In upstream libsoup this code is gone too; it uses `GUri` from glib which we probably could now too, but one thing at a time.
* Merge pull request #2501 from lucab/ups/test-cli-extensions-tweakLuca Bruno2021-12-211-2/+6
|\ | | | | tests/cli-extensions: tweak test logic
| * tests/cli-extensions: tweak test logicLuca BRUNO2021-12-211-2/+6
|/ | | | | | This updates the test logic for CLI extensions, actually checking for functional output from the subcommand. It also cleans up some environmental leftover.
* Merge pull request #2500 from lucab/ups/cli-extensionsColin Walters2021-12-205-16/+140
|\ | | | | main: add support for CLI extensions via external binaries
| * main: add support for CLI extensions via external binariesLuca BRUNO2021-12-205-16/+140
|/ | | | | | | | | | This adds some logic to detect and dispatch unknown subcommands to extensions available in `$PATH`. Additional commands can be implemented by adding relevant `ostree-$verb` binaries to the system. As an example, if a `/usr/bin/ostree-extcommand` extension is provided, the execution of `ostree extcommand --help` will be dispatched to that as `ostree-extcommand extcommand --help`.
* Merge pull request #2498 from lucab/ups/test-assert-stringsColin Walters2021-12-101-2/+4
|\ | | | | tests: assert mandatory values are present
| * tests: assert mandatory values are presentLuca BRUNO2021-12-101-2/+4
|/ | | | | This adds a couple of string assertions to make sure that the test run is sane.
* Merge pull request #2496 from lucab/ups/repo-assertsColin Walters2021-12-071-4/+9
|\ | | | | lib/repo: fix problematic invariant checks
| * lib/repo: do no return a NULL on failureLuca BRUNO2021-12-071-2/+4
| | | | | | | | | | | | This turns an existing check into an assert. The previously returned NULL may result in confusing callers, as none of them is checking for that.
| * lib/repo: do no return an arbitrary mode on failureLuca BRUNO2021-12-071-1/+2
| | | | | | | | | | This turns the existing check into an assert. Otherwise, the previous code may return an arbitrary repo mode (bare) on failure.
| * lib/repo: assert that writable state and error agreeLuca BRUNO2021-12-071-1/+3
| | | | | | | | | | This adds an assertion to check that writable stable and error are in sync. The subsequent logic uses them interchangeably.
* | Merge pull request #2494 from jmarrero/fsf-addressColin Walters2021-12-07435-1306/+436
|\ \ | |/ |/| Update FSF license notices to use URL instead of address
| * Update FSF license notices to use URL instead of addressJoseph Marrero2021-12-07435-1306/+436
| |
* | Merge pull request #2493 from cgwalters/summary-lock-sharedColin Walters2021-12-061-8/+2
|\ \ | |/ |/| repo: Change locking for summary regeneration to be shared
| * repo: Change locking for summary regeneration to be sharedColin Walters2021-12-031-8/+2
|/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is trying to address: https://pagure.io/fedora-iot/issue/48 Basically we changed rpm-ostree to start doing a shared lock during commit by default, but this broke because pungi is starting a process doing a commit for each architecture, and then trying to regenerate the summary after each one. This patch is deleting a big comment with a rationale for why summary regeneration should be exclusive. Point by point: > This makes sure the commits and deltas don't get > deleted while generating the summary. But prune operations require an exclusive lock, which means that data still can't be deleted when the summary grabs a shared lock. > It also means we can be sure refs > won't be created/updated/deleted during the operation, without having to > add exclusive locks to those operations which would prevent concurrent > commits from working. First: The status quo *has* prevented concurrent commits from working! There is no real locking solution to this problem. What we really need to do here is regenerate the summary after each commit *or* when the caller decides to do it and e.g. include deltas at the same time. It's OK if multiple threads race to regenerate the summary; last-one-wins behavior here is totally fine.
* Merge pull request #2490 from lucab/ups/static-fixesJonathan Lebon2021-11-263-3/+4
|\
| * lib: misc static analysis fixesLuca BRUNO2021-11-263-3/+4
|/ | | | | This fixes a few warnings from coverity, none of which really interesting.
* Merge pull request #2489 from ostreedev/release-2021.6Colin Walters2021-11-231-1/+1
|\ | | | | Release 2021.6
| * configure: post-release version bumprelease-2021.6Luca BRUNO2021-11-231-2/+2
| |
| * Release 2021.6v2021.6Luca BRUNO2021-11-231-1/+1
|/
* Merge pull request #2486 from jlebon/pr/remount-ostreeColin Walters2021-11-221-17/+41
|\ | | | | app: Only remount /sysroot if needed
| * app: Only remount /sysroot if neededJonathan Lebon2021-11-191-17/+41
|/ | | | | | | | We should only try to remount `/sysroot` if we're actually handling the sysroot repo and the repo isn't writable. We already have public APIs to check each of those, so let's use them. Closes: #2485
* Merge pull request #2484 from dbnicholson/prune-serializeColin Walters2021-11-181-12/+9
|\ | | | | lib/prune: Avoid unnecessary object serialization
| * lib/prune: Avoid unnecessary object serializationDan Nicholson2021-11-181-12/+9
|/ | | | | | `repo_prune_internal` was deserializing each object and passing the components to `maybe_prune_loose_object`, which promptly reserialized it.
* Merge pull request #2481 from refi64/null-errorLuca Bruno2021-11-122-6/+16
|\ | | | | lib: Avoid dereferencing NULL error values
| * lib: Avoid dereferencing NULL error valuesRyan Gonzalez2021-11-122-6/+16
|/ | | | | | Otherwise, this will segfault when callers don't need any exact errors. Signed-off-by: Ryan Gonzalez <ryan.gonzalez@collabora.com>
* Merge pull request #2479 from cgwalters/ci-capshColin Walters2021-11-091-0/+1
|\ | | | | ci: Require `libcap2-bin` for `capsh`
| * ci: Require `libcap2-bin` for `capsh`Colin Walters2021-11-091-0/+1
| | | | | | | | | | This was previously pulled in indirectly, but it looks like we need to require it explicitly in newer Ubuntu.
* | Merge pull request #2477 from ratajs/patch-1Colin Walters2021-11-091-1/+2
|\ \ | | | | | | Add Fedora Kinoite link
| * \ Merge branch 'ostreedev:main' into patch-1Šimon (Simon) Rataj2021-11-041-24/+66
| |\ \ | | |/
| * | Added Fedora Kinoite linkŠimon (Simon) Rataj2021-11-031-1/+2
| | |
* | | Merge pull request #2476 from valentindavid/valentindavid/glib-fixColin Walters2021-11-091-1/+1
|\ \ \ | |_|/ |/| | lib: Fix a bad call to g_file_get_child
| * | lib: Fix a bad call to g_file_get_childValentin David2021-11-031-1/+1
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In Glib, since commit 3a6e8bc8876e149c36b6b14c6a25a718edb581ed, `g_file_get_child` does not accept absolute path as paramater anymore. The broken assertion was encountered during `ostree admin deploy` command for the checkout of subpath `etc`. Example of error log: ``` (ostree admin deploy:1640): GLib-GIO-CRITICAL **: 03:42:00.570: g_file_get_child: assertion '!g_path_is_absolute (name)' failed (ostree admin deploy:1640): GLib-GIO-CRITICAL **: 03:42:00.570: g_file_query_info: assertion 'G_IS_FILE (file)' failed ** OSTree:ERROR:src/ostree/ot-main.c:232:ostree_run: assertion failed: (success || error) Bail out! OSTree:ERROR:src/ostree/ot-main.c:232:ostree_run: assertion failed: (success || error) ```
* | Merge pull request #2187 from cgwalters/sysroot-ro-initramfsColin Walters2021-11-041-24/+66
|\ \ | |/ |/| prepare-root: Set up sysroot readonly in initramfs
| * prepare-root: Set up sysroot readonly in initramfsColin Walters2021-11-031-24/+66
|/ | | | | | | | Let's ensure things are right from the start in the initramfs; this closes off various race conditions. Followup to https://github.com/ostreedev/ostree/pull/2113/commits/35642259175973617da937f3cab6ce5f13c95077 Closes: https://github.com/ostreedev/ostree/issues/2115
* Merge pull request #2475 from lucab/ups/prepare-root-check-firstColin Walters2021-11-011-14/+14
|\ | | | | prepare-root: check for read-only sysroot status early on