| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| | |
main: Also support CLI extensions in `/usr/libexec/libostree/ext`
|
|/
|
|
|
|
|
|
|
|
|
|
|
| |
In fixing https://github.com/coreos/rpm-ostree/pull/3323
I felt that it was a bit ugly we're installing `/usr/bin/ostree-container`.
It's kind of an implementation detail. We want users to use
`ostree container`.
Let's support values outside of $PATH too.
For example, this also ensures that TAB completion for `ost` expands
to `ostree ` with a space.
|
|\
| |
| | |
ostree: check g_setenv return value
|
|/
|
|
|
| |
This adds proper return-value checks on g_setenv calls.
It fixes a static analysis warning highlighted by Coverity.
|
|\
| |
| | |
libotutil: avoid leaking builder memory on error
|
|/
|
|
|
|
|
|
|
| |
This swaps the order of a couple of input sanity checks, in order
to fix a minor memory leak due to an early-return on the error
path.
Memory for the result is now allocated only after input has been
sanity-checked.
It fixes a static analysis warning highlighted by Coverity.
|
|\
| |
| | |
Release 2022.1
|
| | |
|
|/ |
|
|\
| |
| | |
github: add dependabot config
|
|/
|
|
|
| |
This adds a configuration file for dependabot, taking care of automatic
updates for all git submodules.
|
|\
| |
| | |
rofiles-fuse: Build using FUSE 3 if possible, falling back to FUSE 2
|
|/
|
|
|
|
|
|
| |
This adds build-time configuration logic to automatically detect
and switch between libfuse 2.x and 3.x.
Signed-off-by: Simon McVittie <smcv@collabora.com>
Co-authored-by: Luca BRUNO <luca.bruno@coreos.com>
|
|\
| |
| | |
lib/static-delta: throw a proper error on bspatch failure
|
| |
| |
| |
| |
| | |
This makes sure that a populated GError is returned when bsdiff
patching fails. The human-friendly label also helps in debugging.
|
|\ \
| |/
|/| |
bsdiff: bump submodule, pick up fix for CVE-2014-9862
|
|/
|
|
|
|
|
|
|
| |
This updates the bsdiff submodule to latest upstream revision, in
order to pick up additional bound checks for CVE-2014-9862.
Update submodule: bsdiff
Ref:
* https://www.x41-dsec.de/lab/advisories/x41-2020-006-bspatch/
|
|\
| |
| | |
lib: use ostree-content-writer header
|
|/
|
|
|
|
| |
This installs and exposes the content of `ostree-content-writer.h`,
so that library consumers can properly reference symbols defined
in that header.
|
|\
| |
| | |
two minor clang-analyzer fixes
|
| |
| |
| |
| |
| |
| |
| |
| | |
Basically due to the glib structured logging rework we lost the
`noreturn` attribute on `g_error()`.
This is fixed in glib as of https://gitlab.gnome.org/GNOME/glib/-/commit/f97ff20adf4eb7b952dd83e2c13046fe9e282f50
But we might as well just throw an error here.
|
|/
|
|
|
|
|
|
| |
Fixes `Argument with 'nonnull' attribute passed null` by making
the code not exist at all anymore.
In upstream libsoup this code is gone too; it uses `GUri` from glib
which we probably could now too, but one thing at a time.
|
|\
| |
| | |
tests/cli-extensions: tweak test logic
|
|/
|
|
|
|
| |
This updates the test logic for CLI extensions, actually checking
for functional output from the subcommand.
It also cleans up some environmental leftover.
|
|\
| |
| | |
main: add support for CLI extensions via external binaries
|
|/
|
|
|
|
|
|
|
|
| |
This adds some logic to detect and dispatch unknown subcommands to
extensions available in `$PATH`. Additional commands can be
implemented by adding relevant `ostree-$verb` binaries to the system.
As an example, if a `/usr/bin/ostree-extcommand` extension is provided,
the execution of `ostree extcommand --help` will be dispatched to that
as `ostree-extcommand extcommand --help`.
|
|\
| |
| | |
tests: assert mandatory values are present
|
|/
|
|
|
| |
This adds a couple of string assertions to make sure that
the test run is sane.
|
|\
| |
| | |
lib/repo: fix problematic invariant checks
|
| |
| |
| |
| |
| |
| | |
This turns an existing check into an assert. The previously returned
NULL may result in confusing callers, as none of them is checking for
that.
|
| |
| |
| |
| |
| | |
This turns the existing check into an assert. Otherwise, the previous
code may return an arbitrary repo mode (bare) on failure.
|
| |
| |
| |
| |
| | |
This adds an assertion to check that writable stable and error
are in sync. The subsequent logic uses them interchangeably.
|
|\ \
| |/
|/| |
Update FSF license notices to use URL instead of address
|
| | |
|
|\ \
| |/
|/| |
repo: Change locking for summary regeneration to be shared
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is trying to address:
https://pagure.io/fedora-iot/issue/48
Basically we changed rpm-ostree to start doing a shared lock during
commit by default, but this broke because pungi is starting a process
doing a commit for each architecture, and then trying to regenerate
the summary after each one.
This patch is deleting a big comment with a rationale for why
summary regeneration should be exclusive. Point by point:
> This makes sure the commits and deltas don't get
> deleted while generating the summary.
But prune operations require an exclusive lock, which means that
data still can't be deleted when the summary grabs a shared lock.
> It also means we can be sure refs
> won't be created/updated/deleted during the operation, without having to
> add exclusive locks to those operations which would prevent concurrent
> commits from working.
First: The status quo *has* prevented concurrent commits from working!
There is no real locking solution to this problem. What we really
need to do here is regenerate the summary after each commit *or*
when the caller decides to do it and e.g. include deltas at the same
time.
It's OK if multiple threads race to regenerate the summary;
last-one-wins behavior here is totally fine.
|
|\ |
|
|/
|
|
|
| |
This fixes a few warnings from coverity, none of which really
interesting.
|
|\
| |
| | |
Release 2021.6
|
| | |
|
|/ |
|
|\
| |
| | |
app: Only remount /sysroot if needed
|
|/
|
|
|
|
|
|
| |
We should only try to remount `/sysroot` if we're actually handling the
sysroot repo and the repo isn't writable. We already have public APIs to
check each of those, so let's use them.
Closes: #2485
|
|\
| |
| | |
lib/prune: Avoid unnecessary object serialization
|
|/
|
|
|
|
| |
`repo_prune_internal` was deserializing each object and passing the
components to `maybe_prune_loose_object`, which promptly reserialized
it.
|
|\
| |
| | |
lib: Avoid dereferencing NULL error values
|
|/
|
|
|
|
| |
Otherwise, this will segfault when callers don't need any exact errors.
Signed-off-by: Ryan Gonzalez <ryan.gonzalez@collabora.com>
|
|\
| |
| | |
ci: Require `libcap2-bin` for `capsh`
|
| |
| |
| |
| |
| | |
This was previously pulled in indirectly, but it looks like we need
to require it explicitly in newer Ubuntu.
|
|\ \
| | |
| | | |
Add Fedora Kinoite link
|