summaryrefslogtreecommitdiff
path: root/cfg.mk
Commit message (Collapse)AuthorAgeFilesLines
* templates: add release-checklistLuca BRUNO2020-11-181-1/+1
| | | | This collects all release steps in a release-checklist template.
* tests: Add a test case for path traversal in a dirtreeColin Walters2018-01-121-1/+1
| | | | | | | | | | | | | | | | | | | | I was reading about a recent security issue with both EMC and VMWare: https://arstechnica.com/information-technology/2018/01/emc-vmware-security-bugs-throw-gasoline-on-cloud-security-fire/ It's a classic path traversal problem, and that made me think more about our handling of this in libostree. Fortunately of course, not being new to this rodeo, long ago I *did* consider path traversal. Inside the pull code, we call `ot_util_filename_validate()`. Also, `fsck` does this too. I have further followups here, but let's add some test cases for this. I crafted a repository with a `../` in a dirtree object by patching libostree to inject it, and that's included as a tarball. This patch covers the two cases where we do already have checks; pulling via HTTP, and in `fsck`. Closes: #1412 Approved by: jlebon
* syntax-check: Add a rule to enforce glnx_autofd over glnx_fd_closeColin Walters2017-10-171-1/+5
| | | | | | | And fix the one final use. Closes: #1280 Approved by: jlebon
* tests: add a syntax-check rule for glnx_prefix_error()Colin Walters2017-06-261-0/+4
| | | | | | | | Same as the errno variant; the colon-space `: ` thing got me in a different patch. Closes: #956 Approved by: jlebon
* cfg.mk: Add a syntax check for a redundant : in glnx_throwColin Walters2017-03-231-0/+4
| | | | | | | | | This is going to be an easy bug to make when porting. Example spotted by jlebon in https://github.com/ostreedev/ostree/pull/752/files/435c2dc35c06218b8fe5b4ede0fe4f6cda535b45#diff-dbc2359685171239c4708f2a8f6aa921 Closes: #752 Approved by: jlebon
* small cleanupsJonathan Lebon2016-04-081-1/+1
| | | | | | | | | - Revert 'cannot' --> 'can not' (it's the exception!) - Remove duplicate function - Squelch compiler warnings Closes: #248 Approved by: cgwalters
* cfg.mk: ignore syntax-check for git.mkGiuseppe Scrivano2016-04-081-1/+1
| | | | | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com> Closes: #246 Approved by: cgwalters
* tests: Port to glib-tap.mk, make `make check` run all of the testsColin Walters2016-03-031-1/+1
| | | | | | | | | | | | | | | | | | OSTree's code for testing predates the `glib-tap.mk` making its way into GLib. Let's switch to it, as it provides a number of advantages. By far the biggest advantage is that `make check` can start to run most of the tests *in addition* to having them work installed. This commit keeps the installed tests working, but `make check` turns out to be really broken because...our TAP usage has bitrotted to say the least. Fix that all up. Do some hacks so that the tests work uninstalled as well - in particular, `glib-tap.mk` and the bits encoded into `g_test_build_filename()` assume *recursive* Automake (blah). Work around that by creating a symlink when installed to loop back.
* Fix make syntax-checkGiuseppe Scrivano2016-03-011-1/+1
| | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* build: exclude .sig files from syntax-checkGiuseppe Scrivano2015-04-031-1/+1
| | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* syntax-check: Remove empty lines at the end of fileGiuseppe Scrivano2015-02-021-2/+1
| | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* Replace "==" with "=" in shell script testGiuseppe Scrivano2015-01-301-1/+0
| | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* Do not interleave spaces and tabsGiuseppe Scrivano2015-01-301-1/+0
| | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* Remove magic argument numbers to exit(2)Giuseppe Scrivano2015-01-301-1/+0
| | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* Remove unused <dirent.h>Giuseppe Scrivano2015-01-301-1/+0
| | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* Remove unused include <assert.h>Giuseppe Scrivano2015-01-301-1/+0
| | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* syntax-check: quote the first argument to AC_DEFINEGiuseppe Scrivano2015-01-301-1/+0
| | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* Remove trailing dot from error messageGiuseppe Scrivano2015-01-301-1/+0
| | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* Add infrastructure for "make syntax-check"Giuseppe Scrivano2015-01-301-0/+38
New files copied from the gnulib project. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
View Lorry Controller Status