From 4a0ebe507fae41e7f080e15c492f629fdeeaf4ca Mon Sep 17 00:00:00 2001 From: Luca BRUNO Date: Tue, 7 Dec 2021 16:16:39 +0000 Subject: lib/repo: do no return an arbitrary mode on failure This turns the existing check into an assert. Otherwise, the previous code may return an arbitrary repo mode (bare) on failure. --- src/libostree/ostree-repo.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/libostree/ostree-repo.c b/src/libostree/ostree-repo.c index 85700b03..f07d2235 100644 --- a/src/libostree/ostree-repo.c +++ b/src/libostree/ostree-repo.c @@ -3816,7 +3816,8 @@ ostree_repo_equal (OstreeRepo *a, OstreeRepoMode ostree_repo_get_mode (OstreeRepo *self) { - g_return_val_if_fail (self->inited, FALSE); + g_assert (self != NULL); + g_assert (self->inited); return self->mode; } -- cgit v1.2.1