From 6230b3eeab52b132d5b7e4e164380389325db040 Mon Sep 17 00:00:00 2001 From: Luca BRUNO Date: Wed, 19 Jan 2022 13:44:10 +0000 Subject: lib/commit: always validate metadata This tweaks commit logic in order to always validate metadata, including on commits where the expected checksum is already known. --- src/libostree/ostree-repo-commit.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/libostree/ostree-repo-commit.c b/src/libostree/ostree-repo-commit.c index e2c86d96..a5aa63b0 100644 --- a/src/libostree/ostree-repo-commit.c +++ b/src/libostree/ostree-repo-commit.c @@ -2478,12 +2478,8 @@ ostree_repo_write_metadata (OstreeRepo *self, normalized = g_variant_get_normal_form (object); } - /* For untrusted objects, verify their structure here */ - if (expected_checksum) - { - if (!_ostree_validate_structureof_metadata (objtype, object, error)) - return FALSE; - } + if (!_ostree_validate_structureof_metadata (objtype, object, error)) + return FALSE; g_autoptr(GBytes) vdata = g_variant_get_data_as_bytes (normalized); if (!write_metadata_object (self, objtype, expected_checksum, -- cgit v1.2.1