From 96eec98f39054f3c1dfc6cda7e43c853157ca110 Mon Sep 17 00:00:00 2001 From: Colin Walters Date: Wed, 14 Feb 2018 15:28:17 -0500 Subject: fetcher: Drop max queue size assertion in libsoup/libcurl backends Since f4d1334e19ce3ab2f8872b1e28da52044f559401 the primary pull code maintains a maximum queue. In that commit message I said `Note that I kept an assertion.`. But I think this is wrong since while it covers a lot of the normal cases, if one is e.g. trying to fetch a ton of refs, the primary pull code doesn't yet queue those. While it'd be nice to queue those, it isn't worth carrying extra assertions in the backends that can still trigger. Closes: https://github.com/ostreedev/ostree/issues/1451 Closes: #1453 Approved by: dbnicholson --- src/libostree/ostree-fetcher-curl.c | 6 ------ 1 file changed, 6 deletions(-) (limited to 'src/libostree/ostree-fetcher-curl.c') diff --git a/src/libostree/ostree-fetcher-curl.c b/src/libostree/ostree-fetcher-curl.c index b8677e23..c4514251 100644 --- a/src/libostree/ostree-fetcher-curl.c +++ b/src/libostree/ostree-fetcher-curl.c @@ -866,12 +866,6 @@ _ostree_fetcher_request_async (OstreeFetcher *self, initiate_next_curl_request (req, task); g_hash_table_add (self->outstanding_requests, g_steal_pointer (&task)); - - /* Sanity check, I added * 2 just so we don't abort if something odd happens, - * but we do want to abort if we're asked to do obviously too many requests. - */ - g_assert_cmpint (g_hash_table_size (self->outstanding_requests), <, - _OSTREE_MAX_OUTSTANDING_FETCHER_REQUESTS * 2); } void -- cgit v1.2.1