diff options
| author | Matthias Clasen <mclasen@redhat.com> | 2021-12-08 06:44:29 -0500 |
|---|---|---|
| committer | Matthias Clasen <mclasen@redhat.com> | 2021-12-08 06:47:03 -0500 |
| commit | 2502562dd9ba30fd746bdf54a01e54dd11f87f30 (patch) | |
| tree | 3585a4f7834f3e32e65d4955538b362fa73bbe1b | |
| parent | 8b46f5db285c6c661a2a7c28c5b354426a8d5c61 (diff) | |
| download | pango-2502562dd9ba30fd746bdf54a01e54dd11f87f30.tar.gz | |
fc: Handle fonts with broken metrics better
It seems that some fonts don't have meaningful
values for underline and strikethrough metrics.
Ignore these font-provided values if they are zero.
Fixes: #616
| -rw-r--r-- | pango/pangofc-font.c | 25 |
1 files changed, 16 insertions, 9 deletions
diff --git a/pango/pangofc-font.c b/pango/pangofc-font.c index 5635e0be..f29580c3 100644 --- a/pango/pangofc-font.c +++ b/pango/pangofc-font.c @@ -365,22 +365,29 @@ get_face_metrics (PangoFcFont *fcfont, metrics->height = extents.ascender - extents.descender + extents.line_gap; } - metrics->underline_thickness = PANGO_SCALE; - metrics->underline_position = - PANGO_SCALE; - metrics->strikethrough_thickness = PANGO_SCALE; - metrics->strikethrough_position = metrics->ascent / 2; - - if (hb_ot_metrics_get_position (hb_font, HB_OT_METRICS_TAG_UNDERLINE_SIZE, &position)) + if (hb_ot_metrics_get_position (hb_font, HB_OT_METRICS_TAG_UNDERLINE_SIZE, &position) && + position != 0) metrics->underline_thickness = position; + else + metrics->underline_thickness = PANGO_SCALE; - if (hb_ot_metrics_get_position (hb_font, HB_OT_METRICS_TAG_UNDERLINE_OFFSET, &position)) + if (hb_ot_metrics_get_position (hb_font, HB_OT_METRICS_TAG_UNDERLINE_OFFSET, &position) && + position != 0) metrics->underline_position = position; + else + metrics->underline_position = - PANGO_SCALE; - if (hb_ot_metrics_get_position (hb_font, HB_OT_METRICS_TAG_STRIKEOUT_SIZE, &position)) + if (hb_ot_metrics_get_position (hb_font, HB_OT_METRICS_TAG_STRIKEOUT_SIZE, &position) && + position != 0) metrics->strikethrough_thickness = position; + else + metrics->strikethrough_thickness = PANGO_SCALE; - if (hb_ot_metrics_get_position (hb_font, HB_OT_METRICS_TAG_STRIKEOUT_OFFSET, &position)) + if (hb_ot_metrics_get_position (hb_font, HB_OT_METRICS_TAG_STRIKEOUT_OFFSET, &position) && + position != 0) metrics->strikethrough_position = position; + else + metrics->strikethrough_position = metrics->ascent / 2; } PangoFontMetrics * |