summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBehdad Esfahbod <behdad@behdad.org>2009-08-02 15:20:22 -0400
committerBehdad Esfahbod <behdad@behdad.org>2009-08-02 15:21:48 -0400
commitfac416667fed565d3d61b25b6736e39b266e22f0 (patch)
tree938e1f8713afd5215c5b9a32a646b55c09cc4dd0
parent43514625e82ace469b2d2612bc8f890d192e7b78 (diff)
downloadpango-fac416667fed565d3d61b25b6736e39b266e22f0.tar.gz
[HB] Add XXX marks
-rw-r--r--pango/opentype/hb-ot-layout-private.h2
-rw-r--r--pango/opentype/hb-ot-layout.cc7
2 files changed, 4 insertions, 5 deletions
diff --git a/pango/opentype/hb-ot-layout-private.h b/pango/opentype/hb-ot-layout-private.h
index 48e9145d..3fdd4283 100644
--- a/pango/opentype/hb-ot-layout-private.h
+++ b/pango/opentype/hb-ot-layout-private.h
@@ -28,7 +28,9 @@
#define HB_OT_LAYOUT_PRIVATE_H
#include "hb-private.h"
+
#include "hb-ot-layout.h"
+
#include "hb-buffer-private.h"
diff --git a/pango/opentype/hb-ot-layout.cc b/pango/opentype/hb-ot-layout.cc
index dd98d74f..03f7c560 100644
--- a/pango/opentype/hb-ot-layout.cc
+++ b/pango/opentype/hb-ot-layout.cc
@@ -28,10 +28,6 @@
#define HB_OT_LAYOUT_CC
-/* XXX */
-#include "hb-buffer-private.h"
-
-#include "hb-ot-layout.h"
#include "hb-ot-layout-private.h"
#include "hb-ot-layout-open-private.h"
@@ -263,7 +259,7 @@ hb_ot_layout_set_glyph_class (hb_ot_layout_t *layout,
hb_codepoint_t glyph,
hb_ot_layout_glyph_class_t klass)
{
- /* TODO optimize this, similar to old harfbuzz code for example */
+ /* TODO optimize this? similar to old harfbuzz code for example */
hb_ot_layout_class_t gdef_klass;
int len = layout->new_gdef.len;
@@ -271,6 +267,7 @@ hb_ot_layout_set_glyph_class (hb_ot_layout_t *layout,
if (HB_UNLIKELY (glyph > 65535))
return;
+ /* XXX this is not threadsafe */
if (glyph >= len) {
int new_len;
unsigned char *new_klasses;