diff options
| author | Owen Taylor <otaylor@redhat.com> | 2003-01-28 23:26:20 +0000 |
|---|---|---|
| committer | Owen Taylor <otaylor@src.gnome.org> | 2003-01-28 23:26:20 +0000 |
| commit | 6d334ce1a84b0e291515cb0d2279ead478a30f5b (patch) | |
| tree | 057205b1a5b8eda620fe337b99bf1b82ec7ee9f9 | |
| parent | 01ca2753152acdb6aa63259cd2bab4916f41b546 (diff) | |
| download | pango-6d334ce1a84b0e291515cb0d2279ead478a30f5b.tar.gz | |
Fix an off-by-one error when checking if are off the end of the coverage
Tue Jan 28 18:20:45 2003 Owen Taylor <otaylor@redhat.com>
* pango/pango-coverage.c (pango_coverage_set/get): Fix
an off-by-one error when checking if are off the end
of the coverage array. (#102284, Morten Welinder.)
* pango/pango-coverage.c (pango_coverage_get/set): Add
g_return_if_fail for index < 0.
| -rw-r--r-- | ChangeLog | 9 | ||||
| -rw-r--r-- | ChangeLog.pre-1-10 | 9 | ||||
| -rw-r--r-- | ChangeLog.pre-1-4 | 9 | ||||
| -rw-r--r-- | ChangeLog.pre-1-6 | 9 | ||||
| -rw-r--r-- | ChangeLog.pre-1-8 | 9 | ||||
| -rw-r--r-- | pango/pango-coverage.c | 6 |
6 files changed, 49 insertions, 2 deletions
@@ -1,3 +1,12 @@ +Tue Jan 28 18:20:45 2003 Owen Taylor <otaylor@redhat.com> + + * pango/pango-coverage.c (pango_coverage_set/get): Fix + an off-by-one error when checking if are off the end + of the coverage array. (#102284, Morten Welinder.) + + * pango/pango-coverage.c (pango_coverage_get/set): Add + g_return_if_fail for index < 0. + Tue Jan 28 15:18:24 2003 Owen Taylor <otaylor@redhat.com> * autogen.sh (have_automake): Fix version in complaint diff --git a/ChangeLog.pre-1-10 b/ChangeLog.pre-1-10 index 1a602878..bb76120a 100644 --- a/ChangeLog.pre-1-10 +++ b/ChangeLog.pre-1-10 @@ -1,3 +1,12 @@ +Tue Jan 28 18:20:45 2003 Owen Taylor <otaylor@redhat.com> + + * pango/pango-coverage.c (pango_coverage_set/get): Fix + an off-by-one error when checking if are off the end + of the coverage array. (#102284, Morten Welinder.) + + * pango/pango-coverage.c (pango_coverage_get/set): Add + g_return_if_fail for index < 0. + Tue Jan 28 15:18:24 2003 Owen Taylor <otaylor@redhat.com> * autogen.sh (have_automake): Fix version in complaint diff --git a/ChangeLog.pre-1-4 b/ChangeLog.pre-1-4 index 1a602878..bb76120a 100644 --- a/ChangeLog.pre-1-4 +++ b/ChangeLog.pre-1-4 @@ -1,3 +1,12 @@ +Tue Jan 28 18:20:45 2003 Owen Taylor <otaylor@redhat.com> + + * pango/pango-coverage.c (pango_coverage_set/get): Fix + an off-by-one error when checking if are off the end + of the coverage array. (#102284, Morten Welinder.) + + * pango/pango-coverage.c (pango_coverage_get/set): Add + g_return_if_fail for index < 0. + Tue Jan 28 15:18:24 2003 Owen Taylor <otaylor@redhat.com> * autogen.sh (have_automake): Fix version in complaint diff --git a/ChangeLog.pre-1-6 b/ChangeLog.pre-1-6 index 1a602878..bb76120a 100644 --- a/ChangeLog.pre-1-6 +++ b/ChangeLog.pre-1-6 @@ -1,3 +1,12 @@ +Tue Jan 28 18:20:45 2003 Owen Taylor <otaylor@redhat.com> + + * pango/pango-coverage.c (pango_coverage_set/get): Fix + an off-by-one error when checking if are off the end + of the coverage array. (#102284, Morten Welinder.) + + * pango/pango-coverage.c (pango_coverage_get/set): Add + g_return_if_fail for index < 0. + Tue Jan 28 15:18:24 2003 Owen Taylor <otaylor@redhat.com> * autogen.sh (have_automake): Fix version in complaint diff --git a/ChangeLog.pre-1-8 b/ChangeLog.pre-1-8 index 1a602878..bb76120a 100644 --- a/ChangeLog.pre-1-8 +++ b/ChangeLog.pre-1-8 @@ -1,3 +1,12 @@ +Tue Jan 28 18:20:45 2003 Owen Taylor <otaylor@redhat.com> + + * pango/pango-coverage.c (pango_coverage_set/get): Fix + an off-by-one error when checking if are off the end + of the coverage array. (#102284, Morten Welinder.) + + * pango/pango-coverage.c (pango_coverage_get/set): Add + g_return_if_fail for index < 0. + Tue Jan 28 15:18:24 2003 Owen Taylor <otaylor@redhat.com> * autogen.sh (have_automake): Fix version in complaint diff --git a/pango/pango-coverage.c b/pango/pango-coverage.c index 10b37f96..e6c59742 100644 --- a/pango/pango-coverage.c +++ b/pango/pango-coverage.c @@ -169,10 +169,11 @@ pango_coverage_get (PangoCoverage *coverage, int block_index; g_return_val_if_fail (coverage != NULL, PANGO_COVERAGE_NONE); + g_return_val_if_fail (index < 0, PANGO_COVERAGE_NONE); block_index = index / 256; - if (block_index > coverage->n_blocks) + if (block_index >= coverage->n_blocks) return PANGO_COVERAGE_NONE; else { @@ -206,11 +207,12 @@ pango_coverage_set (PangoCoverage *coverage, guchar *data; g_return_if_fail (coverage != NULL); + g_return_if_fail (index < 0); g_return_if_fail (level >= 0 || level <= 3); block_index = index / 256; - if (block_index > coverage->n_blocks) + if (block_index >= coverage->n_blocks) { int old_n_blocks = coverage->n_blocks; |