diff options
author | Behdad Esfahbod <behdad@gnome.org> | 2007-05-02 02:16:38 +0000 |
---|---|---|
committer | Behdad Esfahbod <behdad@src.gnome.org> | 2007-05-02 02:16:38 +0000 |
commit | 6a6835292717da8017371544075d491ac11e00e7 (patch) | |
tree | f94f40576b7e9a2c5439c44cf4f99ac683979c79 | |
parent | ee333c943f9e364a1ebcf1ac3f575f1580f5f517 (diff) | |
download | pango-6a6835292717da8017371544075d491ac11e00e7.tar.gz |
Add note about how we should not be using pango_break() here.
2007-05-01 Behdad Esfahbod <behdad@gnome.org>
* pango/pango-layout.c (get_items_log_attrs): Add note about
how we should not be using pango_break() here.
svn path=/trunk/; revision=2242
-rw-r--r-- | ChangeLog | 5 | ||||
-rw-r--r-- | pango/pango-layout.c | 4 |
2 files changed, 9 insertions, 0 deletions
@@ -1,3 +1,8 @@ +2007-05-01 Behdad Esfahbod <behdad@gnome.org> + + * pango/pango-layout.c (get_items_log_attrs): Add note about + how we should not be using pango_break() here. + 2007-04-28 Mathias Hasselmann <mathias.hasselmann@gmx.de> * pango-view/viewer-render.c (make_layout), (parse_alignment), diff --git a/pango/pango-layout.c b/pango/pango-layout.c index 4c6eca0a..570cd57b 100644 --- a/pango/pango-layout.c +++ b/pango/pango-layout.c @@ -3445,6 +3445,10 @@ get_items_log_attrs (const char *text, tmp_item.length += para_delimiter_len; } + /* XXX This is wrong. we should call pango_default_break on the entire + * layout text and then tailor_break on each lang_engine change, like + * pango_get_log_attrs does. + */ pango_break (text + index, tmp_item.length, &tmp_item.analysis, log_attrs + offset, tmp_item.num_chars + 1); |