Bug 416515 – Time is not aligned with date on vertical panel

2007-05-08  Behdad Esfahbod  <behdad@gnome.org>

        Bug 416515 – Time is not aligned with date on vertical panel

        * pango/pango-context.c (itemize_state_init),
        (itemize_state_update_for_new_run): centered_baseline should only 
        be set from context->resolved_gravity and never changed through
        markup.  This means that pango_context_set_base_gravity has no
        equivalent markup.  Doesn't sound limiting to me: you need to rotate
        the layout to get real vertical, so it's not just a matter of markup
        anyway.  At least not at this point.


svn path=/trunk/; revision=2266

2 files changed, 13 insertions, 3 deletions

diff --git a/ChangeLog b/ChangeLog
index 6c24ffc3..148839a1 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,15 @@
+2007-05-08  Behdad Esfahbod  <behdad@gnome.org>
+
+	Bug 416515 – Time is not aligned with date on vertical panel
+
+	* pango/pango-context.c (itemize_state_init),
+	(itemize_state_update_for_new_run): centered_baseline should only
+	be set from context->resolved_gravity and never changed through
+	markup.  This means that pango_context_set_base_gravity has no
+	equivalent markup.  Doesn't sound limiting to me: you need to rotate
+	the layout to get real vertical, so it's not just a matter of markup
+	anyway.  At least not at this point.
+
 2007-05-07  Behdad Esfahbod  <behdad@gnome.org>
 
 	Bug 436154 – Error building the pango.modules file while cross
diff --git a/pango/pango-context.c b/pango/pango-context.c
index 3a349baf..a40c8edc 100644
--- a/pango/pango-context.c
+++ b/pango/pango-context.c
@@ -855,7 +855,7 @@ itemize_state_init (ItemizeState      *state,
     state->font_desc_gravity = PANGO_GRAVITY_AUTO;
 
   state->gravity = PANGO_GRAVITY_AUTO;
-  state->centered_baseline = FALSE;
+  state->centered_baseline = PANGO_GRAVITY_IS_VERTICAL (state->context->resolved_gravity);
   state->gravity_hint = state->context->gravity_hint;
   state->resolved_gravity = PANGO_GRAVITY_AUTO;
   state->derived_lang = NULL;
@@ -1220,7 +1220,6 @@ itemize_state_update_for_new_run (ItemizeState *state)
       if (state->font_desc_gravity != PANGO_GRAVITY_AUTO)
 	{
 	  state->resolved_gravity = state->font_desc_gravity;
-	  state->centered_baseline = PANGO_GRAVITY_IS_VERTICAL (state->resolved_gravity);
 	}
       else
 	{
@@ -1230,7 +1229,6 @@ itemize_state_update_for_new_run (ItemizeState *state)
 	  if (G_LIKELY (gravity == PANGO_GRAVITY_AUTO))
 	    gravity = state->context->resolved_gravity;
 
-	  state->centered_baseline = PANGO_GRAVITY_IS_VERTICAL (gravity);
 	  state->resolved_gravity = pango_gravity_get_for_script (state->script,
 								  gravity,
 								  gravity_hint);